* Re: 01/01: gnu: Add hyperledger-fabric.
[not found] ` <20190309093500.E8CE62053E@vcs0.savannah.gnu.org>
@ 2019-03-09 11:01 ` Ludovic Courtès
2019-03-09 11:19 ` Pierre Neidhardt
2019-03-09 21:35 ` Ricardo Wurmus
0 siblings, 2 replies; 3+ messages in thread
From: Ludovic Courtès @ 2019-03-09 11:01 UTC (permalink / raw)
To: guix-devel, Pierre Neidhardt
Hello!
A couple of minor issues:
guix-commits@gnu.org skribis:
> commit 983550692dbf5a41afef1b1cae53fece42b3d4bf
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date: Thu Feb 21 19:07:09 2019 +0100
>
> gnu: Add hyperledger-fabric.
>
> * gnu/local.mk (hyperledger): New variable.
Really? :-)
> + (replace 'build
> + (lambda _
> + ;; Only linux-amd64 and linux-ppc64le seem to be supported at the moment.
> + (invoke "make" "-C" "src/github.com/hyperledger/fabric"
> + "release/linux-amd64")))
I don’t know how much of a difference it makes in this case but it might
be worth considering passing “-j” (number->string (parallel-job-count)).
> + (copy-recursively
> + "release/linux-amd64/bin"
Is this really limited to x86_64-linux? If so, please add a
‘supported-systems’ field.
Then again, this “linux-amd64” thing looks worrying: can you confirm the
checkout doesn’t contain pre-built binaries?
> + (synopsis "Platform for distributed ledger solutions")
> + (description "A platform for distributed ledger solutions, underpinned by
> +a modular architecture delivering high degrees of confidentiality, resiliency,
> +flexibility and scalability.")
Please turn the description into a sentence, and ideally something less
marketing-ish. :-)
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-09 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190309093458.29587.16437@vcs0.savannah.gnu.org>
[not found] ` <20190309093500.E8CE62053E@vcs0.savannah.gnu.org>
2019-03-09 11:01 ` 01/01: gnu: Add hyperledger-fabric Ludovic Courtès
2019-03-09 11:19 ` Pierre Neidhardt
2019-03-09 21:35 ` Ricardo Wurmus
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.