From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pierre Neidhardt <mail@ambrevar.xyz>
Subject: Re: 01/01: gnu: Add hyperledger-fabric.
Date: Sat, 09 Mar 2019 12:19:23 +0100
Message-ID: <87pnr0uwg4.fsf@ambrevar.xyz>
References: <20190309093458.29587.16437@vcs0.savannah.gnu.org>
	<20190309093500.E8CE62053E@vcs0.savannah.gnu.org>
	<8736nwcnw7.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:47769)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@ambrevar.xyz>) id 1h2a0q-0000Q4-25
	for guix-devel@gnu.org; Sat, 09 Mar 2019 06:19:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@ambrevar.xyz>) id 1h2a0p-0004if-6a
	for guix-devel@gnu.org; Sat, 09 Mar 2019 06:19:32 -0500
In-reply-to: <8736nwcnw7.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


> >     gnu: Add hyperledger-fabric.
> >=20=20=20=20=20
> >     * gnu/local.mk (hyperledger): New variable.
>=20
> Really?  :-)

Oops! :(

> I don=E2=80=99t know how much of a difference it makes in this case but i=
t might
> be worth considering passing =E2=80=9C-j=E2=80=9D (number->string (parall=
el-job-count)).

Absolutely, will do.

> Then again, this =E2=80=9Clinux-amd64=E2=80=9D thing looks worrying: can =
you confirm the
> checkout doesn=E2=80=99t contain pre-built binaries?

It does not.  The supported archs are set in the Makefile:
https://github.com/hyperledger/fabric/blob/release-1.4/Makefile#L340

> Please turn the description into a sentence, and ideally something less
> marketing-ish.  :-)

Forgot to double check that, sorry!

Thanks for the review!

=2D-=20
Pierre Neidhardt
https://ambrevar.xyz/

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlyDoTsACgkQm9z0l6S7
zH/rbgf9FGYNFQ5/4j1iWu1k2eDeR6zr7yADnE4QLcY9vUJmNB5pcFMpTh/n+2Ds
OmsN1d/mg3vcL/RJVCV5YnnaeiAh80sv84I7l4n58xwBXir1o6XhRryqhKKbOLGN
3N77jObaK+gPeF9kLl9d4JfoiOQOvyrPmR3G2B+i23PcKMv75FECbnDzFK1vfT5X
bVgVXbNtGgq3RzjgDeCIs3a2KgfOfZG2hS1FXNomO05HFAi3GKKGRxVn8Cm4CO5j
ynA8p6ZZ9w2aNA4pySQh79o91MX+tLV/jxTpS/RugxaDrUVLhrpSwIz2flyo5Sew
Yz1zVc4Qq1W6mlrOCBoPmJGVU13G8g==
=Q6+j
-----END PGP SIGNATURE-----
--=-=-=--