Re: 01/01: gnu: Add hyperledger-fabric.

Re: 01/01: gnu: Add hyperledger-fabric.

[Ludovic Courtès]

Hello!

A couple of minor issues:

guix-commits@gnu.org skribis:

> commit 983550692dbf5a41afef1b1cae53fece42b3d4bf
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date:   Thu Feb 21 19:07:09 2019 +0100
>
>     gnu: Add hyperledger-fabric.
>     
>     * gnu/local.mk (hyperledger): New variable.

Really?  :-)

> +         (replace 'build
> +           (lambda _
> +             ;; Only linux-amd64 and linux-ppc64le seem to be supported at the moment.
> +             (invoke "make" "-C" "src/github.com/hyperledger/fabric"
> +                     "release/linux-amd64")))

I don’t know how much of a difference it makes in this case but it might
be worth considering passing “-j” (number->string (parallel-job-count)).

> +                 (copy-recursively
> +                  "release/linux-amd64/bin"

Is this really limited to x86_64-linux?  If so, please add a
‘supported-systems’ field.

Then again, this “linux-amd64” thing looks worrying: can you confirm the
checkout doesn’t contain pre-built binaries?

> +    (synopsis "Platform for distributed ledger solutions")
> +    (description "A platform for distributed ledger solutions, underpinned by
> +a modular architecture delivering high degrees of confidentiality, resiliency,
> +flexibility and scalability.")

Please turn the description into a sentence, and ideally something less
marketing-ish.  :-)

Thanks,
Ludo’.

Re: 01/01: gnu: Add hyperledger-fabric.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]


> >     gnu: Add hyperledger-fabric.
> >     
> >     * gnu/local.mk (hyperledger): New variable.
> 
> Really?  :-)

Oops! :(

> I don’t know how much of a difference it makes in this case but it might
> be worth considering passing “-j” (number->string (parallel-job-count)).

Absolutely, will do.

> Then again, this “linux-amd64” thing looks worrying: can you confirm the
> checkout doesn’t contain pre-built binaries?

It does not.  The supported archs are set in the Makefile:
https://github.com/hyperledger/fabric/blob/release-1.4/Makefile#L340

> Please turn the description into a sentence, and ideally something less
> marketing-ish.  :-)

Forgot to double check that, sorry!

Thanks for the review!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 01/01: gnu: Add hyperledger-fabric.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

>> commit 983550692dbf5a41afef1b1cae53fece42b3d4bf
>> Author: Pierre Neidhardt <mail@ambrevar.xyz>
>> Date:   Thu Feb 21 19:07:09 2019 +0100
>>
>>     gnu: Add hyperledger-fabric.
>>     
>>     * gnu/local.mk (hyperledger): New variable.
>
> Really?  :-)

This is a common error when using the “add” yasnippet :)
It’s worth checking the produced commit message, because it often gets
it wrong when more than one file is altered.

-- 
Ricardo