From: Pierre Neidhardt <mail@ambrevar.xyz>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: Add hyperledger-fabric.
Date: Sat, 09 Mar 2019 12:19:23 +0100 [thread overview]
Message-ID: <87pnr0uwg4.fsf@ambrevar.xyz> (raw)
In-Reply-To: <8736nwcnw7.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
> > gnu: Add hyperledger-fabric.
> >
> > * gnu/local.mk (hyperledger): New variable.
>
> Really? :-)
Oops! :(
> I don’t know how much of a difference it makes in this case but it might
> be worth considering passing “-j” (number->string (parallel-job-count)).
Absolutely, will do.
> Then again, this “linux-amd64” thing looks worrying: can you confirm the
> checkout doesn’t contain pre-built binaries?
It does not. The supported archs are set in the Makefile:
https://github.com/hyperledger/fabric/blob/release-1.4/Makefile#L340
> Please turn the description into a sentence, and ideally something less
> marketing-ish. :-)
Forgot to double check that, sorry!
Thanks for the review!
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-03-09 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190309093458.29587.16437@vcs0.savannah.gnu.org>
[not found] ` <20190309093500.E8CE62053E@vcs0.savannah.gnu.org>
2019-03-09 11:01 ` 01/01: gnu: Add hyperledger-fabric Ludovic Courtès
2019-03-09 11:19 ` Pierre Neidhardt [this message]
2019-03-09 21:35 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnr0uwg4.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.