From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEKrE-0003Gd-GD for guix-patches@gnu.org; Wed, 10 Apr 2019 17:34:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEKlG-00033H-U9 for guix-patches@gnu.org; Wed, 10 Apr 2019 17:28:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEKlF-00032a-TZ for guix-patches@gnu.org; Wed, 10 Apr 2019 17:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEKlF-0003dP-N8 for guix-patches@gnu.org; Wed, 10 Apr 2019 17:28:01 -0400 Subject: [bug#35086] [PATCH] New package file for BOINC client & server Resent-Message-ID: From: Tobias Geerinckx-Rice References: <17ee4c77-7bf9-4a4c-b856-f9ca4ff3c7db@www.fastmail.com> <87zhoxc335.fsf@gnu.org> <47063553-553c-461d-abce-0f6732bc84ac@www.fastmail.com> In-reply-to: <47063553-553c-461d-abce-0f6732bc84ac@www.fastmail.com> Date: Wed, 10 Apr 2019 23:27:21 +0200 Message-ID: <87pnptsg92.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 35086@debbugs.gnu.org --=-=-= Content-Type: text/plain; format=flowed Brant, Brant Gardner wrote: > Hmm. I already ran 'guix lint' and did everything it advised > except for these: > > gnu/packages/boinc.scm:45:12: boinc-client@7.14.2: the source > URI should not be an autogenerated tarball > gnu/packages/boinc.scm:80:12: boinc-server@7.14.2: the source > URI should not be an autogenerated tarball > > I understand what it doesn't like, but not what it wanted me to > do instead. Could you advise? The linter would be tickled downright pink if you'd replace the current SOURCE field with something very similar to: (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/BOINC/boinc.git") (commit (string-append "client-" version)))) (sha256 (base32 "0blahblahqnjxblaaaaahf2l79ybeepityboop7wh9yayhashies")))) And so for the server as well. You'll have to replace (guix download) with (guix git-download) and update the hash once more. Thanks for your first of many patches! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXK5fugAKCRANsP+IT1Vt eb4QAP9N5TGb3o7Dg7WP3f8N2728R2n7e1UekyKIYZPMTeZjIgEA8nH1xEIaakyn zHqERSbNNmgeoX8x0ZOQ2sojh13PHgI= =8oQT -----END PGP SIGNATURE----- --=-=-=--