From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEbo4-0001W4-3c for guix-patches@gnu.org; Thu, 11 Apr 2019 11:40:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEbo2-0008N0-Sq for guix-patches@gnu.org; Thu, 11 Apr 2019 11:40:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEbo2-0008Lp-DZ for guix-patches@gnu.org; Thu, 11 Apr 2019 11:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEbo2-0005p2-9A for guix-patches@gnu.org; Thu, 11 Apr 2019 11:40:02 -0400 Subject: bug#35207: [PATCH] Resurrect pplacer. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <87zhoze3l9.fsf@elephly.net> <87r2abdqk8.fsf@elephly.net> <87v9zkitv3.fsf@elephly.net> <9091683B-549B-483B-B476-1B16B22EDA84@lepiller.eu> <87sguoio9r.fsf@elephly.net> From: Ricardo Wurmus In-reply-to: <87sguoio9r.fsf@elephly.net> Date: Thu, 11 Apr 2019 17:23:21 +0200 Message-ID: <87pnpsin12.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 35207-done@debbugs.gnu.org Ricardo Wurmus writes: > Julien Lepiller writes: > >> Le 11 avril 2019 14:55:44 GMT+02:00, Ricardo Wurmus = a =C3=A9crit : >>> >>>Ricardo Wurmus writes: >>> >>>> Julien Lepiller writes: >>>> >>>>> What's the most recent version of ocaml pplacer can use? >>>> >>>> It=E2=80=99s actually 4.01. I don=E2=80=99t know how much effort it= =E2=80=99s going to be to >>>> make it work with the latest version. >>> >>>I gave patching pplacer a try, but in more recent versions of OCaml >>>strings are byte streams, so it=E2=80=99s quite a bit of work to figure = out >>>where exactly to convert strings to byte streams and back again. >>> >>>I=E2=80=99ll keep working on this for a while, but for now I=E2=80=99d l= ike to get >>>pplacer resurrected with 4.02 first. >>> >>>-- >>>Ricardo >> >> Ok, I guess it's acceptable. I'll fully review your patches later today. > > Thanks for the offer, but it won=E2=80=99t be necessary after all. I fig= ured > out how to make it work with the latest OCaml. I had to also patch > ocaml-mcl, but that seems okay. > > New patches coming in a few minutes! I pushed the new patches to the =E2=80=9Cmaster=E2=80=9D branch with commit= 12327d7447. --=20 Ricardo