From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:48976) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hn711-0004LG-7g for guix-patches@gnu.org; Mon, 15 Jul 2019 15:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hn710-0007By-3G for guix-patches@gnu.org; Mon, 15 Jul 2019 15:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hn710-0007Bd-09 for guix-patches@gnu.org; Mon, 15 Jul 2019 15:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hn70z-0000N0-U3 for guix-patches@gnu.org; Mon, 15 Jul 2019 15:52:01 -0400 Subject: [bug#35790] [PATCH 1/2] lint: Move the linting code to a different module. Resent-Message-ID: References: <87a7dyoryh.fsf@gnu.org> <20190702192542.16179-1-mail@cbaines.net> <87pnmfgw03.fsf@gnu.org> <87wogkh4s0.fsf@cbaines.net> <87k1cjr6vv.fsf@gnu.org> From: Christopher Baines In-reply-to: <87k1cjr6vv.fsf@gnu.org> Date: Mon, 15 Jul 2019 20:51:35 +0100 Message-ID: <87pnmbgjp4.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35790@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Chris! > > Christopher Baines skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Christopher Baines skribis: >>> >>>> To try and move towards making programatic access to the linting code = easier, >>>> this commit separates out the linting script, from the linting functio= nality >>>> that it uses. >>> >>> For the final version, please write a change log. >> >> Sure, any suggestions about how to write it? I wasn't sure whether to >> list everything that had been moved from (guix scripts lint) to (guix >> lint), or say that the file has moved, and list the things that have >> been moved back. > > Maybe something like: > > * guix/scripts/lint.scm (check-foo, check-bar): Move to=E2=80=A6 > * guix/lint.scm: =E2=80=A6 here. > > and also mention things that go beyond simply moving things around (if > applicable). > > But again, don=E2=80=99t spend a whole day on this, it=E2=80=99s mostly s= o the future us > have an easily searchable log. Ok, I've made an initial attempt at this, and re-sent the patches. >> Actually, now that I've run make, that's spotted some problems in some >> checks. >> >> guix/lint.scm:198:17: warning: possibly unbound variable `texi->plain-te= xt' >> guix/lint.scm:406:8: warning: possibly unbound variable `texi->plain-tex= t' >> guix/lint.scm:737:36: warning: possibly unbound variable `fill-paragraph' >> guix/lint.scm:738:36: warning: possibly unbound variable `fill-paragraph' >> guix/lint.scm:743:20: warning: possibly unbound variable `fill-paragraph' >> >> I don't think these are as easy to solve, as these functions come from >> (guix ui). > > Ah yes, indeed. > > In that case it=E2=80=99s OK because (guix ui) is used as part of the lin= ter=E2=80=99s > job. Perhaps for clarity we should write: > > #:use-module ((guix ui) #:select (texi->plain-text fill-paragraph)) > > Uses of the =E2=80=98warning=E2=80=99 procedure or similar UI functionali= ty should be > left to (guix scripts lint), though. I've made this #:use-module change, and also moved emit-warnings to the (guix scripts lint) module. I've re-sent all 4 patches now. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl0s2UdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfEBg/+LoK0HkkCGLgoXXkQGcuBfRdlw2FsZjT7KLp9wTa3LSpl4n6dE+aHmfqv YnCXwDwASagb6KoILw4apYF5FreTcl+bgjwUkcTWZNoSYJaoWlPVKQ6SXN/RoTUC SfxEtC1XXOhRV4vVkzT86Plj/+xWcvPZBm5IoRO8yPSmdQf4Mo6lder9ISGvwxSw wPRWhnepO926ouE+OKARIYFTmAnUyFpRaLUWU8QlCxdaFAk/51gQnJvD/L/ZLAws Ypw/haY23Ij8VOWtw5ACtz+W1GTI3L6MANxmgF+anv1Lb5WQ8QBfhrzIxaHYempx 1pgnRRPXeV1I/CBqhL6R00PxnK2hpVQxjjbGBvNKBCJrh4zwcTWQNUR5NXvHzvmX eCD9HIGQd9URJVsI9S9PHSRoXhe8ALZz3L4FcBogT4wy9EwyCbGjf14QjnvyFhcE eTzDDXdrjDTOQPbiWyzAxUthRZSZwjf+H2m8SJJtI/w/C5u7BwFjvgdZo9B2j1Hp u4QFkpUCPy/kQEFFc8N/ufjDbiL4lc710FYMF6USQ0Pwzf7wtKPg8+oNEUJIaUof NFNPrL0Q8X4r9D1uYKkaBfeawVCJzWwg9YXUU/7Z89k4SdmBm+Bwfzu5x1xAC8p9 6qnReY9J/04etHdNnUWTDuLV1uDe2hf/2t0/bv3SLK9GMIC+1L8= =kCVm -----END PGP SIGNATURE----- --=-=-=--