From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45743) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5UDh-0006VM-R8 for guix-patches@gnu.org; Wed, 04 Sep 2019 08:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5UDf-0005Nx-V5 for guix-patches@gnu.org; Wed, 04 Sep 2019 08:17:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5UDe-0005Mz-9T for guix-patches@gnu.org; Wed, 04 Sep 2019 08:17:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i5UDe-0004P4-2l for guix-patches@gnu.org; Wed, 04 Sep 2019 08:17:02 -0400 Subject: [bug#37222] [PATCH] gnu: services: Add dkimproxy-out. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190829215226.173a4812@sybil.lepiller.eu> Date: Wed, 04 Sep 2019 14:16:12 +0200 In-Reply-To: <20190829215226.173a4812@sybil.lepiller.eu> (Julien Lepiller's message of "Thu, 29 Aug 2019 21:52:26 +0200") Message-ID: <87pnkg5kab.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 37222@debbugs.gnu.org Hi! Julien Lepiller skribis: >>>From 114067a7134ceb49dc5bbcef820edc49d62c8d0f Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Thu, 29 Aug 2019 21:48:25 +0200 > Subject: [PATCH] gnu: services: Add dkimproxy-out. ^ No need for =E2=80=9Cgnu:=E2=80=9D, which is only for (gnu packages =E2=80= =A6). (Confusingly=E2=80=A6) > > * gnu/services/mail.scm (dkimproxy-out-service-type): New variable. > * doc/guix.texi (Mail Services): Document it. > +@subsubheading Dkimproxy Outbound Service > +@cindex Dkimproxy Outbound Service > + Could you add an introductory paragraph, for instance mentioning what DKIM is about, linking to the Wikipedia page or something? > +@deffn {Scheme Variable} dkimproxy-out-service-type > +This is the type of the @uref{http://dkimproxy.sourceforge.net/, dkimpro= xy > +outbound daemon}, whose value should be a @code{dkimproxy-out-configurat= ion} > +object as in this example: > + > +@example > +(service dkimproxy-out-service-type > + (dkimproxy-out-configuration > + (listen "127.0.0.1:10027") ^ No tabs please. :-) > + %default-imap4d-config-file > +=09=20=20=20=20 > + dkimproxy-out-service-type Ditto (several occurrences in this file.) > +(define (generate-map-file config filename) > + (apply plain-file filename > + (map (lambda (config) > + (match config > + ((selector (config ...)) > + (string-append > + selector " " > + (string-join > + (map generate-dkimproxy-out-signature-configurati= on config) > + "\n"))) > + ((selector config) > + (string-append > + selector " " > + (generate-dkimproxy-out-signature-configuration con= fig))))) > + config))) This is incorrect since =E2=80=98plain-file=E2=80=99 takes exactly two argu= ments. Should it be something like: (plain-file file-name (string-join (map =E2=80=A6 config))) ? > + (domains > + (apply append > + (map Use =E2=80=98append-map=E2=80=99 instead. > +(define dkimproxy-out-service-type > + (service-type > + (name 'dkimproxy-out) > + (extensions > + (list (service-extension account-service-type > + (const %dkimproxy-accounts)) > + (service-extension shepherd-root-service-type > + dkimproxy-out-shepherd-service))))) Please add a =E2=80=98description=E2=80=99 field. It would be nice to have a system test too, which I guess could at least ensure that the generated config is valid and that the daemon happily starts? Thanks, Ludo=E2=80=99.