From: "Ludovic Courtès" <ludo@gnu.org>
To: Reza Alizadeh Majd <r.majd@pantherx.org>
Cc: 37738@debbugs.gnu.org
Subject: [bug#37738] [PATCH] gnu: add lxqt-connman-applet
Date: Fri, 18 Oct 2019 23:20:26 +0200 [thread overview]
Message-ID: <87pnitzr6t.fsf@gnu.org> (raw)
In-Reply-To: <433034AB-FB22-4FD9-8579-9EC1EB0F67F0@pantherx.org> (Reza Alizadeh Majd's message of "Fri, 18 Oct 2019 17:04:24 +0330")
Hi,
"Reza Alizadeh Majd" <r.majd@pantherx.org> skribis:
>> Nice. A few comments/questions:
>>
>>> +(define-public lxqt-connman-applet
>>> + (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
>>> + (revision "0"))
>>
>> Why did you choose this specific commit?
>>
>> Normally we only package upstream releases (tags); we resort to commits
>> in between releases only when there’s a good reason to do that, and in
>> that cases it’s better to add a comment explaining why we did that.
>
> since the package developers didn’t release a specific version so I
> decided to choose their latest commit in `master` branch. besides that
> I had tested the applet on LXQt desktop and it works without issues.
Oh, I see (I thought there was a 0.14.1 release, but there’s no such
thing on github.com.)
>> Please write a full description:
>>
>> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
>
> unfortunately the original developers didn’t provide any further
> details about this package yet. so is it OK to write a description
> about this package by myself?
Yes, sure!
Thank you,
Ludo’.
next prev parent reply other threads:[~2019-10-18 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 18:49 [bug#37738] [PATCH] gnu: add lxqt-connman-applet Reza Alizadeh Majd
2019-10-18 9:45 ` Ludovic Courtès
2019-10-18 13:34 ` Reza Alizadeh Majd
2019-10-18 21:20 ` Ludovic Courtès [this message]
2019-10-19 11:54 ` Reza Alizadeh Majd
2019-10-20 21:26 ` bug#37738: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnitzr6t.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37738@debbugs.gnu.org \
--cc=r.majd@pantherx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.