From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: bug#38359: Guix 1.0.1-10.41b4b71 test fails on armhf Date: Wed, 27 Nov 2019 11:42:08 +0100 Message-ID: <87pnhdbny7.fsf@gmail.com> References: <87a78ktbqm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:36490) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZuml-0001TF-7m for bug-guix@gnu.org; Wed, 27 Nov 2019 05:43:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZumk-00062k-5Y for bug-guix@gnu.org; Wed, 27 Nov 2019 05:43:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47502) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZumk-00062Y-24 for bug-guix@gnu.org; Wed, 27 Nov 2019 05:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZumj-0004zB-Ve for bug-guix@gnu.org; Wed, 27 Nov 2019 05:43:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:36397) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZulz-0001FV-Fl for bug-guix@gnu.org; Wed, 27 Nov 2019 05:42:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZuly-0005Hb-Eh for bug-guix@gnu.org; Wed, 27 Nov 2019 05:42:15 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:39105) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZuly-0005GE-7M for bug-guix@gnu.org; Wed, 27 Nov 2019 05:42:14 -0500 Received: by mail-wr1-x435.google.com with SMTP id y11so22956746wrt.6 for ; Wed, 27 Nov 2019 02:42:13 -0800 (PST) Received: from meru (lfbn-ann-1-237-90.w86-200.abo.wanadoo.fr. [86.200.196.90]) by smtp.gmail.com with ESMTPSA id s8sm5981971wmc.39.2019.11.27.02.42.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 02:42:10 -0800 (PST) In-reply-to: <87a78ktbqm.fsf@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 38359@debbugs.gnu.org --=-=-= Content-Type: text/plain About the failing test below, lzip is not found on armhf and all tests are skipped but the last one, that fails. The patch attached, makes sure that this test is also skipped if lzip is not found. Now I'm not sure why it is not found but that's another matter. WDYT? Mathieu > --8<---------------cut here---------------start------------->8--- > test-name: make-lzip-input-port/compressed > location: /tmp/guix-build-guix-1.0.1-10.41b4b71.drv-0/source/tests/lzlib.scm:111 > source: > + (test-assert > + "make-lzip-input-port/compressed" > + (let* ((len (pk 'len (+ 10 (random 4000 %seed)))) > + (data (random-bytevector len)) > + (compressed > + (make-lzip-input-port/compressed > + (open-bytevector-input-port data))) > + (result > + (call-with-lzip-input-port > + compressed > + get-bytevector-all))) > + (pk (bytevector-length result) > + (bytevector-length data)) > + random seed for tests: 1574602043 > (bytevector=? result data))) > > ;;; (len 3501) > actual-value: #f > actual-error: > + (wrong-type-arg > + #f > + "Wrong type to apply: ~S" > + (#f) > + (#f)) > result: FAIL --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-tests-lzlib-Do-not-fail-if-lzlib-in-not-available.patch >From 13d2014879372a947e3239c14bdc9f6ae8f3c318 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 26 Nov 2019 08:31:43 +0100 Subject: [PATCH] tests: lzlib: Do not fail if lzlib in not available. * tests/lzlib.scm: Use test-assert* for all test cases, so that there are no failures if lzlib is unavailable. --- tests/lzlib.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lzlib.scm b/tests/lzlib.scm index 543622bb45..d8d0e6edf8 100644 --- a/tests/lzlib.scm +++ b/tests/lzlib.scm @@ -108,7 +108,7 @@ (test-assert* "Bytevector of size relative to Lzip internal buffers (1MiB+1)" (compress-and-decompress (random-bytevector (1+ (* 1024 1024))))) -(test-assert "make-lzip-input-port/compressed" +(test-assert* "make-lzip-input-port/compressed" (let* ((len (pk 'len (+ 10 (random 4000 %seed)))) (data (random-bytevector len)) (compressed (make-lzip-input-port/compressed -- 2.24.0 --=-=-=--