all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: 38359@debbugs.gnu.org
Subject: bug#38359: Guix 1.0.1-10.41b4b71 test fails on armhf
Date: Wed, 27 Nov 2019 11:42:08 +0100	[thread overview]
Message-ID: <87pnhdbny7.fsf@gmail.com> (raw)
In-Reply-To: <87a78ktbqm.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]


About the failing test below, lzip is not found on armhf and all tests
are skipped but the last one, that fails.

The patch attached, makes sure that this test is also skipped if lzip is
not found.

Now I'm not sure why it is not found but that's another matter.

WDYT?

Mathieu

> --8<---------------cut here---------------start------------->8---
> test-name: make-lzip-input-port/compressed
> location: /tmp/guix-build-guix-1.0.1-10.41b4b71.drv-0/source/tests/lzlib.scm:111
> source:
> + (test-assert
> +   "make-lzip-input-port/compressed"
> +   (let* ((len (pk 'len (+ 10 (random 4000 %seed))))
> +          (data (random-bytevector len))
> +          (compressed
> +            (make-lzip-input-port/compressed
> +              (open-bytevector-input-port data)))
> +          (result
> +            (call-with-lzip-input-port
> +              compressed
> +              get-bytevector-all)))
> +     (pk (bytevector-length result)
> +         (bytevector-length data))
> +     random seed for tests: 1574602043
> (bytevector=? result data)))
>
> ;;; (len 3501)
> actual-value: #f
> actual-error:
> + (wrong-type-arg
> +   #f
> +   "Wrong type to apply: ~S"
> +   (#f)
> +   (#f))
> result: FAIL


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-tests-lzlib-Do-not-fail-if-lzlib-in-not-available.patch --]
[-- Type: text/x-diff, Size: 981 bytes --]

From 13d2014879372a947e3239c14bdc9f6ae8f3c318 Mon Sep 17 00:00:00 2001
From: Mathieu Othacehe <m.othacehe@gmail.com>
Date: Tue, 26 Nov 2019 08:31:43 +0100
Subject: [PATCH] tests: lzlib: Do not fail if lzlib in not available.

* tests/lzlib.scm: Use test-assert* for all test cases, so that there are no
failures if lzlib is unavailable.
---
 tests/lzlib.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/lzlib.scm b/tests/lzlib.scm
index 543622bb45..d8d0e6edf8 100644
--- a/tests/lzlib.scm
+++ b/tests/lzlib.scm
@@ -108,7 +108,7 @@
 (test-assert* "Bytevector of size relative to Lzip internal buffers (1MiB+1)"
   (compress-and-decompress (random-bytevector (1+ (* 1024 1024)))))
 
-(test-assert "make-lzip-input-port/compressed"
+(test-assert* "make-lzip-input-port/compressed"
   (let* ((len        (pk 'len (+ 10 (random 4000 %seed))))
          (data       (random-bytevector len))
          (compressed (make-lzip-input-port/compressed
-- 
2.24.0


      parent reply	other threads:[~2019-11-27 10:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 11:51 bug#38359: Guix 1.0.1-10.41b4b71 test fails on armhf Mathieu Othacehe
2019-11-25 22:08 ` bug#38359: Mistaken merge Jack Hill
2019-11-26 10:53 ` bug#38359: Guix 1.0.1-10.41b4b71 test fails on armhf Mathieu Othacehe
2019-12-02 13:33   ` Mathieu Othacehe
2019-12-09 17:07     ` Ludovic Courtès
2019-12-10 10:00       ` Mathieu Othacehe
2019-12-10 13:22         ` Ludovic Courtès
2019-11-27 10:42 ` Mathieu Othacehe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnhdbny7.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=38359@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.