From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 38460@debbugs.gnu.org
Subject: [bug#38460] [PATCH 1/1] lint: Add '--load-path' option.
Date: Sat, 07 Dec 2019 23:51:39 +0100 [thread overview]
Message-ID: <87pngzsq9w.fsf@gnu.org> (raw)
In-Reply-To: <CAJ3okZ17wZvvuvo9kD5Bb4ONPNq8DC8chAZ-cMD0E_91hT-wxA@mail.gmail.com> (zimoun's message of "Wed, 4 Dec 2019 19:21:45 +0100")
Hi!
zimoun <zimon.toutoune@gmail.com> skribis:
> On Wed, 4 Dec 2019 at 18:10, Ludovic Courtès <ludo@gnu.org> wrote:
>
>> zimoun <zimon.toutoune@gmail.com> skribis:
>>
>> > * guix/scripts/lint.scm (%options): Add '--load-path' option.
>> > * tests/guix-lint.sh: Test it.
>>
>> Awesome, I’ve been wanting that for a long time. :-)
>
> But I find this "hacky". Because it is copy/paste from other
> --load-path option elsewhere (probably "guix show" :-)).
Well, technically speaking it’s not copy/pasted since the code you sent
uses ‘find’ to grab the option; plus, we’re talking about very few
lines, which is typically hard to factorize.
So I sympathize with the bad feeling of repetition, but I’m not quite
sure how this can be avoided in this case.
WDYT?
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-12-08 2:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 20:47 [bug#38460] [PATCH 0/1] lint: Add '--load-path' option zimoun
2019-12-02 21:01 ` [bug#38460] [PATCH 1/1] " zimoun
2019-12-04 17:10 ` Ludovic Courtès
2019-12-04 18:06 ` [bug#38460] [PATCH v2] " zimoun
2019-12-04 18:21 ` [bug#38460] [PATCH 1/1] " zimoun
2019-12-07 22:51 ` Ludovic Courtès [this message]
2019-12-08 11:15 ` zimoun
2019-12-08 14:17 ` bug#38460: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pngzsq9w.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=38460@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.