From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#20145: (guix build download) leaks file descriptor on TLS
 connections
Date: Fri, 03 Jan 2020 00:19:19 +0100
Message-ID: <87png1qweg.fsf_-_@gnu.org>
References: <87oaac1zme.fsf@gnu.org> <87619w6efb.fsf@gnu.org>
 <handler.20145.D20145.145825547831659.notifdone@debbugs.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:41293)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1in9l6-0003Tr-6q
 for bug-guix@gnu.org; Thu, 02 Jan 2020 18:20:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1in9l4-0000HA-RT
 for bug-guix@gnu.org; Thu, 02 Jan 2020 18:20:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:34221)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1in9l4-0000Gw-OJ
 for bug-guix@gnu.org; Thu, 02 Jan 2020 18:20:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1in9l4-0004ts-IR
 for bug-guix@gnu.org; Thu, 02 Jan 2020 18:20:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.20145.B20145.157800717018779@debbugs.gnu.org>
In-Reply-To: <handler.20145.D20145.145825547831659.notifdone@debbugs.gnu.org>
 (GNU bug Tracking System's message of "Thu, 17 Mar 2016 22:58:02
 +0000")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: 20145@debbugs.gnu.org
Cc: Valentin Ignatev <valentignatev@gmail.com>

Hi,

Back in 2015, I closed <https://issues.guix.gnu.org/issue/20145> saying:

> ludo@gnu.org (Ludovic Court=C3=A8s) skribis:
>
>> When opening an HTTPS connection, the file descriptor beneath the port
>> returned by =E2=80=98tls-wrap=E2=80=99 is leaked.
>>
>> This is not a problem in most cases (downloads) because the process is
>> left as soon as the download is over.
>>
>> This is more problematic for =E2=80=98guix lint=E2=80=99, which may open=
 a large number
>> of HTTPS connections for the =E2=80=98source=E2=80=99 and =E2=80=98home-=
page=E2=80=99 checkers when
>> working on all the packages.
>
> This is essentially solved by commits
> 14d6ca3e4dd23ee92adb5e2fcf58546e67534631 and
> 097a951e96718a037dbfa6d579e2d26f7dab3e82.
>
> One still needs to be careful, though, for instance because closing a
> chunked encoding port (which is a custom binary input port wrapped
> around the real socket port) still fails to close the raw socket port
> that=E2=80=99s behind the TLS session record port.

Unfortunately, the bug just reported by Valentin and by Ricardo are
instances of this problem (at least I checked with crates.io and it
uses chunked encoding, leading to a file descriptor leak):

  https://issues.guix.gnu.org/issue/38857
  https://issues.guix.gnu.org/issue/38836

To be continued=E2=80=A6

Ludo=E2=80=99.