From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: qtwenengine anybody? Date: Tue, 07 Jan 2020 09:09:32 +0100 Message-ID: <87pnfvg01v.fsf@ambrevar.xyz> References: <87a77sqtdq.fsf@ambrevar.xyz> <87immgqryj.fsf@gmail.com> <871rt4qnp9.fsf@gmail.com> <87immgp582.fsf@gmail.com> <5955729d-ef57-ffb8-feb8-36a9f53658a2@crazy-compilers.com> <87d0clpbt6.fsf@gmail.com> <87y2v7e0g4.fsf@ambrevar.xyz> <87v9qb56gg.fsf@gmail.com> <87sglfotvj.fsf@ambrevar.xyz> <87o8w354m5.fsf@gmail.com> <87blrod2so.fsf@ambrevar.xyz> <878smsd2pe.fsf@ambrevar.xyz> <87mub7krlq.fsf@gmail.com> <87tv5e9acb.fsf@ambrevar.xyz> <87o8vmn6an.fsf@elephly.net> <87zhf2c5jy.fsf@gmail.com> <87lfql7k9w.fsf@elephly.net> <87d0bw2xtj.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:57044) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iojvn-00088s-56 for guix-devel@gnu.org; Tue, 07 Jan 2020 03:09:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iojvl-0007Ds-Fb for guix-devel@gnu.org; Tue, 07 Jan 2020 03:09:38 -0500 In-Reply-To: <87d0bw2xtj.fsf@devup.no> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke , Ricardo Wurmus , mike.rosset@gmail.com Cc: guix-devel@gnu.org, GNU Guix maintainers --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Fantastic, Marius! Some nits below: > ;;; Copyright =C2=A9 2019 Marius Bakke 2020 for Marius? > + ;; FIXME: libxml2 needs to built with icu support though it links= to > + ;; libxml2 configure summary still states. Checking for compatible > + ;; system libxml2... no Punctuation: =2D-8<---------------cut here---------------start------------->8--- ... still states "Checking for compatible system libxml2... no". =2D-8<---------------cut here---------------end--------------->8--- > + ;; Tests are disabled due to Could not find QtWebEngineProcess er= ror > + ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS_= PATH > + ;; before running tests It's also possible some tests need a netw= ork Punctuation: =2D-8<---------------cut here---------------start------------->8--- Test are disabled due to "Could not find QtWebEngineProcess" error. It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH before running tests. It's also possible some tests need a network. =2D-8<---------------cut here---------------end--------------->8--- > + (define (third-party? file) > + (if (string-contains file "third_party/") > + #t > + #f)) Maybe just =2D-8<---------------cut here---------------start------------->8--- (define (third-party? file) (string-contains file "third_party/")) =2D-8<---------------cut here---------------end--------------->8--- ? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl4UPLwACgkQm9z0l6S7 zH+3Ywf/dgFjZ7GAtU6653zjIVPO1ENU0e47E+km39680fcS3ogB06y0MpbTBvE4 KHeV22WAlhjlYJmJyHM1wN7w0kPx5LYV8K+kbL2U6m9Cj1dK+x0vneInKfV6L/ru 1CbUGKhTtiTe3W9Pmy4bJvIMslBzs/Lt8n/3642jyIsPh6hBLzdVSEpLbycviSvz UxerOce4ze3k5bJV8jwwvvxh8xcJOliZFjFsEaSqB/jtDFazINvRZr3ubUxq23fE DuyzWxxERFR/b/NuRNeN/7UbjBZQD1LfJxWr/8lYFBLPQLP3GseG1Lr7PmWtmUug bDyEX9DVBzY5EJJDsQ1JyfmBnkVc8Q== =Ut/f -----END PGP SIGNATURE----- --=-=-=--