From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:56053)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ivqI7-0007oT-4f
 for guix-patches@gnu.org; Sun, 26 Jan 2020 17:22:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ivqI6-0008Ev-7B
 for guix-patches@gnu.org; Sun, 26 Jan 2020 17:22:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:51648)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ivqI6-0008Eo-3r
 for guix-patches@gnu.org; Sun, 26 Jan 2020 17:22:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ivqI6-0008QD-1P
 for guix-patches@gnu.org; Sun, 26 Jan 2020 17:22:02 -0500
Subject: bug#39231: [PATCH] guix-install.sh: Correctly treat empty or unset
 $XDG_DATA_DIRS
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.39231.D39231.158007726532294.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20200121230133.12958-1-krotov@iitp.ru>
Date: Sun, 26 Jan 2020 23:20:55 +0100
In-Reply-To: <20200121230133.12958-1-krotov@iitp.ru> (Alexander Krotov's
 message of "Wed, 22 Jan 2020 02:01:33 +0300")
Message-ID: <87pnf56erc.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Alexander Krotov <krotov@iitp.ru>
Cc: 39231-done@debbugs.gnu.org

Hi,

Alexander Krotov <krotov@iitp.ru> skribis:

> If $XDG_DATA_DIRS is unset, default value of "/usr/local/share:/usr/share"
> is used according to XDG Base Directory Specification. However,
> /etc/profile.d/guix.sh treats this value as empty list when appending its
> own directory, so after installing Guix on the system, launchers such
> as Rofi stop searching for .desktop files in /usr/share/applications/
> and can't launch applications other than those installed with Guix.
>
> This patch fixes the bug in generated /etc/profile.d/guix.sh
>
> * etc/guix-install.sh (sys_create_init_profile): Use default value of
>   /usr/local/share:/usr/share/ before appending if $XDG_DATA_DIRS is not
>   set.

Good catch.  Applied, thanks!

Ludo=E2=80=99.