From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:37483)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j422l-0006Mg-FJ
 for guix-patches@gnu.org; Tue, 18 Feb 2020 07:32:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j422k-0002XM-DZ
 for guix-patches@gnu.org; Tue, 18 Feb 2020 07:32:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:33642)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j422k-0002X9-BB
 for guix-patches@gnu.org; Tue, 18 Feb 2020 07:32:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j422k-0005w2-84
 for guix-patches@gnu.org; Tue, 18 Feb 2020 07:32:02 -0500
Subject: [bug#37868] [PATCH v2 2/2] system: Add kernel-module-packages to
 operating-system.
Resent-Message-ID: <handler.37868.B37868.158202911822583@debbugs.gnu.org>
References: <20191112172048.61ba69eb@scratchpost.org>
 <20200218094207.6196-1-dannym@scratchpost.org>
 <20200218094207.6196-3-dannym@scratchpost.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20200218094207.6196-3-dannym@scratchpost.org>
Date: Tue, 18 Feb 2020 13:31:49 +0100
Message-ID: <87pnecnkju.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 37868@debbugs.gnu.org
Cc: mhw@netris.org, ludo@gnu.org, dannym@scratchpost.org


Hello Danny,

Thanks for this patch! A few remarks below.

> +                               ; TODO: system, target.
> +                               #:system #f
> +                               #:target #f)))

We need to figure out what #:system and #:target to pass, otherwise it
will break system compilation with --system and --target. This is
somehow linked to this thread[1].

> +(define (linux-module-database manifest)

This is a rather long and over 80 columns procedure.  Maybe you should
consider split it into several functions.

> +                                (display "FAILED\n" (current-error-port))

This could be more specific and would need to be translated.

Mathieu

[1]: https://lists.gnu.org/archive/html/guix-patches/2019-12/msg00416.html