From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: native or not
Date: Tue, 31 Mar 2020 09:27:43 +0200
Message-ID: <87pnctc7bk.fsf@gmail.com>
References: <CAEwRq=oTK1bSWh8dCBLMxGEcf84pMW1ja-Ue5WfZndm_Z4+p8Q@mail.gmail.com>
 <87a73ypbyb.fsf@gmail.com>
 <CAEwRq=pj9jLAwQOP90X44dFvUjw4o-CuA=asF26AkKvecoyWOA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:50973)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <m.othacehe@gmail.com>) id 1jJBJL-00017f-SP
 for guix-devel@gnu.org; Tue, 31 Mar 2020 03:27:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <m.othacehe@gmail.com>) id 1jJBJK-0003Ob-Nu
 for guix-devel@gnu.org; Tue, 31 Mar 2020 03:27:47 -0400
Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:33968)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <m.othacehe@gmail.com>)
 id 1jJBJK-0003O2-Hd
 for guix-devel@gnu.org; Tue, 31 Mar 2020 03:27:46 -0400
Received: by mail-wr1-x431.google.com with SMTP id 65so24586861wrl.1
 for <guix-devel@gnu.org>; Tue, 31 Mar 2020 00:27:46 -0700 (PDT)
In-reply-to: <CAEwRq=pj9jLAwQOP90X44dFvUjw4o-CuA=asF26AkKvecoyWOA@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>


Hey,

> I'm not seeing any size difference, but groff is not in the output:

OK, then its normal.

> That fails on master (libpaper) whereas with the patch it works,
> so I guess the patch is useful on that front.
>
> The patch for sudo will be in the following emails.
>
> Is there anything else to check / test ?

Well you can also check for deterministic compilation, and all the other
items listed here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

Also be careful because there were quite a lot of cross-compilation
related patches pushed on core-updates. You may want to check that you
are not duplicating this work.

Anyway, most of the packages that should cross-compile fail to do so
because of inputs/native-inputs mix-up, so your patches are really
welcome :)

Thanks,

Mathieu