From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38744) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRDmS-00019E-E2 for guix-patches@gnu.org; Wed, 22 Apr 2020 07:43:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRDmR-00023A-12 for guix-patches@gnu.org; Wed, 22 Apr 2020 07:43:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRDmQ-00020Z-LT for guix-patches@gnu.org; Wed, 22 Apr 2020 07:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRDmQ-0004A9-Jf for guix-patches@gnu.org; Wed, 22 Apr 2020 07:43:02 -0400 Subject: [bug#40677] [PATCH 01/18] gnu: jami: Move Jami and its dependencies to jami.scm. Resent-Message-ID: From: Mathieu Othacehe References: <20200417015857.0650ff6a@interia.pl> <20200421161032.1847-1-tona_kosmicznego_smiecia@interia.pl> <87k127q4jo.fsf@gmail.com> <20200422124253.18543e01@kompiuter> Date: Wed, 22 Apr 2020 13:42:33 +0200 In-Reply-To: <20200422124253.18543e01@kompiuter> (Jan's message of "Wed, 22 Apr 2020 12:42:53 +0200") Message-ID: <87pnbzoifq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jan Cc: 40677@debbugs.gnu.org > I passed the "-v2", didn't it wrok? No, I would expect the patch subject to look like "[PATCH v2 x/y]". What I do is to run git format-patch this way: --8<---------------cut here---------------start------------->8--- git format-patch -4 --cover-letter --subject-prefix=3D"PATCH v2" --8<---------------cut here---------------end--------------->8--- there might better ways though. > >> You also need to write commit messages respecting this >> https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs >> as I already told you. > I have to read it one more time then, it's a bit unintuitive and > complicated. Yes, you can browse the git log for examples. > >> > +;;; GNU Guix --- Functional package management for GNU >> > +;;; Copyright =C2=A9 2019 Pierre Neidhardt =20=20 >>=20 >> Why is Pierre copyright here? > As far as I know he was an original author or maintainer of the > packages. > Isn't it required when copying a copyrighted work? Ok, then you might want to add Ludo and Vincent copyrights that appear to have modified those packages according to git blame. Thanks, Mathieu