From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aCQQE+xKsF4TPgAA0tVLHw (envelope-from ) for ; Mon, 04 May 2020 17:03:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ODNTGfZKsF7rIQAAB5/wlQ (envelope-from ) for ; Mon, 04 May 2020 17:03:50 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B6CA94554A for ; Mon, 4 May 2020 14:36:46 +0000 (UTC) Received: from localhost ([::1]:51918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVcD7-00018h-Nv for larch@yhetil.org; Mon, 04 May 2020 10:36:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVcAU-0004b4-Vs for guix-patches@gnu.org; Mon, 04 May 2020 10:34:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVcAU-0000Ra-JG for guix-patches@gnu.org; Mon, 04 May 2020 10:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVcAU-0001Nh-H1 for guix-patches@gnu.org; Mon, 04 May 2020 10:34:02 -0400 Subject: bug#40931: [PATCH v2] gnu: add j4-dmenu-desktop Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 04 May 2020 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 40931 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex McGrath , 40931 <40931-done@debbugs.gnu.org> Mail-Followup-To: 40931@debbugs.gnu.org, mbakke@fastmail.com, amk@amk.ie Received: via spool by 40931-done@debbugs.gnu.org id=D40931.15886027975237 (code D ref 40931); Mon, 04 May 2020 14:34:02 +0000 Received: (at 40931-done) by debbugs.gnu.org; 4 May 2020 14:33:17 +0000 Received: from localhost ([127.0.0.1]:33611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVc9l-0001MP-D4 for submit@debbugs.gnu.org; Mon, 04 May 2020 10:33:17 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:33725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVc9i-0001MB-Va for 40931-done@debbugs.gnu.org; Mon, 04 May 2020 10:33:15 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 557C1399; Mon, 4 May 2020 10:33:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 04 May 2020 10:33:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=oocB6BihPqwq40RC2vrNcHS1yH zCPBBPrm1DzxMG9h4=; b=dz1wcn8vhzNoi5MC9563juRyZBIQF+nfn4t8igbZZn eTpyq7rw8hrrd7OAIb79ny/SBmAW+tWrzPBrW2Pzs7kKaBYs1RL0OUI/ov0qsKU5 IniwIQwcg5kvnICjupirlloov8HCZj8zwQZTE4ZjlSIgGIpG4yH4lD2Lab2ocnQI xLsi+cOvEyAS1z0O0NGE9Tw50a7WCJ32F2UCVB5dW5zMjIwRAYp5PdANaGy5SfjB WQiL5zvsVYNR0g6jUsr4iSDHnfAqJHjCMWMuJWD5p1DPIMFHnvkIF/jSF9vxPJSS UrNqHld1lchXyejy5Pej1VCCFpN42BTzJ9F/ZjOmnu3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=oocB6B ihPqwq40RC2vrNcHS1yHzCPBBPrm1DzxMG9h4=; b=n7OB92MHsCNiZMqcFNCAYd iSo4dIBw1W4HpNaEzya9UhLuWVPWqMF/gRu012VHBSh25vkTqmdIrFuKcRm9ydr0 pDKc8/v4aUz3ZdqLUtO6LfQHMTNqNpjDp/AKG1JNgEzmhndbdIODyZN1IACvsF+o hnMLF0i9pSbKyzVXD9wMCM1Y+iufOW1C27fmqjPClD5S0dLu2yEopZaV0fJNF+m+ 2DfhEGoiMnSw316Wn8/rw9zpQq4+odmiI91tVqn8eWrb5aXmgNqmoYJpfoC63Lcs IJ/9xOFK3fQeZcpohVsgTywWXng3T7lQWQrOXrOd165x4oK9iVBEuMObtcNUCpuA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeggdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpedtvdfggeevgeeivdffueejiedtte dvkedtudfggfdtgeefiedtieekffdugfeuffenucfkphepkeegrddvtddvrdeikedrjeeh necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgsrg hkkhgvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 604963280059; Mon, 4 May 2020 10:33:07 -0400 (EDT) From: Marius Bakke In-Reply-To: References: <20200428103705.22597-1-amk@amk.ie> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Mon, 04 May 2020 16:33:05 +0200 Message-ID: <87pnbj22ji.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -2.01 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=fastmail.com header.s=fm2 header.b=dz1wcn8v; dkim=fail (rsa verify failed) header.d=messagingengine.com header.s=fm2 header.b=n7OB92MH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-2.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49481137369814]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; FREEMAIL_FROM(0.00)[fastmail.com]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.13), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; R_DKIM_REJECT(1.00)[fastmail.com:s=fm2,messagingengine.com:s=fm2]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[fastmail.com:-,messagingengine.com:-]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mbakke@fastmail.com,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[amk.ie:email]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[fastmail.com : SPF not aligned (relaxed),none] X-TUID: Z/+mEkOVszgn --=-=-= Content-Type: text/plain "Alex McGrath" writes: > Howdy, > > I think I've addressed the comments (ran guix lint etc) and I enabled all the tests except for one, as it checks for a directory that doesnt exist on guix and fails as a result Excellent, LGTM! I've applied the patch with minor adjustments (removed redundant #:tests? #t, and formatted description with @file and @command markup where appropriate). Pushed in c65e243463c704698288bad787cd6f5292280bba, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6wJ6EACgkQoqBt8qM6 VPoIwwgA0j0Ug8yYiykViRUs40lhhsa57/CJLAIe9PdbiLgVX1Gz5LISAjqnlhWC QuKQW+dbGIr2aTDX6yP4sjX/Wo2T8RisRjClaBT2XHCOplyDLJ+fZyozpCzTRzN/ i1ojjVqZ9E+etoWLwvniMCRj3lmRmDZorNWrwMxIKEWq5IqHTgk+ghtsT7ulEQB0 zoP4y8rqqia0C2wHE5kKwi40jUbjETNPJ1+SxZ+Bpj5IvUTET7xO0sWN+pWo0H21 gfkN825XE2zL39FKE3IY73rajsEtnIA0HKlV4wUiN6/kAMgOioVywZSCLypdjWPh lqRhgc1EFweJEmN6Md0CwVX9twxeMw== =gApD -----END PGP SIGNATURE----- --=-=-=--