From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0L+3DR4nzF7ZagAA0tVLHw (envelope-from ) for ; Mon, 25 May 2020 20:14:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gAWPCR4nzF6tTwAAbx9fmQ (envelope-from ) for ; Mon, 25 May 2020 20:14:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE1C1940145 for ; Mon, 25 May 2020 20:14:21 +0000 (UTC) Received: from localhost ([::1]:37768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdJUK-0000Wu-Np for larch@yhetil.org; Mon, 25 May 2020 16:14:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdJU2-0000Wh-6k for guix-devel@gnu.org; Mon, 25 May 2020 16:14:02 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:35416) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdJU1-0004oY-7a; Mon, 25 May 2020 16:14:01 -0400 Received: from localhost (71-34-65-38.ptld.qwest.net [71.34.65.38]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 281301A9BD; Mon, 25 May 2020 13:13:57 -0700 (PDT) From: Vagrant Cascadian To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Efraim Flashner Subject: Re: Updating the =?utf-8?B?4oCccHJlLXB1c2jigJ0=?= Git hook In-Reply-To: <878shhxb0h.fsf@gnu.org> References: <87imgn8zsv.fsf@gnu.org> <20200524064115.GC858@E5400> <878shhxb0h.fsf@gnu.org> Date: Mon, 25 May 2020 13:13:16 -0700 Message-ID: <87pnar22oz.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/25 16:13:57 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: BB7XjtIqF02+ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2020-05-24, Ludovic Court=C3=A8s wrote: > Efraim Flashner skribis: >> On Fri, May 22, 2020 at 10:44:48PM +0200, Ludovic Court=C3=A8s wrote: >>> Hello Guix! >>>=20 >>> I think we should change our pre-push hook as shown below. >>>=20 >>> Thoughts? ... >> (ins)efraim@E5400 ~$ type -P make >> (ins)efraim@E5400 ~$ command -v make >> >> I'd need to run 'guix environment --ad-hoc make -- git push' > > You=E2=80=99d need to run =E2=80=98git push=E2=80=99 from a full Guix dev= elopment environment. > Do you think it could be a problem? Wait a minute... you're saying this is something that needs to be configured on each committer's machine(s)? Shouldn't it be on the server-side recieve hooks instead, otherwise someone might accidentally (or intentially) push commits not appropriately signed to the repository or validated by this check... Or is this an optional check for recommended for committers? Have I been missing something all along that I was supposed to be doing? For my own workflow, I usually do not (yet) sign or push commits from a machine with guix installed... it's a bit awkward, admittedly, but I don't yet have any SSH or OpenPGP keys I trust guix with directly (ironically, "make authenticate" is working towards addressing exactly that trust issue). live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCXswm3AAKCRDcUY/If5cW qh9IAPoDAwMvH2lZOa8+ag4WsQLRSqCkafNLqjwCAfEYIa4tqAEA/AzruYuu9rpd FpC9awo5IWRmG6abpBqPuOlAJUni0gM= =GJj7 -----END PGP SIGNATURE----- --=-=-=--