From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wF+xGnmfnV/beQAA0tVLHw (envelope-from ) for ; Sat, 31 Oct 2020 17:31:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gA2TFnmfnV+4ewAAB5/wlQ (envelope-from ) for ; Sat, 31 Oct 2020 17:31:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BEE169401D0 for ; Sat, 31 Oct 2020 17:31:36 +0000 (UTC) Received: from localhost ([::1]:41750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYuj0-0007qx-7X for larch@yhetil.org; Sat, 31 Oct 2020 13:31:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYuiU-0007qF-VD for guix-patches@gnu.org; Sat, 31 Oct 2020 13:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYuiU-00055e-AS for guix-patches@gnu.org; Sat, 31 Oct 2020 13:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYuiU-0007b7-8C for guix-patches@gnu.org; Sat, 31 Oct 2020 13:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44344] [PATCH] guix: describe: Improve package provenance tracking. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 31 Oct 2020 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44344 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 44344@debbugs.gnu.org Received: via spool by 44344-submit@debbugs.gnu.org id=B44344.160416541929136 (code B ref 44344); Sat, 31 Oct 2020 17:31:02 +0000 Received: (at 44344) by debbugs.gnu.org; 31 Oct 2020 17:30:19 +0000 Received: from localhost ([127.0.0.1]:34478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYuhm-0007Zs-V7 for submit@debbugs.gnu.org; Sat, 31 Oct 2020 13:30:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYuhl-0007Zc-8r for 44344@debbugs.gnu.org; Sat, 31 Oct 2020 13:30:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41455) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYuhe-0004qc-G9; Sat, 31 Oct 2020 13:30:10 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57658 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYuhd-0005Rl-VL; Sat, 31 Oct 2020 13:30:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201031144007.25531-1-julien@lepiller.eu> Date: Sat, 31 Oct 2020 18:30:07 +0100 In-Reply-To: <20201031144007.25531-1-julien@lepiller.eu> (Julien Lepiller's message of "Sat, 31 Oct 2020 15:40:07 +0100") Message-ID: <87pn4ytiao.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: wJUoyesbFiXT Hi Julien, Julien Lepiller skribis: > %load-path lists ~/.config/guix/current before individual channels. We > use canonicalize-path to get the store path for channel packages. > > * guix/describe.scm (package-provenance): Use canonicalize-path. [...] > (let ((file (if (string-prefix? "/" file) > file > - (search-path %load-path file)))) > + (canonicalize-path (search-path %load-path file))))) Could you explain what problem it solves, perhaps with a simple reproducer? =E2=80=98search-path=E2=80=99 can return #f (there=E2=80=99s a test right b= elow), so this should probably be: (and=3D> (search-path =E2=80=A6) canonicalize-path). As a rule of thumb, I think twice before calling =E2=80=98canonicalize-path= =E2=80=99 because (1) it=E2=80=99s expensive (lots of stat(2) calls), and (2) it can = have undesirable effects on the UI (messages mention a file name other than the one the user typed) and elsewhere (on logic that looks at what the file name looks like). Maybe it=E2=80=99s OK here, but I mention this for completeness. Thanks, Ludo=E2=80=99.