From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4LaUKeSIAGDUGgAA0tVLHw (envelope-from ) for ; Thu, 14 Jan 2021 18:09:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UL9wJeSIAGBEQAAAB5/wlQ (envelope-from ) for ; Thu, 14 Jan 2021 18:09:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 30C02940481 for ; Thu, 14 Jan 2021 18:09:40 +0000 (UTC) Received: from localhost ([::1]:35290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l073y-0004Hv-2y for larch@yhetil.org; Thu, 14 Jan 2021 13:09:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l06p0-0007kt-7U for help-guix@gnu.org; Thu, 14 Jan 2021 12:54:10 -0500 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:35230) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l06ox-0000AO-E5 for help-guix@gnu.org; Thu, 14 Jan 2021 12:54:10 -0500 Received: by mail-qk1-x731.google.com with SMTP id n142so9120615qkn.2 for ; Thu, 14 Jan 2021 09:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=jPyDuLePz870TLlXJNkgmqgQ9Rgqn4/ldg1i0nZvgWE=; b=QfhF/87LgLOktDBoWN6VyWqEXRQ2ca5tg6JU1ZNkkONrc98rvomX/7HeKT1FcfqZHF KWyXqzhk/3/Tk7L6bQBiplwxQwPzkWhb9BXlSQCoSm4I7I9d37w/PLmKJBqmTKw7Mqr1 fOleyMivKrG+yGKYswsX6XTUqx4jnQrx2rqkyT6uitcFUADtITA5jtmAPuQE7PoHO9cZ JDkzYwoyAMWsILZQBgSFfgXGIS18QUBAJ+TF1HsEafDdZhPJkfNMDxVk/YRdRMOxx5gC jyCrhb+HxNfzkcQ/YoMid8PiU132s8XKLMkwtOXW9/dK1JlhmZvmFkx8V9x6cLZUPKUR dd5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jPyDuLePz870TLlXJNkgmqgQ9Rgqn4/ldg1i0nZvgWE=; b=JGs9Q26mJOoRpqyp0cqDJfG2+6C9aQy9NV0NHpSgmeF/NOhbgpROXR/ewU6xf46Cxa Le4wsGeLBFXdaCJhUoTzaodSkHaNvlbv8DVSDSZs9w0bSIaYHB0WMGg6aAaBLRymbYib UEYE9BoJzg2IBdsLAqU0y880nH2r2PpPiEKWn3EQ5cVjSlxArAvDrLy40nEdzUgglIUb Uq0pOHXKmuaOMWD3MzcJuj0kj6QWCUR5SfzTmWo0Y/KJ8r2zIHCyMlYNc992FmEG0asH +E0jQYXD0OEh8hjYbntfpAnt5hmHV0ZoIXKL9Dr6N1mdFx15ZolgG4lLq3LPzsRpXz3H 2muw== X-Gm-Message-State: AOAM531gvtH/F/ULtmJjt4LAXH2mQgbccEZeCMMTGzuQzD8YNm4YcZ0L FYHZfb0uezlO6NK7f1/mWTyW5+n9Aco= X-Google-Smtp-Source: ABdhPJzZ04mEx5y04zMeulWnGC7nca+3SbsjytsB3F9sdOs7LUpBx3OCNVf4C/f0wyHUqOShfWemcQ== X-Received: by 2002:a37:9f4b:: with SMTP id i72mr8605296qke.222.1610646846036; Thu, 14 Jan 2021 09:54:06 -0800 (PST) Received: from hurd (dsl-157-252.b2b2c.ca. [66.158.157.252]) by smtp.gmail.com with ESMTPSA id 9sm3371771qtr.64.2021.01.14.09.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 09:54:05 -0800 (PST) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: Behaviour change when closing laptop lid: it no longer suspends References: <87wnxfkzub.fsf@ambrevar.xyz> <87r1nnus9a.fsf@nckx> <87r1nnkuf1.fsf@ambrevar.xyz> <87a6ubf7ai.fsf@ambrevar.xyz> <87y2hunbvm.fsf@nckx> <877dpd6hph.fsf@nckx> <87turjlbzw.fsf@gmail.com> <871rens9a2.fsf@nckx> Date: Thu, 14 Jan 2021 12:54:04 -0500 In-Reply-To: <871rens9a2.fsf@nckx> (Tobias Geerinckx-Rice's message of "Thu, 14 Jan 2021 18:44:37 +0100") Message-ID: <87pn27l803.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::731; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x731.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tobias Geerinckx-Rice via Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: "Help-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=QfhF/87L; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of help-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=help-guix-bounces@gnu.org X-Migadu-Queue-Id: 30C02940481 X-Spam-Score: -3.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: ozTxeKZ4ZVXR Hi Tobias, Tobias Geerinckx-Rice writes: > Maxim, > > Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >> Shouldn't that be the default behavior though? > > That's subjective. I don't think we should ever editorialise if > that's what you mean: Guix service configuration wrappers should=20 > strictly wrap, not tweak defaults on a (majority) whim. Agreed. > However, here our wrapping is wrong. Thanks for making me look into > it. > > From upstream's change log: > > The action that elogind takes when the lid is closed and the > machine is connected to external power can now be configured > using HandleLidSwitchExternalPower=3D in logind.conf. Previously, > this action was determined by HandleLidSwitch=3D, and, for > backwards compatibility, is still is, if > HandleLidSwitchExternalPower=3D is not explicitly set. > > Whilst we: > > ("HandleLidSwitchExternalPower" > (handle-action elogind-handle-lid-switch-external-power)) > > always =E2=80=98explicitly set=E2=80=99 HandleLidSwitchExternalPower, by = default to > =E2=80=98ignore=E2=80=99, breaking that intention. > > elogind-handle-lid-switch-external-power should not emit a directive > if unset. In fact, all directives and all services should do that by > default, *not* hard-code upstream's default at an arbitrary point in > time. Oh, nice find! So we have something to fix. > Unfortunately most do, making subtle bugs like these more likely. > >> Like Pierre, I'm also certain that the default behavior was changed >> at >> some point. > > I didn't find any evidence for this in the commit log but didn't > search exhaustively. I'm guessing if nothing changed in our side, the behavior of elogind itself must have changed. Thank you, Maxim