[bug#46873] [PATCH 0/2] gnu: knot-resolver: Fix phase return value; update to 5.3.0

[bug#46873] [PATCH 0/2] gnu: knot-resolver: Fix phase return value; update to 5.3.0

[Simon South]

These patches update the Knot Resolver package to

- Ensure the custom "move-doc" phase returns #t on success, eliminating this
  warning message while building:

    ## WARNING: phase `move-doc' returned `#<unspecified>'.  Return values other than #t
    ## are deprecated.  Please migrate this package so that its phase
    ## procedures report errors by raising an exception, and otherwise
    ## always return #t.

- Update Knot Resolver itself to 5.3.0.

I've tested these changes on x86_64 and aarch64, and have been running the new
version on aarch64-linux without issue.

--
Simon South
simon@simonsouth.net


Simon South (2):
  gnu: knot-resolver: Ensure all custom phases return #t on success.
  gnu: knot-resolver: Update to 5.3.0.

 gnu/packages/dns.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.30.1

[bug#46873] [PATCH 1/2] gnu: knot-resolver: Ensure all custom phases return #t on success.

[Simon South]

* gnu/packages/dns.scm (knot-resolver)[arguments]<#:phases>: Return #t from
"move-doc" phase on success.
---
 gnu/packages/dns.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
index 2c4008559f..5b0e310a0c 100644
--- a/gnu/packages/dns.scm
+++ b/gnu/packages/dns.scm
@@ -979,7 +979,8 @@ synthesis, and on-the-fly re-configuration.")
                                (string-append doc "/share/" dir)))
                 '("doc/knot-resolver/examples"
                   "doc/knot-resolver/html"
-                  "info")))))
+                  "info"))
+               #t)))
          (add-after 'install 'wrap-binary
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
-- 
2.30.1

[bug#46873] [PATCH 2/2] gnu: knot-resolver: Update to 5.3.0.

[Simon South]

* gnu/packages/dns.scm (knot-resolver): Update to 5.3.0.
---
 gnu/packages/dns.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
index 5b0e310a0c..bc876ff5c1 100644
--- a/gnu/packages/dns.scm
+++ b/gnu/packages/dns.scm
@@ -942,14 +942,14 @@ synthesis, and on-the-fly re-configuration.")
 (define-public knot-resolver
   (package
     (name "knot-resolver")
-    (version "5.2.1")
+    (version "5.3.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://secure.nic.cz/files/knot-resolver/"
                                   "knot-resolver-" version ".tar.xz"))
               (sha256
                (base32
-                "09jqy23q1pgj76y2qd1xfk72wwmypnyawm3span3gx00qi2bfdxa"))))
+                "0gp3ivv3zccz4b6s1wxbsvvlrc837lw2g089l3cbvzsg7z0b4v7v"))))
     (build-system meson-build-system)
     (outputs '("out" "doc"))
     (arguments
-- 
2.30.1

[bug#46873] [PATCH 1/2] gnu: knot-resolver: Ensure all custom phases return #t on success.

[Tobias Geerinckx-Rice via Guix-patches via]

Simon South 写道：
> * gnu/packages/dns.scm (knot-resolver)[arguments]<#:phases>: 
> Return #t from
> "move-doc" phase on success.

Thanks, but I don't think this is worth the noise at this point: 
that requirement will be gone on the next core-updates merge, and 
there will be much rejoicing.

The update itself LGTM; I'll test it now.

Kind regards,

T G-R

bug#46873: [PATCH 2/2] gnu: knot-resolver: Update to 5.3.0.

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

Simon South 写道：
> * gnu/packages/dns.scm (knot-resolver): Update to 5.3.0.

It resolves things all right.  Update pushed as 
673ab1cdb4702ae2b79434ee1f5b3095eebf8eb3, without the #t.

Thanks again,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]