From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KIKZEfvIT2AJGwAA0tVLHw (envelope-from ) for ; Mon, 15 Mar 2021 20:52:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cCxqDfvIT2DHNQAA1q6Kng (envelope-from ) for ; Mon, 15 Mar 2021 20:52:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F03CDD348 for ; Mon, 15 Mar 2021 21:52:10 +0100 (CET) Received: from localhost ([::1]:44932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLuCA-0004mH-5u for larch@yhetil.org; Mon, 15 Mar 2021 16:52:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLuC2-0004ka-4M for guix-patches@gnu.org; Mon, 15 Mar 2021 16:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLuC1-0006rv-T3 for guix-patches@gnu.org; Mon, 15 Mar 2021 16:52:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLuC1-0000m6-Ro for guix-patches@gnu.org; Mon, 15 Mar 2021 16:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47160] [PATCH] scripts: substitute: Add back some error handling. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Mar 2021 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47160 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 47160@debbugs.gnu.org Received: via spool by 47160-submit@debbugs.gnu.org id=B47160.16158414722920 (code B ref 47160); Mon, 15 Mar 2021 20:52:01 +0000 Received: (at 47160) by debbugs.gnu.org; 15 Mar 2021 20:51:12 +0000 Received: from localhost ([127.0.0.1]:37368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLuBD-0000l2-Vc for submit@debbugs.gnu.org; Mon, 15 Mar 2021 16:51:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLuBC-0000ko-3j for 47160@debbugs.gnu.org; Mon, 15 Mar 2021 16:51:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52173) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLuB6-0006L1-RA; Mon, 15 Mar 2021 16:51:04 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46690 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lLuB6-0008PK-1v; Mon, 15 Mar 2021 16:51:04 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210315151133.16282-1-mail@cbaines.net> <8735wwh29g.fsf@gnu.org> <874khcfl6j.fsf@cbaines.net> Date: Mon, 15 Mar 2021 21:51:02 +0100 In-Reply-To: <874khcfl6j.fsf@cbaines.net> (Christopher Baines's message of "Mon, 15 Mar 2021 16:15:00 +0000") Message-ID: <87pn00b0p5.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615841531; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=nzKX3FfnGaiCaRhdg71KxZIJ+8C3sG6Y5uBmX2YJ4cA=; b=qDU18hvyCu0uUlF9URTvOIFmlvGFwgrtofel2fBkLQHlQQ4LsTJgg3E1nPrcr6xr9t2RUb gujGjfHtxmOeDamE5w89+sESVM+nsB/2qMqguUJr6CS6YzlwiJdjeSyP68ZkrHabI+ofl8 YbX22Qj0gf0rjyUL02001RZKWMD/Oh7WzVKsNoxK2XGszJXUKuOAIjZ90jlO9666vxY58v HIDsTGTltBCINcD46IC5scVT5rAN2OIUKCpzkd4Ii68b8ldboMkm+Xsc5BZaZmSgQClhzg NRedFOOd/pYHRa0Xd8lCJCTU6QIYzybUQS9ckEFi1cyIzbjvKlFWPOnRkZQ2Mw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615841531; a=rsa-sha256; cv=none; b=d06oVbEQVoOF4aexFFUDSc3AexXIOlo6jeSo7ap8CTXQhjfiFdXcR8XGBsrlc3Is0C2AmA F6kSQt1jbjPqkK20hAm7xq7grWskeROwfebF3f+4w+q4yB9nx52yTzraQAW3g017zWZ66F Dcf4zmHxQCxhoATz0kITzBQ4tEKYhHIV5/xlEcD75++1hCwrcAhyw+kB3M17nEMX1SMeGf KwpS5ie8BbHDytYMir0S/R8Z+jl6o7zsZ6m5gUSLUBUUGdJjmjw44hhPQ52Kulk/cjhcLw b3SnUBhP1mH18wEF0KfVb7WoZQDYTLZ8+6ZTnLZpXUKqeL1aPKVphu83yO27EQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F03CDD348 X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: OCnZ3dBS/Nwr Christopher Baines skribis: > Ludovic Court=C3=A8s writes: [...] >> Regarding , I would lean towards >> perhaps reverting the connection/error-handling patch series and >> starting anew from that =E2=80=9Cknown state=E2=80=9D. >> >> This area is unfortunately quite tedious to test and to get right so I= =E2=80=99d >> err on the path of conservative, incremental changes. >> >> Thought? > > My preference is still to try and move forward and to make the error > handling easier to see in the code. > > Particularly with this change, I think the problem was introduced in > this commit [1], but I think it's hard to tell from the diff, since the > error handling and retrying is within with-cached-connection. > > 1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Df50f5751fff4cf= c6d5abba9681054569694b7a5c > > That commit was one of the commits where I was making small incremental > changes prior to actually getting to the changes I was looking at > making, but a breakage was still introduced. > > What I was thinking about with this patch was how to make the error > handling being added back here easier to see, and thus harder to > break/remove. OK. Though I=E2=80=99m still unsure what the patch series starting at 7b812f7c84c43455cdd68a0e51b6ded018afcc8e was about. What was the end goal? I also wonder if it introduced other issues. For example, 7b812f7c84c43455cdd68a0e51b6ded018afcc8e replaced a reference to =E2=80=98open-connection-for-uri/cached=E2=80=99 by one to =E2=80=98open-connection-for-uri/maybe=E2=80=99. Are we still using cached= connections? Commit f50f5751fff4cfc6d5abba9681054569694b7a5c no longer passes the #:port parameter to =E2=80=98http-fetch=E2=80=99. Commit 20c08a8a45d0f137ead7c05e720456b2aea44402 does other things but at first sight I=E2=80=99m not sure what the effect is. If you=E2=80=99re confident we can move forward to fix the bug, that=E2=80= =99s great (though we=E2=80=99ll need a good deal of testing), but I=E2=80=99d still l= ike to clarify these points later on. Ludo=E2=80=99.