From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kDQEGRTtfGDXDQAAgWs5BA (envelope-from ) for ; Mon, 19 Apr 2021 04:38:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2OyoFBTtfGBZegAAbx9fmQ (envelope-from ) for ; Mon, 19 Apr 2021 02:38:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3A6729F47 for ; Mon, 19 Apr 2021 04:38:11 +0200 (CEST) Received: from localhost ([::1]:50318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYJnd-0003si-7B for larch@yhetil.org; Sun, 18 Apr 2021 22:38:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYJnW-0003rG-Hy for bug-guix@gnu.org; Sun, 18 Apr 2021 22:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYJnW-00034d-A6 for bug-guix@gnu.org; Sun, 18 Apr 2021 22:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYJnW-0003D9-6G for bug-guix@gnu.org; Sun, 18 Apr 2021 22:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47746: pypi importer generates wrong pypi-uri without underscore Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 19 Apr 2021 02:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47746 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Xinglu Chen Received: via spool by 47746-submit@debbugs.gnu.org id=B47746.161879986012314 (code B ref 47746); Mon, 19 Apr 2021 02:38:02 +0000 Received: (at 47746) by debbugs.gnu.org; 19 Apr 2021 02:37:40 +0000 Received: from localhost ([127.0.0.1]:48106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYJmv-0003CI-EL for submit@debbugs.gnu.org; Sun, 18 Apr 2021 22:37:40 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:42887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYJmt-0003C3-LA for 47746@debbugs.gnu.org; Sun, 18 Apr 2021 22:37:24 -0400 Received: by mail-qk1-f172.google.com with SMTP id d15so21515320qkc.9 for <47746@debbugs.gnu.org>; Sun, 18 Apr 2021 19:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=CJDHsED1Ksv6lPSMJWqsgqWTXHhaVcDRHMeOQBhdEJM=; b=e5reiqT5gp9qqNtcfn+dAWjno7IK9XnDo6JhQGSJaRsc4waGnCQ9YR/w955JsErLo8 oxaUiwllhZJmKPa5tFS1TVXKTmJX9khL8XM+IPbjqE//trMcFfmS+1cribfsmGtDKw0j Yc+0JGRvEbUYkeNfeZHICeQXWATOsP/Fc75Di29VaUaTiQ8OyIGOZqWVJVxKBVu9+sAb XNv0AVAwIrTjORnPEB3IErLkc1wlvM266WYNjJOshlLTIhhlLGmLpMscPGReW0fFsb80 xM2uG5K4lLurmi3+wRxF5c1gpSRSjwQM6nTYyISx6u3CYrSVR3XoIsCwuvTaY3dhM55w HNnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=CJDHsED1Ksv6lPSMJWqsgqWTXHhaVcDRHMeOQBhdEJM=; b=XRFum2R6/RIMGoOHmRtSHvoMosA2LmUbobC1E4SiXKU1FWf80bHYYfGMLo7jmOtQL5 ckEVb2HvQHPlGaOw/Qwbh/AaSzVFIPfVd9hKePqSmw3qjeWkekfi2aEfZYjkNDx98eIy C3p+NwTW8kxVaZSelF1g2SdahORy5L3SsIzRHOb/VjfJQjCsFWfV2fDKZagNXC8Jldl+ HBGBcBo1d+kVNCsReRnP8Z5iTkrwhGzeuwtINnQ9gnIAMMZMA0bcK9tmm7j56J+FgT32 /FzbT6K90WPw0SYzMoHiVWQr4cu7ciMG61umuzl6BDarxxQ/SX0pbDGTJlcO7gb81DKZ FR9A== X-Gm-Message-State: AOAM532Xd7sp4sjouiI0BUw6QKFsUDf6z3V+1c5vSoQay9LfnbbDEZVS d4zCdEfu+t5R4CvR5K1UU6aPDh5udIV9BQ== X-Google-Smtp-Source: ABdhPJyzC0n3wWppTicgDhd+9ma4dQXXVpcAxzqyHIXJU1Fk2qX4Kw4fvpQoRO5RyHfUM0h+Tgg3Ig== X-Received: by 2002:a05:620a:7d1:: with SMTP id 17mr9981573qkb.403.1618799837954; Sun, 18 Apr 2021 19:37:17 -0700 (PDT) Received: from hurd (dsl-152-210.b2b2c.ca. [66.158.152.210]) by smtp.gmail.com with ESMTPSA id a189sm8952392qkd.46.2021.04.18.19.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Apr 2021 19:37:17 -0700 (PDT) From: Maxim Cournoyer References: <87pmyytx8d.fsf@elephly.net> <87y2dmf20v.fsf@yoctocell.xyz> <87h7k9uanf.fsf@elephly.net> <871rbdhw6g.fsf@yoctocell.xyz> Date: Sun, 18 Apr 2021 22:37:16 -0400 In-Reply-To: <871rbdhw6g.fsf@yoctocell.xyz> (Xinglu Chen's message of "Wed, 14 Apr 2021 14:45:11 +0200") Message-ID: <87pmyrhueb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ricardo Wurmus , 47746@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618799891; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CJDHsED1Ksv6lPSMJWqsgqWTXHhaVcDRHMeOQBhdEJM=; b=QrtpbPDc2FT3wIOrkRQlkkL5xp4z+Jii1MDg7lYYL1NstfnPEIShvlerNUYADDQnxxKU/6 yxZzKkCuPqVLDqUrCuHWmFBQW+rl+ojkZDrx5ymIovaCDIwjRVymZb8Q1w1uzJDTiKLc7o UsfSkLKc+gd8fHHfI7kO5beAMt7CHqhDQqsimpr/zT2VgP5KEuXVrFVPEngWQ+SjLIRxSN QjDkov3KWD+TalJ3jBkLtVzWXnvhqBCs8138Nv5QgtWghiwdrz12SsQ/BRHMMPkc5n5h9H zUmYQQq6ZrvnoAJOTi5SLmDQgn4TRCThQe5UT/rOf2C/o3NIueasXfeSF6Ts9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618799891; a=rsa-sha256; cv=none; b=BCmID9C9DKhU+oDrCsjYf8kN1nFsy1JpEKg4DA75HTZ3MGtN5bCbQhSmv0W7qyynRrKQ1l lIwfoTslSxb7QnQ2UwVWLFubkpbX2ZdBdsIT35AO/oG7TE2bW0XmCX2dg16pbtnZBB3DAA Ph6wVMmvo2mWQuR7Kx2FzU53TUK99XHw/tD1JDpDiL1ueZqauPEJd+PgPb8de6c9puVpZ2 1mLXMk3mwAddExh06XNmPzzCpmdOH2eqpxqEhygU335w2pubb68Oz36fxDo/sAp6q3jlvL QWhnz2qKb/Ir3X1ctgqT0tiat2Vgvz34JqlGhdcPsMDj2Yi1ckIKgjethWJxwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=e5reiqT5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=e5reiqT5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: A3A6729F47 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: /f2X1tNIi9kF Hi, Xinglu Chen writes: > On Tue, Apr 13 2021, Ricardo Wurmus wrote: > >> You=E2=80=99re right, this only affects some packages. Here are two=20 >> examples: >> >> [...] >> >> They both have a redirection in common, but the pypi-uri is=20 >> incorrect as it needs to have the underscore. > > Looking at the JSON object at > , it specifies > =E2=80=9Cjupyterlabs-widgets=E2=80=9D as =E2=80=98info.downloads.name=E2= =80=99, which is what the PyPi > importer reads to determine the PyPi URI. > > Would it make sense to just make it read the name that the user > specifies in the shell, i.e. =E2=80=98./pre-inst-env guix import pypi > PACKAGE-NAME=E2=80=99 (see the patch below)? Or will this potentially me= ss up > other PyPi URIs? > >>>From ec5612e9d4c2026541874c6a3eaf7c9009ce4a31 Mon Sep 17 00:00:00 2001 > Message-Id: > From: Xinglu Chen > Date: Wed, 14 Apr 2021 14:37:01 +0200 > Subject: [PATCH] import: pypi: Use package name from the shell to constru= ct > the URI. > > Some packages will list an incorrect package name in the JSON object, > resulting in PyPi URIs that lead to nowhere. In my opinion, if a package contains wrong values in their metadata, it's a problem that should be reported to that package. As with other things, garbage in -> garbage out; Guix cannot do much here. I seem to recall that some older PyPI mirror had that problem. It may be that their metadata name -> URI is not consistent. We could try to find what that 2nd scheme is and attempt both, although that's not very elegant and it probably points to packages being very outdated to start with. Thanks, Maxim