From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 9SSoHvDiUmGMcQAAgWs5BA (envelope-from ) for ; Tue, 28 Sep 2021 11:40:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QB72GfDiUmFUcAAA1q6Kng (envelope-from ) for ; Tue, 28 Sep 2021 09:40:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0301CA08F for ; Tue, 28 Sep 2021 11:40:00 +0200 (CEST) Received: from localhost ([::1]:36742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mV9ah-0000ym-5r for larch@yhetil.org; Tue, 28 Sep 2021 05:39:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV9Zm-0008Iw-CP for guix-patches@gnu.org; Tue, 28 Sep 2021 05:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mV9Zm-0001K0-1P for guix-patches@gnu.org; Tue, 28 Sep 2021 05:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mV9Zl-0007CA-Uv for guix-patches@gnu.org; Tue, 28 Sep 2021 05:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50620] [PATCH 1/2] guix: packages: Document 'computed-origin-method'. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Sep 2021 09:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Liliana Marie Prikler , 50620@debbugs.gnu.org Received: via spool by 50620-submit@debbugs.gnu.org id=B50620.163282192827633 (code B ref 50620); Tue, 28 Sep 2021 09:39:01 +0000 Received: (at 50620) by debbugs.gnu.org; 28 Sep 2021 09:38:48 +0000 Received: from localhost ([127.0.0.1]:43876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV9ZY-0007Bd-2R for submit@debbugs.gnu.org; Tue, 28 Sep 2021 05:38:48 -0400 Received: from world.peace.net ([64.112.178.59]:49886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV9ZW-0007BO-A0 for 50620@debbugs.gnu.org; Tue, 28 Sep 2021 05:38:46 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mV9Z5-0000rW-Ib; Tue, 28 Sep 2021 05:38:19 -0400 From: Mark H Weaver In-Reply-To: References: <20210916114734.2686426-1-zimon.toutoune@gmail.com> <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> <87v930ay5y.fsf@netris.org> Date: Tue, 28 Sep 2021 05:36:48 -0400 Message-ID: <87pmstghx0.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632822000; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=WLGdfR+cF7mnRMS5mmVtORFa3GpG4LEYxc5kSj7R40Q=; b=fvN98Nt7Htgfdf1QE17k4qFhlLPIC/e7x+D4xX7NU+WnNrsjV1JyT9qxcRKXrOytexJrfy 81xxmOucN0HGoK8E2ubtx9d8gIY7s8GMyEdoD1aLQx4GY6mn6xOXfJFFkadpEhTkr45glm LFsNuiB23uCE37LfFjdvM+302OckRnbZHHY1VmRR5fuqysu5OHKiFbkZeCtNaIuLGzYnxd xsMyLCKRpJd7TD2pe9/BAN3zqHGAUxLdHNRn5O3873VbdMg0u2257rcboY2jg53q/3CGCr MlRG2oR9e2gqd25kleSqEe5PllgmXrp1zyJm5nzTFpfI7yxFxTuhsTAqLpvZdw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632822000; a=rsa-sha256; cv=none; b=Hg17MBjapxmzSNHyUOe9Q8IpVSjNaaAMCt+gXFVIYxV224Bmx1jP58KEHneAS12nkLRAFJ A3PYL4X7lL2mN/CobQ9MelAkQM5rgyrB9vCbayGrMMa0E8P+RNeDVC4dQYu8BRLeIt34LY aOqnLnxrskuj7uH99F7KwF4Nfh8GdIt76z/zBppsQyXgKeaE5/BsOjerGcq90AzfkwiBMb q1tcnGsMQHgQ0x7m5EymZOPNu+AjYUZEd22I4XSHWZx7CVsXH0RUPk3784z/FAEJBVePzx 9+FVPGsgXVgUuECb66ukJ2Q/IjeZnpHMv3NbOklRRRvO9DONw9CvgSz74HmTYg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.39 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0301CA08F X-Spam-Score: -2.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: EqSTGRVGuaaw Hi Simon, zimoun writes: > On Fri, 17 Sept 2021 at 01:40, Mark H Weaver wrote: >> Liliana Marie Prikler wrote: [...] >> > If done this way, there'd be the benefit that modules with packages >> > using this thing would have to explicitly request the presence of the >> > symbol through their use-modules clauses. >> >> Actually, for better or worse, Guile's '@@' form does not require the >> named module to be imported using 'use-modules', so I don't think this >> benefit strictly exists as stated above. However, I agree that it's >> good practice to list all imported modules in the '#:use-module' clauses >> at the top of the file wherever possible [*], and that there may be some >> benefit in declaring the use of 'computed-origins' at the top of each >> file. > > I am not deeply familiar with Guile module. > > I chose to put this in (guix packages) instead of its own module > because the module would contain only one function and nothing > exported. The aim for now, as discussed, is to not make this 'method' > part of the public API. > > Then if the function is not exported by the module, the '#:use-module' > does not have an effect, right? It's true that it would have no effect on the set of available bindings, and that's an excellent point. Perhaps Liliana could clarify what she had in mind, or better yet, propose a patch. Please don't let me be a blocker on this thread. I contributed a few thoughts, but I don't have time right now to shepherd this issue, sorry. Regards, Mark -- Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about .