From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uIP3Ekjao2EH4AAAgWs5BA (envelope-from ) for ; Sun, 28 Nov 2021 20:36:40 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6J+MDkjao2HLCwAAB5/wlQ (envelope-from ) for ; Sun, 28 Nov 2021 19:36:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF27B287CD for ; Sun, 28 Nov 2021 20:36:39 +0100 (CET) Received: from localhost ([::1]:41358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrPyZ-0007mY-2U for larch@yhetil.org; Sun, 28 Nov 2021 14:36:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrPxy-0007mM-GH for guix-patches@gnu.org; Sun, 28 Nov 2021 14:36:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrPxy-00043t-7z for guix-patches@gnu.org; Sun, 28 Nov 2021 14:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrPxy-00024p-3T for guix-patches@gnu.org; Sun, 28 Nov 2021 14:36:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Nov 2021 19:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jelle Licht Cc: 51838@debbugs.gnu.org, Philip McGrath , Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.16381281267939 (code B ref 51838); Sun, 28 Nov 2021 19:36:02 +0000 Received: (at 51838) by debbugs.gnu.org; 28 Nov 2021 19:35:26 +0000 Received: from localhost ([127.0.0.1]:36379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrPxO-00023z-E5 for submit@debbugs.gnu.org; Sun, 28 Nov 2021 14:35:26 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrPxN-00023m-At for 51838@debbugs.gnu.org; Sun, 28 Nov 2021 14:35:25 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D12345C003B; Sun, 28 Nov 2021 14:35:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 28 Nov 2021 14:35:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=qBg2r6P6LM409FwY+KLvxrRWFYNRixQf8GIJX024n OQ=; b=KUff2xpcSp9lQsuk6ods83y3lJ2zDyNjTI9zpiww4rxGBW9d5/uqrxgUC bEmHtZkzVxdk3hAtDjtJVGDXIFiG84Bja5S5/E8c5BiP0vEbM0Cii6+vPbT8RDmJ M/HzPhDMxd2X/ca6DA10Zs8yHw9QYNiIucOaVkI5cSWUk+6heqhRaCIxf0SP57Fj zuK8ZpKiPKFAbHvpqbpVdhGFBZwj+BATxDz3KfnBre1rBTNxginjioPxZFKgn7DO 3sQVt6fEeITz8tCSeqyBsAnVDltmgJgJ9GXF7nnMIYFwQSRtLyYuRE9ejOXRJgcw 7pAeErWHqQTROdjYM4dLJaF6ST2dw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrheeigdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhho thhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrf grthhtvghrnhepieduuefhgeegleelveehgedugfeuhfeikefftdevieelgfelhfdvtdfg ieehtefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgrmhhplhgvthesnhhghihrohdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Nov 2021 14:35:19 -0500 (EST) From: Timothy Sample References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <20211120043406.952350-1-philip@philipmcgrath.com> <20211120043406.952350-10-philip@philipmcgrath.com> <86tug39lps.fsf@fsfe.org> Date: Sun, 28 Nov 2021 14:35:18 -0500 In-Reply-To: <86tug39lps.fsf@fsfe.org> (Jelle Licht's message of "Tue, 23 Nov 2021 12:04:47 +0100") Message-ID: <87pmqkm5u1.fsf_-_@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638128200; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qBg2r6P6LM409FwY+KLvxrRWFYNRixQf8GIJX024nOQ=; b=lcmR0tH95yGGtpviwTa8HaBJeyTJWqyGUfyS0Rjc4LhszMMP2OTv0fAuUGoCzH4bisvOnV kv9Y488avu47I5lod3ZpsHC0D6SDajivfkaP0EV+pES7gWtwhHpvs0KXGahl+3yBY+snTB L0vEEmHIf6SPClkCm2XEgsy4chwWG/FTagej5jb4fr4hkysjJGQlRQqjH8j2+7KUQZWqYU BoE0v+hBriefvpEfRvrDIbWhU2Kzy0zNyoQlmEZTcAzFB1vl53PwbPVwPw8or+CRrONmjY yykxL2ryGzm2ula1mzxAtT31VdeDQFfpO84WWd5AYemDwL8LV6HrNeErU6Pivg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638128200; a=rsa-sha256; cv=none; b=knRDlTYsVcloVqsEwzlQqcTCnThlwZN+LAXlUf6TJOiGub2my43zShFGKdR30hYN5aacqT yJaRVfQg7LiejDObC/0OeJ9nkhsPtj8shzT5W0N3IskDc1FOPd3iIaNkp5R/HyqQPoy7Rv mq7CBjGQbyBLHzsbxjcigCmIWi9ffxAQj84MusNwcX3GCIHuJZM3ojtlalkj24tM/jJ+T4 YRubKlH5VPQ5LT3Vg+PcrIztvnckDsEF3IvV0eSrW3HNkjJ3UPYM0mGNlCdFVAEsStd/SR AKTJeePjv/l0LqIEnKMy5U88VxvNr9rXkPSVU1xdTvoY6n9OSfynimTC8/1Uqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=KUff2xpc; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=KUff2xpc; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EF27B287CD X-Spam-Score: -0.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: xUrxQ9UwW9uk Hello! Jelle Licht writes: > Philip McGrath writes: > >> Add a new phase `#:delete-package-lock` to remove the >> problematic "package-lock.json". > > package-lock.json lists exact versions _and integrity hashes_; since it > seems unlikely that after node-build-system's finaggling we end up with > an identical hash, we will always have a mismatch and fetch 'proper' > sources online accordingly. As far as npm + package-lock.json are > concerned, we don't have them properly installed. > > From what I have seen package-lock.json offers us no benefits (because > we track exact dependency information via the guix store) and can (as > you have seen) prevent builds from working. My 2c: always remove it in a > phase in the build system. I=E2=80=99m inclined to agree with Jelle and Liliana. I can=E2=80=99t imag= ine a situation in which we would want the lock files. We could be wrong, but we can always adjust the build system later if something surprising happens (e.g., =E2=80=98#:keep-lock-file?=E2=80=99 or whatever). -- Tim