From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ONxpIihls2GfAwAAgWs5BA (envelope-from ) for ; Fri, 10 Dec 2021 15:33:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AMs5Hihls2E/FQAA1q6Kng (envelope-from ) for ; Fri, 10 Dec 2021 14:33:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 485803659F for ; Fri, 10 Dec 2021 15:33:12 +0100 (CET) Received: from localhost ([::1]:57622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvgxS-0004jU-NM for larch@yhetil.org; Fri, 10 Dec 2021 09:33:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvgxM-0004ir-Jp for guix-patches@gnu.org; Fri, 10 Dec 2021 09:33:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvgxK-0002Ih-HB for guix-patches@gnu.org; Fri, 10 Dec 2021 09:33:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mvgxK-0001BI-D1 for guix-patches@gnu.org; Fri, 10 Dec 2021 09:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52043] [PATCH 1/2] gnu: Add instrumentation packages. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Dec 2021 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52043 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Olivier Dion Cc: 52043@debbugs.gnu.org Received: via spool by 52043-submit@debbugs.gnu.org id=B52043.16391467594506 (code B ref 52043); Fri, 10 Dec 2021 14:33:02 +0000 Received: (at 52043) by debbugs.gnu.org; 10 Dec 2021 14:32:39 +0000 Received: from localhost ([127.0.0.1]:46026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvgwx-0001Ac-Il for submit@debbugs.gnu.org; Fri, 10 Dec 2021 09:32:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvgwu-0001AM-HV for 52043@debbugs.gnu.org; Fri, 10 Dec 2021 09:32:39 -0500 Received: from [2001:470:142:3::e] (port=54160 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvgwp-0002Cl-8p; Fri, 10 Dec 2021 09:32:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ywPMo6P48zDdcX9CkqqXCyYSWyalalNhyWzxNu2II1I=; b=AOV0P4kNReE9u5hYCfaZ du9mnKvIbYdpywNpcd/ZyTIljYn3Wl2DjKmVO4SMvLXRlwDgXRkwLpl3r3OyG5pCONAzp2nj/DlMK wrQOuB9+UvoZq0Hb/iC4KqCdAO44ZFRGAfoM45x0BNVyWNZmZzB5EUWKi3m4Xv3h8NA0JjXa2r8ww 202qR/p8IWnAYtJ4s2lWxX6wTw+6E1hQHU+a7dsT4G+OwkI15bWAk+E/kT1ASNWLNs7459EfU1M+n ZpMeLDaTGX6J5jwZjfVCUyY52lTpqDsD/t967tFdOC0vZBWv2mXrzcS0j0XJtzfQ8zn5IYIMemmgd FsJTqEI5g1N3Wg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:62969 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvgwp-0006da-6H; Fri, 10 Dec 2021 09:32:31 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <60c77ab6e2f5f098b1ecdc9c50c602072dbc2f68.1637608343.git.olivier.dion@polymtl.ca> <1bbfcda6f8e1c1fd94170b9af7186076d4f5bc3c.1637632353.git.olivier.dion@polymtl.ca> Date: Fri, 10 Dec 2021 15:32:29 +0100 In-Reply-To: <1bbfcda6f8e1c1fd94170b9af7186076d4f5bc3c.1637632353.git.olivier.dion@polymtl.ca> (Olivier Dion's message of "Mon, 22 Nov 2021 20:53:23 -0500") Message-ID: <87pmq47coy.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639146792; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ywPMo6P48zDdcX9CkqqXCyYSWyalalNhyWzxNu2II1I=; b=G8Tt8ZfSSP5OX1p4Qn94cUaJR0ovRDr/ZtfHn1h0wT7Ey/ttcLPlGo244VqXdjTbBkBX1C 1OttSjphR7/C7Gdsj+C9mYbyUVUsxB/MIzUObp3jYQo/dzHNi1MXVxPTwmaqy6zwUYD+rq gzuRaPnP8t3xEKuWfP7oFOC6AOQI5eNK0kYGmAlKyYumMTN+IrbcF6p3+kwnzIDRv+MaCL Y1AiQ5+JyFdNxObQh4hZHfNmuCv+bQFYOJJewhEGBVauq1FoeOBIUlSxEKk/DLSXGaA+Q/ 92rZkoTB1jwRgegzwlTbBFAGcHQBsTsFZAWeRe1Cd9kkyozk9XL3rM6ZAzWxXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639146792; a=rsa-sha256; cv=none; b=khRKoG82E/3lOUP03Jej4eWrdm5cYoZCfzeTJLg9B+Tb179Rjc67Jl0KgQDA85TGwIOC7W fThyrd2+hpLsMBK4o/C5DcROLswUdjDMGlGERDJNPe6ZJ3V1K72Grjd4vhB54R5928EdBM KKsWDhQW0Ny8I3+nUb864awiDnE3tpjqe8yQIQP4Pj17gDr+JM14KEambq6WDgV3Ybgj5C 1xk7y5I0CYHc+E9Z5wOR/OTxrmYYidEDpfK2ezKMOYycKQLiWhhV2ngpuQAQWnTSrblRv5 E77KQJQ2bXfJVgq50uHye8Pc2J+J+dfbiFDkzXInfs8Jqz46CUn0DrkA9y/Fnw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=AOV0P4kN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=AOV0P4kN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 485803659F X-Spam-Score: -3.66 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4QcNhH97wZma Hi, Olivier Dion skribis: > * gnu/packages/instrumentation.scm: New file > (dyninst): New variable. [...] > + (name "dyninst") > + ;; Newer versions are not promoted on main home page and require lib= iberty. Note that there=E2=80=99s a =E2=80=98libiberty=E2=80=99 package. > + (version "10.2.1") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/dyninst/dyninst/ar= chive/v" > + version ".tar.gz")) As reported by =E2=80=98guix lint=E2=80=99, this URL refers to an autogener= ated tarball whose content may change over time. Could you instead use =E2=80=98git-fetch=E2=80=99? > + (synopsis "Dynamic instrumentation") > + (description "Tools for binary instrumentation, analysis, and modifi= cation.") Please expound a bit and write full sentences: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html Otherwise LGTM. Could you send an updated patch? The second patch LGTM. Thanks, Ludo=E2=80=99.