all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Olivier Dion <olivier.dion@polymtl.ca>
Cc: 52043@debbugs.gnu.org
Subject: [bug#52043] [PATCH 1/2] gnu: Add instrumentation packages.
Date: Fri, 10 Dec 2021 15:32:29 +0100	[thread overview]
Message-ID: <87pmq47coy.fsf_-_@gnu.org> (raw)
In-Reply-To: <1bbfcda6f8e1c1fd94170b9af7186076d4f5bc3c.1637632353.git.olivier.dion@polymtl.ca> (Olivier Dion's message of "Mon, 22 Nov 2021 20:53:23 -0500")

Hi,

Olivier Dion <olivier.dion@polymtl.ca> skribis:

> * gnu/packages/instrumentation.scm: New file
> (dyninst): New variable.

[...]

> +    (name "dyninst")
> +    ;; Newer versions are not promoted on main home page and require libiberty.

Note that there’s a ‘libiberty’ package.

> +    (version "10.2.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/dyninst/dyninst/archive/v"
> +                                  version ".tar.gz"))

As reported by ‘guix lint’, this URL refers to an autogenerated
tarball whose content may change over time.

Could you instead use ‘git-fetch’?

> +    (synopsis "Dynamic instrumentation")
> +    (description "Tools for binary instrumentation, analysis, and modification.")

Please expound a bit and write full sentences:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Otherwise LGTM.  Could you send an updated patch?

The second patch LGTM.

Thanks,
Ludo’.




  reply	other threads:[~2021-12-10 14:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 19:13 [bug#52043] [PATCH 1/2] gnu: Add instrumentation packages Olivier Dion via Guix-patches via
2021-11-22 19:16 ` [bug#52043] [PATCH 2/2] gnu: Move instrumentation tools to instrumentation module Olivier Dion via Guix-patches via
2021-11-23  1:53 ` [bug#52043] [PATCH v2 1/2] gnu: Add instrumentation packages Olivier Dion via Guix-patches via
2021-12-10 14:32   ` Ludovic Courtès [this message]
2021-12-12 19:59 ` [bug#52043] [PATCH v3 " Olivier Dion via Guix-patches via
2021-12-12 19:59   ` [bug#52043] [PATCH v3 2/2] gnu: Move instrumentation tools to instrumentation module Olivier Dion via Guix-patches via
2021-12-16 18:40 ` [bug#52043] [PATCH v4 0/2] Create instrumentation package Olivier Dion via Guix-patches via
2021-12-16 18:40   ` [bug#52043] [PATCH v4 1/2] gnu: Add instrumentation packages Olivier Dion via Guix-patches via
2021-12-18 18:47     ` [bug#52043] [PATCH " Ludovic Courtès
2021-12-16 18:40   ` [bug#52043] [PATCH v4 2/2] gnu: Move instrumentation tools to instrumentation module Olivier Dion via Guix-patches via
2021-12-18 18:47     ` bug#52043: [PATCH 1/2] gnu: Add instrumentation packages Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmq47coy.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=52043@debbugs.gnu.org \
    --cc=olivier.dion@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.