From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oOQ4EGXqx2JdZQAAbAwnHQ (envelope-from ) for ; Fri, 08 Jul 2022 10:27:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MKlED2Xqx2L+xAAAG6o9tA (envelope-from ) for ; Fri, 08 Jul 2022 10:27:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8F3516215 for ; Fri, 8 Jul 2022 10:27:16 +0200 (CEST) Received: from localhost ([::1]:47194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9jKV-00058g-RT for larch@yhetil.org; Fri, 08 Jul 2022 04:27:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9jKI-00058X-3I for bug-guix@gnu.org; Fri, 08 Jul 2022 04:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9jKH-0006rB-N1 for bug-guix@gnu.org; Fri, 08 Jul 2022 04:27:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9jKH-0007z3-Ju for bug-guix@gnu.org; Fri, 08 Jul 2022 04:27:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56398: (guix git) fails to check out repos with nested submodules Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 08 Jul 2022 08:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56398 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: =?UTF-8?Q?Andr=C3=A9?= Batista Cc: 56398@debbugs.gnu.org Received: via spool by 56398-submit@debbugs.gnu.org id=B56398.165726881130652 (code B ref 56398); Fri, 08 Jul 2022 08:27:01 +0000 Received: (at 56398) by debbugs.gnu.org; 8 Jul 2022 08:26:51 +0000 Received: from localhost ([127.0.0.1]:58668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9jK7-0007yJ-2E for submit@debbugs.gnu.org; Fri, 08 Jul 2022 04:26:51 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:23566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9jK3-0007xs-Ma for 56398@debbugs.gnu.org; Fri, 08 Jul 2022 04:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=SU3XiAmgD9kDCvdAZilX9UP3UwmhxAaP4P2lRkTHprE=; b=He9O7DmUlrjG+EDEoM6H+kga0rsKD54uiA14TjrTFaQkgB0jylIl+WIa ob3BwYsl03YaB4hzV56Qpm4qIV4KuVjaQvh2uB7Kbyw6H0VUNSXNv2089 ohRIe77p55kr/X+yLizltQ2l02jaEnK0I6IG0/CoPPl7vkJFkiOJjtOoj I=; X-IronPort-AV: E=Sophos;i="5.92,255,1650924000"; d="scan'208";a="18871355" Received: from unknown (HELO ribbon) ([193.50.110.235]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 10:26:42 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sfnf4n7c.fsf@inria.fr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?UTF-8?Q?D=C3=A9cadi?= 20 Messidor an 230 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Parc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 08 Jul 2022 10:26:40 +0200 In-Reply-To: ("=?UTF-8?Q?Andr=C3=A9?= Batista"'s message of "Thu, 7 Jul 2022 18:35:42 -0300") Message-ID: <87pmigxb5r.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657268837; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SU3XiAmgD9kDCvdAZilX9UP3UwmhxAaP4P2lRkTHprE=; b=OfrojrvZGQYlmJFmwARN8vG+06Yme2R2yqRoeK0deOiG+pL6NqqIvNirs2ZC4zxGEdfL/q fd7/UfN747ZhTKeS9s4yc9Oj4UVpPGqk38bnSY5ZfFALFzrmv5n/APHPtgZVd8cfwsswT5 9pydJ4ZHiBYxbpImW3UKFOVeAapDm5Z8dPOX2OkvfahDKRB4Utf0oAswcc9c6ZUbaOp3w2 Kc40+91gcAGhrX9XUkC3WpUq9md7zLdB3LlOOwjeip+riknnudGZ13PRN/XGmHYN5rUEXe bYz3OElumSmZt+h5kjKgfm8thQRGMVq5ghGrwCZT8+wIN0yDootjIXe3x8yObA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657268837; a=rsa-sha256; cv=none; b=D0naUj3lRyYCZrrmuEDUG53JYIdAMEoryW4QKByx6T6KnarDf/YRq7CEVpzmlTVb7ObTBA a/wts/nRYKBLLQOweX9dTAfmcqSyoIiiYKxp3rskbDCFl2/vlhr8RprrFfEPE8OCuGE2iO 9ewXFHaxnyFRtCWn1r7a1+ETt9+Kbpk/p1Aq/ABcz4DbDRnA51QLPzsoLefYlF+BhCmeG6 CYsSeVIjh9nQy6ywz0NAeRfAv+/eVCRW+UUnbE6l+1O4aXAlCFdDMOJXapEET2ai8dFy7M WwPbk8CCHNYv2alETcsS8vLu1306iyOyiCsXRHPMVV0AtDD/SGhH36XTqMfs8g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=He9O7DmU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=He9O7DmU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A8F3516215 X-Spam-Score: 5.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: xrTBS+e2sbU+ Hi! Andr=C3=A9 Batista skribis: > Hi! > > ter 05 jul 2022 =C3=A0s 17:02:31 (1657051351), ludovic.courtes@inria.fr e= nviou: >> It seems that =E2=80=98update-cached-checkout=E2=80=99 fails to handle n= ested Git >> submodules, when a submodule itself has submodules: > > I think this may be actually a bug upstream. When refreshing, guix is > able to recursively upgrade submodules under 'thirdparty/fbgemm' just > fine, but it fails on thirdparty/gloo because the path declared on > its .gitmodules does not exist on the repository: Oh indeed. The bug probably doesn=E2=80=99t have to do with nested submodu= les; it manifests when checking out that gloo repo: --8<---------------cut here---------------start------------->8--- scheme@(guix git)> (update-cached-checkout "https://github.com/facebookincu= bator/gloo" #:recursive? #t) ice-9/boot-9.scm:1685:16: In procedure raise-exception: Git error: failed to resolve path '/home/ludo/.cache/guix/checkouts/4pe5bqk= msmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/third-party/googletest/.git':= No such file or directory Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue. --8<---------------cut here---------------end--------------->8--- If we do this: --8<---------------cut here---------------start------------->8--- scheme@(guix git)> (define r (repository-open "/home/ludo/.cache/guix/check= outs/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/")) scheme@(guix git)> (define mod (submodule-lookup r "third-party/googletest"= )) scheme@(guix git)> mod $13 =3D # scheme@(guix git)> (submodule-update $13) ice-9/boot-9.scm:1685:16: In procedure raise-exception: Git error: failed to resolve path '/home/ludo/.cache/guix/checkouts/4pe5bqk= msmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/third-party/googletest/.git':= No such file or directory Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue. --8<---------------cut here---------------end--------------->8--- =E2=80=A6 the =E2=80=98submodule-update=E2=80=99 bit looks like this: --8<---------------cut here---------------start------------->8--- newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.gitmodules", {st_mode=3DS_IFREG|0644, st_= size=3D116, ...}, 0) =3D 0 access("/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2d= ciznz7shwawckb32sq/.gitmodules", F_OK) =3D 0 access("/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2d= ciznz7shwawckb32sq/.gitmodules", R_OK) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.gitmodules", {st_mode=3DS_IFREG|0644, st_= size=3D116, ...}, 0) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.gitmodules", {st_mode=3DS_IFREG|0644, st_= size=3D116, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.gitmodules", O_RDONLY|O_CLOEXEC) =3D 15 read(15, "[submodule \"third-party/googletest\"]\n\tpath =3D third-party/go= ogletest\n\turl =3D https://github.com/google/googletest.git\n", 116) =3D 1= 16 close(15) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.gitmodules", {st_mode=3DS_IFREG|0644, st_= size=3D116, ...}, 0) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/third-party/googletest", 0x7ffdd31497f0, 0= ) =3D -1 ENOENT (No such file or directory) access("/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2d= ciznz7shwawckb32sq/third-party/googletest/.git", F_OK) =3D -1 ENOENT (No su= ch file or directory) newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.git/HEAD", {st_mode=3DS_IFREG|0644, st_si= ze=3D21, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.git/HEAD", O_RDONLY|O_CLOEXEC) =3D 15 read(15, "ref: refs/heads/main\n", 21) =3D 21 close(15) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.git/refs/heads/main", {st_mode=3DS_IFREG|= 0644, st_size=3D41, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.git/refs/heads/main", O_RDONLY|O_CLOEXEC) =3D= 15 read(15, "950c0e23819779a9e0c70b861db4c52b31d1d1b2\n", 41) =3D 41 close(15) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.git/HEAD", {st_mode=3DS_IFREG|0644, st_si= ze=3D21, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.git/HEAD", O_RDONLY|O_CLOEXEC) =3D 15 read(15, "ref: refs/heads/main\n", 21) =3D 21 close(15) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.git/refs/heads/main", {st_mode=3DS_IFREG|= 0644, st_size=3D41, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.git/refs/heads/main", O_RDONLY|O_CLOEXEC) =3D= 15 read(15, "950c0e23819779a9e0c70b861db4c52b31d1d1b2\n", 41) =3D 41 close(15) =3D 0 --8<---------------cut here---------------end--------------->8--- Thus, looking at =E2=80=98git_submodule_update=E2=80=99 in libgit2, it look= s as if this condition was true: (submodule_status & GIT_SUBMODULE_STATUS_WD_UNINITIALIZED) Hmm, thoughts? Ludo=E2=80=99.