From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OMJ6Esn8zWIHKwEAbAwnHQ (envelope-from ) for ; Wed, 13 Jul 2022 00:59:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IEKWEcn8zWJYDgEAG6o9tA (envelope-from ) for ; Wed, 13 Jul 2022 00:59:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B53A433D6B for ; Wed, 13 Jul 2022 00:59:20 +0200 (CEST) Received: from localhost ([::1]:54672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBOqd-0006LM-N5 for larch@yhetil.org; Tue, 12 Jul 2022 18:59:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBOqN-0006Jv-4P for guix-patches@gnu.org; Tue, 12 Jul 2022 18:59:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBOqL-0000ns-S7 for guix-patches@gnu.org; Tue, 12 Jul 2022 18:59:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oBOqL-0003gl-Rt for guix-patches@gnu.org; Tue, 12 Jul 2022 18:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56428] [PATCH] home: Add -I, --list-installed option. Resent-From: Antero Mejr Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Jul 2022 22:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56428 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 56428@debbugs.gnu.org Received: via spool by 56428-submit@debbugs.gnu.org id=B56428.165766668814116 (code B ref 56428); Tue, 12 Jul 2022 22:59:01 +0000 Received: (at 56428) by debbugs.gnu.org; 12 Jul 2022 22:58:08 +0000 Received: from localhost ([127.0.0.1]:43867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBOpU-0003fb-H5 for submit@debbugs.gnu.org; Tue, 12 Jul 2022 18:58:08 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:51128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBOpS-0003ef-Df for 56428@debbugs.gnu.org; Tue, 12 Jul 2022 18:58:07 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4LjGPL1kgDz9sSH; Wed, 13 Jul 2022 00:57:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1657666678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P1mq4q8RH4cbrNGy6zoo7cGGXyTbv8mz6qSI6SPZUKw=; b=VyYHhhMM9ohtdakwN8Xr8VyKlo3d9d1gWozc50w8aFdusAsm5b5fsQfL1oxEfNrZ7CMy3A Npxjvz2nINT91Py0WXJNAEpX+0t/huySoDmANbYpplioaN0fGpUOnQkO2ftmRq4W9k4S/f EF5dZBLYXTjsWyO7QtsAVxT0w4HZU4qT4YvEfh4P0KmXhG/vYUmNbV9s+ewJqviHUPN2dc ySxtiePyq937hn4MEzLTQncoxVDHLAzGR4otWAyIbbt8wQIdCxpxz8US4aRAdyvmp63Xqg zwYLR5nlYOc86AQuBvIKpw5UCwWXI+KWj32W03lxqiHcwj8CwDBgvxn5UIiCAg== References: <20220706191311.14662-1-antero@mailbox.org> <20220707150644.2349-1-antero@mailbox.org> <87o7xu1vve.fsf@trop.in> Date: Tue, 12 Jul 2022 22:50:19 +0000 In-reply-to: <87o7xu1vve.fsf@trop.in> Message-ID: <87pmiaj5vx.fsf@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain X-MBO-RS-ID: 71a3fa83636b0f9423e X-MBO-RS-META: 7z7zpaqaoh7ghizd5cpjsdk9gyqjksn3 X-Rspamd-Queue-Id: 4LjGPL1kgDz9sSH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Antero Mejr X-ACL-Warn: , Antero Mejr via Guix-patches From: Antero Mejr via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657666760; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=P1mq4q8RH4cbrNGy6zoo7cGGXyTbv8mz6qSI6SPZUKw=; b=eBSgtzTPTyJln3WexZX9HgqxLi+v5lQjVzCzt+AmL65/Y3blbvAOuwpMwK6D30l3K/vdsj wbyZWxCcyiHzUbQYirr9jdmrxyy1qtC5BlW4A5J8+aMPgwWOzQOeahy8DxWPpvOw5Ve+Zl Pwi4+EkEzfOKlsozTHn1cBEcT0kKizIPc5k9Lmh3IZFqdpYVOkdLsuAKyuEEQDP/xLyWQ1 vNDetLXamFV6nfjcSSEJzRXQW7SzmXGTD85yDLZeOubhLee4MATAABmOMjZravhvQrqjYl VjNN0ebl2DkiPL1c7UAHxZGclgmwLsxtRGBMUq2cH1bfgjGpncYceCBjWMe0Vg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657666760; a=rsa-sha256; cv=none; b=gEWtOnZ5CEi4aoXrwa9ir0mjRRdZZLuBiRnJc9VxQJsWqw32u3KY8dBhAbFdkCOS8vSpSI OVYK2/4AqMlfv2BfeXLMHeQE6hzuUQFPFYtLJKYrFfjV6fqHxXpEjBbPmkdNCbBzwSlAu0 TSsbPbF190OWNJQMkRLpZXpjC79V7zpPC5BVggr5NCAwbf9529vOvvZdq9WuHhMX4f+ATI dnoFOjVKizAox4+DTumq8miOpq6pPuypa4tcTGUdJHelcwbWSOt72F9gsSUBQmpscDzEq3 B145aLiJH2324WljITeKiPeH/9Uea3nwiGsa2T7TEGC6NNvqqlNsMx/J9MYJAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mailbox.org header.s=mail20150812 header.b=VyYHhhMM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mailbox.org header.s=mail20150812 header.b=VyYHhhMM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B53A433D6B X-Spam-Score: -3.65 X-Migadu-Scanner: scn1.migadu.com X-TUID: sxGvfKYfvgGf Andrew Tropin writes: > Implementing this functionality as --argument makes it possible to type > `guix home reconfigure ./he.scm --list-installed`, which again doesn't > make much sense as in the example above. I advice either implement > list-installed as a separate action or as an additional --argument to > describe/list-generations action. I added it to both guix home describe and list-generations. Adding it to describe seems most intuitive to me, and adding it to list-generations is useful for tracking when a package was added to the profile. If --list-installed is specified for an invalid subcommand, the flag is ignored. Same behavior as when using --network with a guix home describe, for example. > 2. Would be good to mention it in doc/guix.texi. Done. > 3. It would be nice to implement the same for guix system. I will do that in another patch/issue. > To make it consistent with the rest of the module, I think it will > better to use define and explicitly export list-installed in module > definition at the top of the file. Done. Thanks for the review, and also thanks for guix home!