From: Antero Mejr via Guix-patches via <guix-patches@gnu.org>
To: Andrew Tropin <andrew@trop.in>
Cc: 56428@debbugs.gnu.org
Subject: [bug#56428] [PATCH] home: Add -I, --list-installed option.
Date: Tue, 12 Jul 2022 22:50:19 +0000 [thread overview]
Message-ID: <87pmiaj5vx.fsf@mailbox.org> (raw)
In-Reply-To: <87o7xu1vve.fsf@trop.in>
Andrew Tropin <andrew@trop.in> writes:
> Implementing this functionality as --argument makes it possible to type
> `guix home reconfigure ./he.scm --list-installed`, which again doesn't
> make much sense as in the example above. I advice either implement
> list-installed as a separate action or as an additional --argument to
> describe/list-generations action.
I added it to both guix home describe and list-generations. Adding it to
describe seems most intuitive to me, and adding it to list-generations
is useful for tracking when a package was added to the profile.
If --list-installed is specified for an invalid subcommand, the flag is
ignored.
Same behavior as when using --network with a guix home describe, for
example.
> 2. Would be good to mention it in doc/guix.texi.
Done.
> 3. It would be nice to implement the same for guix system.
I will do that in another patch/issue.
> To make it consistent with the rest of the module, I think it will
> better to use define and explicitly export list-installed in module
> definition at the top of the file.
Done.
Thanks for the review, and also thanks for guix home!
next prev parent reply other threads:[~2022-07-12 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 19:13 [bug#56428] [PATCH] home: Add -I, --list-installed option Antero Mejr via Guix-patches via
2022-07-07 15:06 ` Antero Mejr via Guix-patches via
2022-07-12 10:13 ` Andrew Tropin
2022-07-12 22:50 ` Antero Mejr via Guix-patches via [this message]
2022-07-12 22:50 ` [bug#56428] [PATCH v3] " Antero Mejr via Guix-patches via
2022-07-14 9:21 ` Andrew Tropin
2022-07-18 13:21 ` bug#56428: [PATCH] " Ludovic Courtès
2022-08-05 6:12 ` [bug#56428] " Andrew Tropin
2022-08-06 23:02 ` Antero Mejr via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmiaj5vx.fsf@mailbox.org \
--to=guix-patches@gnu.org \
--cc=56428@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=antero@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.