From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 56867@debbugs.gnu.org, guile-devel@gnu.org
Subject: [bug#56867] [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7.
Date: Tue, 02 Aug 2022 09:59:22 +0200 [thread overview]
Message-ID: <87pmhjuld1.fsf@gnu.org> (raw)
In-Reply-To: <da075774-a438-71b9-a4aa-3520a0070621@telenet.be> (Maxime Devos's message of "Mon, 1 Aug 2022 11:56:00 +0200")
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> On 01-08-2022 11:07, Ludovic Courtès wrote:
[...]
>> + (define (read! bv start count)
>> + (define read
>> + (catch 'gnutls-error
>> + (lambda ()
>> + (get-bytevector-n! record bv start count))
>> + (lambda (key err proc . rest)
>> + ;; When responding to "Connection: close" requests, some servers
>> + ;; close the connection abruptly after sending the response body,
>> + ;; without doing a proper TLS connection termination. Treat it as
>> + ;; EOF. This is fixed in GnuTLS 3.7.7.
>> + (if (eq? err error/premature-termination)
>> + the-eof-object
>> + (apply throw key err proc rest)))))
>
> Objection: 'catch' makes the backtrace part happening inside the
> 'get-bytevector-n!' disappear, because it is unwinding, as has been
> noted a few times (in different contexts) by Attila Lendvai and me.
> Maybe use 'guard' with an appropriate condition instead?
This code was already there and has just been moved around. (It’s also
code that will no longer be used going forward.)
>> + (if (module-defined? (resolve-interface '(gnutls))
>> + 'set-session-record-port-close!) ;GnuTLS >= 3.7.7
>
> resolve-module (and presumably also sets #:ensure #t by default, which
> sometimes causes 'module not found' messages to be replaced by
> 'unbound variable', which I don't think is useful behaviour, can
> #:ensure be set to #false?
This is unnecessary: see the ‘load-gnutls’ mechanism there. The idiom
above is already used in a couple of places.
Thanks for your feedback!
Ludo’.
next prev parent reply other threads:[~2022-08-02 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 9:07 [bug#56867] [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7 Ludovic Courtès
2022-08-01 9:15 ` Ludovic Courtès
2022-08-01 9:56 ` Maxime Devos
2022-08-02 7:59 ` Ludovic Courtès [this message]
2022-08-04 19:37 ` Maxime Devos
2022-08-05 8:31 ` Ludovic Courtès
2022-08-05 10:17 ` Maxime Devos
2022-08-03 15:57 ` bug#56867: " Ludovic Courtès
2022-08-04 14:20 ` [bug#56867] " Ludovic Courtès
2022-08-04 14:46 ` bug#56005: " Thiago Jung Bauermann via Bug reports for GNU Guix
2022-08-04 16:19 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmhjuld1.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=56867@debbugs.gnu.org \
--cc=guile-devel@gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.