From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KApGN/deRWMr7AAAbAwnHQ (envelope-from ) for ; Tue, 11 Oct 2022 14:18:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UKs3NvdeRWNovQAAG6o9tA (envelope-from ) for ; Tue, 11 Oct 2022 14:17:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D0953BA05 for ; Tue, 11 Oct 2022 14:17:59 +0200 (CEST) Received: from localhost ([::1]:36184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiECr-0007xY-HZ for larch@yhetil.org; Tue, 11 Oct 2022 08:17:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiCql-0004Au-HN for guix-patches@gnu.org; Tue, 11 Oct 2022 06:51:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiCql-00019f-2J for guix-patches@gnu.org; Tue, 11 Oct 2022 06:51:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oiCqk-0004sf-Tn for guix-patches@gnu.org; Tue, 11 Oct 2022 06:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58381] [PATCH 1/3] gnu: Add go-github-com-go-piv-piv-go. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Oct 2022 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58381 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Graves Cc: 58381@debbugs.gnu.org X-Debbugs-Original-Cc: 58381@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 58381-submit@debbugs.gnu.org id=B58381.166548540318646 (code B ref 58381); Tue, 11 Oct 2022 10:51:02 +0000 Received: (at 58381) by debbugs.gnu.org; 11 Oct 2022 10:50:03 +0000 Received: from localhost ([127.0.0.1]:51118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiCpm-0004qd-My for submit@debbugs.gnu.org; Tue, 11 Oct 2022 06:50:03 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiCpj-0004q9-5U for 58381@debbugs.gnu.org; Tue, 11 Oct 2022 06:50:01 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7]) by mira.cbaines.net (Postfix) with ESMTPSA id AEEC627BBE9; Tue, 11 Oct 2022 11:49:57 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 202dae13; Tue, 11 Oct 2022 10:49:57 +0000 (UTC) References: <87r0zil1bh.fsf@ngraves.fr> <20221008163932.15808-1-ngraves@ngraves.fr> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines Date: Tue, 11 Oct 2022 11:48:43 +0100 In-reply-to: <20221008163932.15808-1-ngraves@ngraves.fr> Message-ID: <87pmeyab3i.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665490679; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=EZPYhgSyPlbyrRhahmgkE2Px4OfAWoepATtdo9sB6Zk=; b=JWOdtUa1WGkebgl9ByQyU2EK/LfU8AQJKN440pY5nwx/fDX6PSYj4sjwZ41AeLJCMOIBcl AvDxv770D7T2zH+0v/l26Zd6u6fuwNPUbwhIxMITSwAwP5jnYZhrG4oowEEot1xgVZuKWu soMkncsJZc2ztEZrcenaJw1IhcNMF5/9reesUwgckRMZrb5hC6SxGxRAmKcwCjatJgKGRA GD/GqKQkZBmi8F2mO6E9HwHwZU+MAALR4TEZjAfp7Wy3qGKbaGn3SKEYb2pKlmgcIGa1CX QOevUZOxuzWcCGgovA3xEDZICofVUcHI/hgJvIFG9hvrYhtJk2soCFndmoz3UA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665490679; a=rsa-sha256; cv=none; b=l+DC9grVD3a48dT/sNdq7Cu3hs/FJE0QUn/aKrzrmcLRX19MTsjEC9ShG1gcxF0FHKmdWG WsPxni8q0nS6h/izFK8ZudeymN+wsvn5GzphotWBM5EEiGbyVdF9giHRDDehOie5aIABbG tdRz7GqiWlfYuHrasuVgqVsJ4sL5pynd3Ti8JkQqgHx2jgB3ZfH8h7KO5PDHV0tuLhp7Sy ySBjlAXhKw09UIngvk2DbkxkSZS3Waga9dlAVLzrD4bq2YmdcJedn6/mdyO+Qq1813lRrr vTWNFnTGm2Obugj5BpcBz6uRNmnXJ6FgjHBCwzmmP3JzZWd2UYxazgvJZJS9Tg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.50 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7D0953BA05 X-Spam-Score: -3.50 X-Migadu-Scanner: scn1.migadu.com X-TUID: T+72ZUHXyZH/ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Nicolas Graves via Guix-patches via writes: > * gnu/packages/security-token.scm (go-github-com-go-piv-piv-go): New vari= able. > --- > gnu/packages/security-token.scm | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Hi Nicolas, These patches look pretty good to me, just some things to check with propagated-inputs though. > diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-toke= n.scm > index 447a7a582d..3dc619ed4f 100644 > --- a/gnu/packages/security-token.scm > +++ b/gnu/packages/security-token.scm > @@ -17,6 +17,7 @@ > ;;; Copyright =C2=A9 2022 John Kehayias > ;;; Copyright =C2=A9 2022 Petr Hodina > ;;; Copyright =C2=A9 2022 Denis 'GNUtoo' Carikli > +;;; Copyright =C2=A9 2022 Nicolas Graves > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -44,6 +45,7 @@ (define-module (gnu packages security-token) > #:use-module (guix build-system cargo) > #:use-module (guix build-system cmake) > #:use-module (guix build-system gnu) > + #:use-module (guix build-system go) > #:use-module (guix build-system glib-or-gtk) > #:use-module (guix build-system python) > #:use-module (gnu packages autotools) > @@ -967,3 +969,30 @@ (define-public cardpeek > It also has limited support for Mifare Classic compatible cards (Thalys = card)") > (license license:gpl3+) > (home-page "http://pannetrat.com/Cardpeek"))) > + > +(define-public go-github-com-go-piv-piv-go > + (package > + (name "go-github-com-go-piv-piv-go") > + (version "1.10.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/go-piv/piv-go") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1j2szvvwgd0ysbap42rap4f60pj4smmmrxjlx0y131l3ki6v6gdm"))= )) > + (build-system go-build-system) > + (arguments > + '(#:import-path "github.com/go-piv/piv-go/piv" > + #:unpack-path "github.com/go-piv/piv-go" > + #:tests? #f)) > + (native-inputs (list pkg-config)) > + (propagated-inputs (list pcsc-lite)) What relation does pcsc-lite have to this package, and why does it need to be propagated? If this can be avoid, that would be good. Otherwise it would be good to mention why the propagation is needed in a comment. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNFSlFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfYFg/+P0CYkrsWuE6xqm1WTl0jLculxpSCQZM/ vRNiycXl9IXf4xz2OFrswi4d6yqdYQt2Fi1SOoLIOz1nkq60P6ARdd0W5BADfbi6 3BOV7IW2fDDtufuhfYxZC5ThskTlGwvJ6aoN8dPY2D+CroK4Vlb4Xzq6JbxxGqnk 1QpNklCmyoF09H803roHuaskM2cSpY0nTJhuEJImr0egvURPBccXNenTHjjMXYnu 650MqtyzFFSzts1rS1jL6pGivtE1IEeQNKUg2hJ8vPW7sU9uBI+jiwR2yh+9qtp4 RhmGYxNia3a7k3FpuXnBZUcTLIPPK5btSvqxVqpuR2LFIF8X1oz8QgmuQAku00mL XhXYfSm/dQaw0MEHNXksG0kMDUZ1lRaI3jGHUBKq9Ii9Q/BMvDhj5T382KELzEXy CVcAURMOmmxie53TbQJ1BRXb6eyO7j/qM9ZsldxDp/ewLxEJfdRbtHbGi2oxkT8e mmsUvTqA3QdWVzoA7M/zk5BQcMUfuLAqw4PfiQwutQvCnFWGiV/vf8gY2UPF/XId vA/hwy1pI4zFH9xcabZu8OnXrn73ub1XH/FwmjFJDVmexN7gJfPpzQzjQ/hhdV2d VTSU2oX/mLeX3PGI/5zYgw6c/ksvA9pRpXO8DiJbz5dQJDHk9HQSbBBRp3fgvZFl DNky5FWM5fo= =cMKP -----END PGP SIGNATURE----- --=-=-=--