From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OAHLNyTOhGOZ7wAAbAwnHQ (envelope-from ) for ; Mon, 28 Nov 2022 16:05:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OIL6NiTOhGNHygAAG6o9tA (envelope-from ) for ; Mon, 28 Nov 2022 16:05:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 16E5A3DEBF for ; Mon, 28 Nov 2022 16:03:31 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozfey-0007N4-Po; Mon, 28 Nov 2022 10:03:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozfew-0007M1-K7 for bug-guix@gnu.org; Mon, 28 Nov 2022 10:03:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozfew-0005eS-AO for bug-guix@gnu.org; Mon, 28 Nov 2022 10:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozfew-0005Ac-5y for bug-guix@gnu.org; Mon, 28 Nov 2022 10:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#59423: Invalid 'location' field generated in dovecot configuration Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 28 Nov 2022 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59423 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: Pierre Langlois , 59423@debbugs.gnu.org Received: via spool by 59423-submit@debbugs.gnu.org id=B59423.166964772619867 (code B ref 59423); Mon, 28 Nov 2022 15:03:02 +0000 Received: (at 59423) by debbugs.gnu.org; 28 Nov 2022 15:02:06 +0000 Received: from localhost ([127.0.0.1]:49075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozfe2-0005AN-Bu for submit@debbugs.gnu.org; Mon, 28 Nov 2022 10:02:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozfe0-00059s-2i for 59423@debbugs.gnu.org; Mon, 28 Nov 2022 10:02:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozfdn-0005Vi-45; Mon, 28 Nov 2022 10:01:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/pcxllbWI2sHAkYTX5VZszQNejpyDsVsJ70b9MlHKI0=; b=NokVW6lFzu9C0nBolwhS DQW8/Pjs1yVj/jo7luuDdJtPoz87Rs0xI4rXGgelXHgS3D72XsJ/Y9poCCb/cwwHhBd7LkYr5Lpnv 9IUn4Q5KqvZizBi4vBAgamCOeulGmk3zVu8B75rDYv1xArkCJqvtoGriB4fCAle3pfNe0OXYmxv3r henOYFAL+9mmu4HupjBoybokBlKWic3ea0M5B9f67A1bsWxpMA+q+DJZIcJ21x05ri/FRjCw4Jusd zMBum1pAfH1Ll+hRBO6hRxIkmNLrMaGI7PwiYrpri7lrf7wiiMj5M/vPzfHWnSO/9yxX+qw4EkAL6 8G/YeXSt5NIr9Q==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozfdm-0003uO-I8; Mon, 28 Nov 2022 10:01:50 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87y1s5wa4p.fsf@gmx.com> <87v8n2iytp.fsf@gmail.com> <875yf293ph.fsf@gmx.com> <87y1ry7o69.fsf@gmx.com> <87cz9a7n4y.fsf@gmx.com> <87fse6fmrq.fsf@gmail.com> <87cz995wwu.fsf@gmx.com> <87o7stw2gz.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 8 Frimaire an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Miel X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 28 Nov 2022 16:01:47 +0100 In-Reply-To: <87o7stw2gz.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 26 Nov 2022 21:33:32 -0500") Message-ID: <87pmd7ceck.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669647811; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/pcxllbWI2sHAkYTX5VZszQNejpyDsVsJ70b9MlHKI0=; b=oWeTwvd2nLy/vDB5QCWbuO6yieDRE7u7t6vE0MOqb+cQRMGXvXVsUvrH4fhYQM2KHx5ZxX 4TH0u3K24HsBMHuOf9rBWvY0cR8hagaphhFEBkmfvw8nBiO21zPKwfj7gIj408T5OL4ZH/ KpyKZoqfoGV3ZJPuOJT1yrbANI82QhMT2IqRa2MCwsSsZEFn08+TX+SmbojNJ9Ijfhvw/W vCillwUcR0HCTTJKIa7NV9vtlCWbjHEq0/hcrXFkcAcRfOhWXqcQtUc/whpa5MNA/MzD51 YF+athS+xkkK2AFEUAX6QvgZJVs7XCPaezlguz48IB6z1HEot3zJKhLfSw0cEw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669647811; a=rsa-sha256; cv=none; b=GrQabThVgLvHNU2Oz31OCGFCEwzc/Tqq7Mrnexwzbjc6yynhaVK4vdxGEiBGJ266eqbpfz ffln/rsnvzt0hMVHQRfybEOyvQw5TGK3Oddv+U7gv2qwPOPGEO/0cGGBCnwxV9T5/AFFM6 d/Td3Lz8JX2yzk0GaCWhXAiAGAd64n1WjUqyBY1yMKip3FKztEsE51Ir3SBE/+EFVt2D8V Z3lzzRjlw11XuhEk5b7syIT8nqD677er4NEWlAMv41uT6zl/B+JEhLJB/B1F+4HcejOpU5 hkW8PhVfaqai4JdUBou7PgTJaupNLxrOhTNjuQ7DkQlYVhONtZJdKAt9+gcw5g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=NokVW6lF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=NokVW6lF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 16E5A3DEBF X-Spam-Score: -4.66 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6NKL6u3xbyA6 Hi, Maxim Cournoyer skribis: >>> The issue seems to be with the serialization of the >>> object nested in the >>> record. I tried this at the REPL: >>> >>> scheme@(guile-user)> ,m (gnu services mail) >>> scheme@(gnu services mail)> (namespace-configuration (name "inbox")) >>> $8 =3D #< name: "inbox" type: "private" separa= tor: "" prefix: "" location: "" inbox?: #f hidden?: #f list?: #t subscripti= ons?: #t mailboxes: () %location: #f> >>> scheme@(gnu services mail)> (serialize-configuration $8 namespace-confi= guration-fields) >>> name=3Dinbox >>> type=3Dprivate >>> separator=3D >>> prefix=3D >>> location=3D#f >> >> The location here should probably be empty rather than `#f' no? It looks >> as though the value is coming from the internal %location, rather than >> the user-provided location. Uh. >> I'll if I can find anything the macro, it looks quite complex to me :-). > > It's not only to you, if that helps. It's rather... intimidating ^^'. [...] > Ludovic, would you have an idea of where the %location field or its > CONFIGURATION-location accessor come into play? We have this: (define-record-type* #,(id #'stem #'< #'stem #'>) stem #,(id #'stem #'make- #'stem) #,(id #'stem #'stem #'?) #,@(map (lambda (name getter def) #`(#,name #,getter (default #,def) (sanitize #,(id #'stem #'validate- #'stem #'- name)))) #'(field ...) #'(field-getter ...) #'(field-default ...)) (%location #,(id #'stem #'stem #'-location) (default (and=3D> (current-source-location) source-properties->location)) (innate))) That generates two accessors called =E2=80=98namespace-configuration-locati= on=E2=80=99. The second one shadows the first one. With commit 44554e7133aa60e1b453436be1e80394189cabd9, the second one is the =E2=80=9Cwr= ong=E2=80=9D one: =E2=80=98namespace-configuration-location=E2=80=99 now returns the =E2= =80=98%location=E2=80=99 field, not the user-specified =E2=80=98location=E2=80=99 field. (I reporte= d that issue in .) What do you think of reverting 44554e7133aa60e1b453436be1e80394189cabd9? After that we can work on renaming the =E2=80=98location=E2=80=99 field of while preserving backward compatibility. Thanks, Ludo=E2=80=99.