From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iPPUDtsPjmMREgAAbAwnHQ (envelope-from ) for ; Mon, 05 Dec 2022 16:35:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UIIfDtsPjmPUngAAG6o9tA (envelope-from ) for ; Mon, 05 Dec 2022 16:35:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A73221E362 for ; Mon, 5 Dec 2022 16:35:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2DUn-00083u-AX; Mon, 05 Dec 2022 10:35:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2DUk-00083f-AY for guix-patches@gnu.org; Mon, 05 Dec 2022 10:35:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2DUk-0002oU-0a for guix-patches@gnu.org; Mon, 05 Dec 2022 10:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2DUj-0004Tn-SY for guix-patches@gnu.org; Mon, 05 Dec 2022 10:35:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Dec 2022 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 59661@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167025450017209 (code B ref 59661); Mon, 05 Dec 2022 15:35:01 +0000 Received: (at 59661) by debbugs.gnu.org; 5 Dec 2022 15:35:00 +0000 Received: from localhost ([127.0.0.1]:36735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DUi-0004TV-17 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:35:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DUg-0004TO-5F for 59661@debbugs.gnu.org; Mon, 05 Dec 2022 10:34:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2DUa-0002mX-UQ; Mon, 05 Dec 2022 10:34:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=PeU3UXk9sl3+WKuO7QviV9u7u0LaYcA67IpGkCTafMA=; b=jKCzBAs4fYh+bUp/CRzS I6aPUdoRo/If+eHsm/jV8Cv9XTmaTDfSfVYRDftsP5x3zSelAeAJRXLrmT0nXkUXqpxTAefbzWb57 s/8M32EmlRYaaE/8sGMKzCOisp0nPoUJ04ch+T+1s5vLpO/OKV2FUMS8WlIt1qBl8jWsTCXhJ6t39 xFIHhPZRmMnLIkmsfLyPPxZ+m9PY7vpi+8eN/PrEptG1SKSguEIzxsgbnhZQNBy51zRVRXfg9CHsG VoT7azZEfl8LMlvMYYw+bjNldEdERY2E+09E71eEy4IpGFX6PIFSaCOb/gEiPEO5bsOQG+gS7C4LH l4+4L9blQsbAeA==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2DUa-0003YF-Dn; Mon, 05 Dec 2022 10:34:52 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <875yernns5.fsf@gnu.org> Date: Mon, 05 Dec 2022 16:34:50 +0100 In-Reply-To: (Efraim Flashner's message of "Mon, 5 Dec 2022 12:36:21 +0200") Message-ID: <87pmcxq2xx.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670254521; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PeU3UXk9sl3+WKuO7QviV9u7u0LaYcA67IpGkCTafMA=; b=CBj3OGSv57uXZqtb2sbWPxTU7tFbwU8Ua2JW+zNPvws+OCKGpx7v2DIVk9J5FPystAgq0l 7yeaKo14+eyb5RLE3n1M6av5Atvx9baOYCjQADefp4dlHjXBIUV0V9wYRqiKeZRjH2UKbW 4UJsQgbPuoTzRhXTAg91F9qxPDG33BQ2DYnRBo0orNOwW11L9qc4zMAmR7Fu+43cTo/53L kFc4HBb0QvoTAw3m55lUQzCUfUbdA1i5HGeed1AzLzIB/Ee1kf1KD+1rdMz0DnLmP/3HFg 6oQLyAytj471I/Tc+m5V1MAOri73u3U2mf4EBCspCWSFeUu3Gr72Toeuny+mfA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670254521; a=rsa-sha256; cv=none; b=pLgm8AhRjDUg/jKv36yiP/kWr5aLqbw8n9RQKtaeAO0xA3/L6Wquxx+3413vWJ7dcLwDBy +6cQEY+vGjj1OZ4WdA32+Ls5M/h0Z2iH9k0ZDxapprVB6lS8Esd1MhUP7lh/OwPUQNtKdL /VwuCrj3cbgnZ5C7n/1MQw/2dMYM8zxDaeBVCO2KcC2jl2NnDsRp5A2KrW+Y9nUxNpw9Ad rsSukXV75haZBaihSqS8kCKrVwLhf1kS94p0I1s3pvKB2B9ePWpm3bkUPhdX0txNEGKnGA bny30RqHPD+fcjfC/PC80hVBWpECJK0GKuRHE1u+CCFwAKt37z3h5bcryI4biQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jKCzBAs4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jKCzBAs4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A73221E362 X-Spam-Score: -4.77 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1Ul/6dRsjjNw Hi, Efraim Flashner skribis: > On Sun, Dec 04, 2022 at 05:20:42PM +0100, Ludovic Court=C3=A8s wrote: >> Hi, >>=20 >> Maxim Cournoyer skribis: >>=20 >> > Rationale: It is only used in INSTALLATION-OS and doesn't make sense t= o be >> > used in another context, given that file systems now automatically pul= l their >> > dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (se= rvices: >> > Add file system utilities to profile). >> > >> > * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename= to... >> > * gnu/system/install.scm (%installer-disk-utilities): ... this. >> > (installation-os) [packages]: Adjust accordingly. >>=20 >> Efraim, this variable was added in >> e6e076281e62518056987e9ddd3d96fccab20475 and used in >> 4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it=E2=80=99s okay= to >> remove now? (It LGTM, but I=E2=80=99d like to make sure we don=E2=80=99= t create churn.) > > I looked back through the commits around there. The whole point was the > following commit, to divide the longish haphazard list of packages into > sets of a sort. If it's only used in (gnu system install) then I don't > see a problem with moving it there. OK. >> (define-deprecated %base-packages-disk-utilities %base-packages '()) >>=20 >> This is not quite accurate but it should convey the idea. > > Would it be better to do > > (define-deprecated/alias-public %base-packages-disk-utilities > %installer-disk-utilities) > > And remove the export from the list at the top of (gnu system)? I don=E2=80=99t think we want users to rely on =E2=80=98%installer-disk-uti= lities=E2=80=99 in their OS config, so I=E2=80=99d go for Maxim=E2=80=99s version. Thanks, Ludo=E2=80=99.