From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id Ahw4BTmSwWPtCQAAbAwnHQ (envelope-from ) for ; Fri, 13 Jan 2023 18:17:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mGY0BDmSwWPUSAEA9RJhRA (envelope-from ) for ; Fri, 13 Jan 2023 18:17:45 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A47A639D3B for ; Fri, 13 Jan 2023 18:17:44 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGMAE-0006VX-H1; Fri, 13 Jan 2023 10:40:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGM9z-0006VE-2F for bug-guix@gnu.org; Fri, 13 Jan 2023 10:40:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGM9y-0004KU-Mf for bug-guix@gnu.org; Fri, 13 Jan 2023 10:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pGM9y-0005ng-Ij for bug-guix@gnu.org; Fri, 13 Jan 2023 10:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#59913: [tentative PATCH] Failure to guix pull on aarch64 since recent make-linux-libre* Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 13 Jan 2023 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59913 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 59913@debbugs.gnu.org Received: via spool by 59913-submit@debbugs.gnu.org id=B59913.167362439622279 (code B ref 59913); Fri, 13 Jan 2023 15:40:02 +0000 Received: (at 59913) by debbugs.gnu.org; 13 Jan 2023 15:39:56 +0000 Received: from localhost ([127.0.0.1]:52175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGM9r-0005nH-It for submit@debbugs.gnu.org; Fri, 13 Jan 2023 10:39:56 -0500 Received: from mail-yw1-f178.google.com ([209.85.128.178]:35589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGM9o-0005n4-Vp for 59913@debbugs.gnu.org; Fri, 13 Jan 2023 10:39:53 -0500 Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-4d4303c9de6so139265947b3.2 for <59913@debbugs.gnu.org>; Fri, 13 Jan 2023 07:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dVPOy5RmlJ+QmTRAQyVUHr8poQr7OwfvmVCOVQ1ymcM=; b=mwsDUNqTvRJo7vxeSKCSMhgDcIs866HslQqyIlqBiJWV9GqmhfVeIOFY0tGfxb4Gf7 MfoA2zexdcyyjFjkVg8HFfCpjt5YTYmbfJZLTc/BxwvNCc9yPMakcvP5ncdiaE0OPaP7 pivLAzf1oUHX/m662OhLl0/vj9FyRx7SrtXvSY8TWjS5OA2TbQAwX9yGt6dUvl3GFJMo +Lc0OPSSHfZCixIIe+7uN/RRO8+xtY02BdMtxyFC3oOikizTEaCWObQZVWWimmgOpxNm r2JC0qczW5Vqdbv/9HrAPr9hb0dJ1HOLAbMnE6+8yGbfwGFDPIrIGRPt4mZsV780Ah0H /3Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dVPOy5RmlJ+QmTRAQyVUHr8poQr7OwfvmVCOVQ1ymcM=; b=TmrxgZogKaB7u0SehmgWrjxPPwBhZ54hnrUT+/kFqLY4cREK+CTxPzMDUVNFmWSLvm GyHKHlU5VSOKt6NAh4xaqELhUDL0iQVCI+2e/rgO5EMO8xnb9+Y0UbYxg/oRkznk5E8b 5lc5B4enu7vTUZ8QvTn6W3oK/dt/da+pmwmx54nWOYe7LECjq+38K/ZKIOvf3wKTsJDj nACdpHh5+CpoiBdV0B6zHK1fkrXk4is9Ima3WMXkxBx1VPcfiQzsaYcZC1nZw3+0MrSa VdptItycnAWBpvHwFURYGhBYanzjZgQjx+xd29rO0nMUXnkLehVbOaIj15ElxuodFW02 C75A== X-Gm-Message-State: AFqh2kpFtghanSIfhcF0fvhogSiLOPiFXeAc+Juxr51Y+UxsaIQ0hrKq l227ES7TIQcmidR1nDOYfrtBTphPW73qefFd X-Google-Smtp-Source: AMrXdXtMS5C5DPUrNc7vpIV0AuiJ1dY5uwqHcPGoUX6JM4enoHcb7o/0vNGBCTT/o2deN2XcsSkKow== X-Received: by 2002:a81:6e54:0:b0:364:1ba1:4bd0 with SMTP id j81-20020a816e54000000b003641ba14bd0mr30258327ywc.41.1673624386952; Fri, 13 Jan 2023 07:39:46 -0800 (PST) Received: from hurd (dsl-10-149-10.b2b2c.ca. [72.10.149.10]) by smtp.gmail.com with ESMTPSA id br31-20020a05620a461f00b006fa2cc1b0fbsm12738917qkb.11.2023.01.13.07.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 07:39:46 -0800 (PST) From: Maxim Cournoyer References: <87k031xxss.fsf@gmx.com> Date: Fri, 13 Jan 2023 10:39:45 -0500 In-Reply-To: <87k031xxss.fsf@gmx.com> (Pierre Langlois's message of "Thu, 08 Dec 2022 23:31:48 +0000") Message-ID: <87pmbifnpa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673630264; a=rsa-sha256; cv=none; b=DNr6pYly2ZYKtHOA74/hLvqenaHXYx1tqzL6/1W/j8F1SMYe7bcqDfYK8a2XMNdhKRqPl+ cb3NMl6NBT9Uekj6jR/bN/3jL0R/LahQQE9mhralx9fe/A3cKslwpJsecbS2P2lDVH30QH H6Bj76WpWNNp31hSXDQWWfI7WMdzgWLQi6A5oukV8wiBwv4MCfsA8XBxuHEvEaTQ5k3EXF shpRYWlbM18inW8d5u6wiiIgcUihFa3jh/GHFtVa6rr80ApnZy2d32h9xD1/FAOv68ICGX RBRVUMzCKoqKw4Kj0VWKEYiTnj3OezCNoBSpSJJAI3WWnOI1mHplfXqDjSvdSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=mwsDUNqT; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673630264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dVPOy5RmlJ+QmTRAQyVUHr8poQr7OwfvmVCOVQ1ymcM=; b=d8P6hXvGfqZXzmaL6D4jKkhQYjsR7yDZdpaQBrDIC3eFzFNvhJ17Bq6DkujSV050XSe58Z JnnS7wBvst2eGUpfRMmgKuq3OUtLpeQGRTNknK38uJu2PoY0PPasFk7F6wmfJl5QI+8ycA aCHll5i+kslrrpC31amAmw/ZrGM5A3W59+6Ketemvuw3wbIoG/yrTtUsP7paAPsStl9b2q 08t0IAnbBpOlJnCgQ921mtDqE+HPCeSvw2yHlQHuTjGYxk7vQ7VPSMycK1JJ3vJmCUNGMc 4G83Qn3XA0HH+rXl0IXnnOVWIot7xNuUY4UvNi1Fnftc7LrRN86nAjLhxZXsNQ== X-Migadu-Spam-Score: -0.50 X-Spam-Score: -0.50 X-Migadu-Queue-Id: A47A639D3B X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=mwsDUNqT; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: dynoMXPipZoM Hi Pierre, Pierre Langlois writes: > Hi Guix! > > I've been getting errors while running `guix pull' on an aarch64 system, > during the final guix-package-cache step: > > (repl-version 0 1 1) > Generating package cache for '/gnu/store/m8in1imi93snq711d7568dj9hlrx4diz-profile'... > > Backtrace: > In ice-9/boot-9.scm: > 1747:15 19 (with-exception-handler # ?) > 1752:10 18 (with-exception-handler _ _ #:unwind? _ # _) > In guix/repl.scm: > 99:21 17 (_) > In unknown file: > 16 (_ # # ?) > 15 (primitive-load "/gnu/store/3x6g541ixbmdjav4ky6dp1ryj4l?") > In ice-9/boot-9.scm: > 1752:10 14 (with-exception-handler _ _ #:unwind? _ # _) > In gnu/packages.scm: > 438:11 13 (generate-package-cache _) > In srfi/srfi-1.scm: > 460:18 12 (fold # _ _) > In gnu/packages.scm: > 390:9 11 (expand-cache . _) > In guix/packages.scm: > 1317:17 10 (supported-package? # ?) > In guix/memoization.scm: > 101:0 9 (_ # # ?) > In guix/packages.scm: > 1295:37 8 (_) > 1555:16 7 (package->bag _ _ _ #:graft? _) > 1660:43 6 (thunk) > In gnu/packages/linux.scm: > 986:37 5 (arguments #) > In guix/gexp.scm: > 460:52 4 (%local-file #f # ?) > In unknown file: > 3 (basename #f #) > In ice-9/boot-9.scm: > 1685:16 2 (raise-exception _ #:continuable? _) > 1780:13 1 (_ #<&compound-exception components: (#<&assertion-fail?>) > In unknown file: > 0 (backtrace #) > > (exception wrong-type-arg (value "scm_to_utf8_stringn") (value "Wrong type argument in position ~A (expecting ~A): ~S") (value (1 "string" #f)) (value (#f))) > > > I was able to decipher the backtrace to *maybe* put together a fix, but > I'm unsure why the problem started. My best guess is that it started > with commit dfc6957a5af7d179d4618eb19d4f555c519bc6f2, even though I > can't find where the issue actually is, it looks fine to me! > > What seems to happen is that the `kernel-config' function now receive an > `arch' argument for an architecture that isn't actually supported by > that kernel, as is the case for linux-libre@4.14.300. And, correctly, > the function should not expect to ever get such arch value to begin > with, so we get a `(local-file #f)'. > > (define* (kernel-config arch #:key variant) > "Return a file-like object of the Linux-Libre build configuration file for > ARCH and optionally VARIANT, or #f if there is no such configuration." > (let* ((name (string-append (if variant (string-append variant "-") "") > (if (string=? "i386" arch) "i686" arch) ".conf")) > (file (string-append "linux-libre/" name))) > (local-file (search-auxiliary-file file)))) > > I think it's fair for that function expect the arch to be valid (why > would you ask the config for an unsupported arch?). > > I think it should be possible to fix this by checking the arch is > supported at the call site: > >>>From 77829140f14928e30cbe4e53c625be3ba2f5895f Mon Sep 17 00:00:00 2001 > From: Pierre Langlois > Date: Thu, 8 Dec 2022 23:41:40 +0000 > Subject: [PATCH] gnu: make-linux-libre*: Do not get config for unsupported > systems. > > * gnu/packages/linux.scm (make-linux-libre*)[phases] : Check > arch is in supported-systems before calling configuration-file. > --- > gnu/packages/linux.scm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index 5ae6366593..87fc9fe94c 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -983,6 +983,7 @@ (define* (make-linux-libre* version gnu-revision source supported-systems > (or (%current-target-system) > (%current-system)))))) > (and configuration-file arch > + (member arch supported-systems) > (configuration-file > arch > #:variant (version-major+minor version)))) Thanks for investigating the issue. I'm hitting the same kind of problem (it seems) trying to migrate make-u-boot-package to gexps, so I'm revisiting this. It seems to me that the produced backtrace is overly cryptic; perhaps configuration-file should throw an exception with a more detailed error "unsupported architecture -- not generating configuration file" or similar? Or should the generate-package-cache machinery catch these #f itself? That's the same place where it fails in my case with this patch applied: https://issues.guix.gnu.org/60224#30, and with the reproducer: --8<---------------cut here---------------start------------->8--- (package-transitive-supported-systems u-boot-malta (%current-system)) --8<---------------cut here---------------end--------------->8--- I'm still digging into the issue to get a better understanding. -- Thanks, Maxim