From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sG1jKYFixWOmXwAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 15:43:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4OhoKIFixWPw2QAAG6o9tA (envelope-from ) for ; Mon, 16 Jan 2023 15:43:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 38AB72C778 for ; Mon, 16 Jan 2023 15:43:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHQhX-00075p-31; Mon, 16 Jan 2023 09:43:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQhS-00075A-7b for guix-patches@gnu.org; Mon, 16 Jan 2023 09:43:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHQhR-0008FQ-VX for guix-patches@gnu.org; Mon, 16 Jan 2023 09:43:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHQhR-0006j0-RR for guix-patches@gnu.org; Mon, 16 Jan 2023 09:43:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59762] Add serial-studio Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Jan 2023 14:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina Cc: 59762@debbugs.gnu.org Received: via spool by 59762-submit@debbugs.gnu.org id=B59762.167388016125817 (code B ref 59762); Mon, 16 Jan 2023 14:43:01 +0000 Received: (at 59762) by debbugs.gnu.org; 16 Jan 2023 14:42:41 +0000 Received: from localhost ([127.0.0.1]:32784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQh7-0006iJ-Dx for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:42:41 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:42552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQh5-0006i5-JT for 59762@debbugs.gnu.org; Mon, 16 Jan 2023 09:42:40 -0500 Received: by mail-qt1-f172.google.com with SMTP id fd15so14760401qtb.9 for <59762@debbugs.gnu.org>; Mon, 16 Jan 2023 06:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=o17Zz2iocql32YBuyhhFhRjEG1CI6KNUnYbd3adPMgo=; b=Jov+F3Xj0rblpP8AKo7namSbWj9Cud9fprF1lst8qzf0gTjmXVbAbXKHiujd0XuHJk IzSllwFSIIk2BijHZ5zpQfV3+loWbPDYvXIfBlBaPUEj3KXySH2psn9nQa5V8g+F+3wN 8kYLoTYVPVa5DnD9yTBxpCVgEdKzNFVqqe155xLZ6uMyfHDeN0plQitv7uvJobMPSM3B WEU7DahdhKzLgwFU8KsPU6dljvFLuvgI2sl9ai+ECwsW9REHvp473Pp8/UxSVA+YHvMw d/+JWmkn4EUxC4pS3vM666orCtKw86TfBhTMng1byOiUbBzAbvRftHXVkgrbOyvPEbAF DRjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o17Zz2iocql32YBuyhhFhRjEG1CI6KNUnYbd3adPMgo=; b=v6HB4KF7Ln8vQdcBK6zQAL/8u/YkWIacy5YNsK6kzBA9Ibl/DRdNkl3PX5KtaLTkIU 0veYwsR6sSv0vFb1bhsPbXephdwKFPp9apUrJEMkI3mTRNHIdQghAMz+MrxxCRGAEmAL 5bQQXclRwxLqJprNmsvMlJK1kQZmO6FXAJgpIDYZC4xkxY3RQJacNpE8Y1LpnPb6May/ 5Ir5AhkTGfJYQuqktEDA5X0tPkO6Mn97ABHnrHq/934eXTNQ8Yz+qGEkEMDA2c4oPceW Iwx9nZw4cMtwhRbdoiR9K6PqBrDymVNC7xNTl3jcD8DhfYe2l3lfWIuhUdRTu1mEy9xX qlDA== X-Gm-Message-State: AFqh2koyG1pjGH75aZK3DZr6w5VNCfCFH5ibYhbXpX/X0/14uCc8gX22 q878OVH4NCfOFtizVdtANaKmhMxLb83zS5F/ X-Google-Smtp-Source: AMrXdXtz5DYDknPxjRrT9Nd7wZA8QOuLMV6JXRGk0NCbloYsvLotSxxjA+xhXKksKL0ok1svQLWbuw== X-Received: by 2002:ac8:530a:0:b0:3b6:31e3:1a57 with SMTP id t10-20020ac8530a000000b003b631e31a57mr4770548qtn.8.1673880153873; Mon, 16 Jan 2023 06:42:33 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id u15-20020a05620a454f00b006ce76811a07sm18572377qkp.75.2023.01.16.06.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:42:33 -0800 (PST) From: Maxim Cournoyer References: Date: Mon, 16 Jan 2023 09:42:32 -0500 In-Reply-To: (phodina@protonmail.com's message of "Fri, 02 Dec 2022 05:29:47 +0000") Message-ID: <87pmbea6cn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Jov+F3Xj; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673880193; a=rsa-sha256; cv=none; b=G8sfh4sPJRv7IYvWXFZCo5SbArNEaVAN1Cl/vzTftK5qUL1PCbXbT0ZhJnKxjKFoiUTuCb x0xELbHmGKMlhE8sEBNWW1+Z4EPybQ8bPMmLNt38xMn0cUg+GyCTLY28U0a/gU7eOTFNPY rPj9ZgBjpHVXk7VbObS16D5bbMwhJQMIKkZb1jTkBy32vFl2NzvoHM8YuDRN4o1yL5onlO Xs2RHuSPlkAVTMC3IMjA95Za2GcdQ0xdAwKMSyLzzrKtVzfbooYwhfjDI3rlWTxXbgJXah 3/TDsNfNP+TbP3gKjTavDU6qKFdh27/5kb/OXKI2eTmr6XIkREaTPk8F37P+Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673880193; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=o17Zz2iocql32YBuyhhFhRjEG1CI6KNUnYbd3adPMgo=; b=fN+qxCYykWDXG8xE8XZEAObMCp9Mb3K3OvWOyurwj6MmviZ7NRDQFpNO1SjmBkN/azNS9i D7E+RnZEanLwcqbi/X5vN7w581xl0QQWm1snF3dlBaPgNYpm98cuXHZC8A4drwC3fzOFUS C1w1PaHu8zhNml7fTWpOw6p9G+bFbjGquLx6dVzezbPtFfq+A1du6CNR+fSE21os1Z6oAh hfT0XDz2oApQ2ND0KF2P9Su9Sd5DPAuqIYSqXd1zszlfRpG+jjZT7VENiutZi3Ov57YKG3 hfFzi2RlsjxlD8PjLLPkzpKHkiVbIpLoGcZ4FjfVleMxMrGE+ObzFtjQEu+BDQ== X-Migadu-Queue-Id: 38AB72C778 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Jov+F3Xj; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: -1.33 X-Spam-Score: -1.33 X-TUID: mnwirAcICB/Q Hi again! phodina writes: > Hi, > > this adds a nice GUI program to monitor communication on serial interfaces (e.g. UART). > > ---- > Petr > > > > From 6b25d088bd158ad2c5baa7548c49a04bd0f09664 Mon Sep 17 00:00:00 2001 > From: Petr Hodina > Date: Wed, 19 Jan 2022 12:01:22 +0100 > Subject: [PATCH 2/4] gnu: Add qtcsv. > > * gnu/packages/qt.scm (qtcsv): New variable. > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > index 6aaa9c47c2..71c8aafe3c 100644 > --- a/gnu/packages/qt.scm > +++ b/gnu/packages/qt.scm > @@ -1283,6 +1283,58 @@ (define-public qtconnectivity > (description "The Qt Connectivity modules provides modules for interacting > with Bluetooth and NFC."))) > > +(define-public qtcsv > + (package > + (name "qtcsv") > + (version "1.6") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/iamantony/qtcsv") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "109nbspnhaczm85wp1fqazmamdj2bh9wfv3anlslvll606lrfgir")))) > + (build-system cmake-build-system) > + (arguments > + `(#:phases (modify-phases %standard-phases Please switch to list + gexps. > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (invoke "qmake"))) Use plain lambda without arguments (lambda _). > + (add-after 'unpack 'fix-install > + (lambda* (#:key outputs #:allow-other-keys) Ditto. > + (let* ((out (assoc-ref outputs "out"))) > Use gexps variables. > + (substitute* "qtcsv.pro" > + (("/usr") out) > + (("\\$\\$PWD") out))))) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) (lib (string-append > + out "/lib")) Ditto :-). > + (include (string-append out "/include"))) > + (mkdir-p include) > + (mkdir-p lib) > + (chdir "..") ;we were in dir tests Same comment bout active tense as earlier... but it seems that'd no longer be needed with the next comment implemented? > + (copy-recursively "include" include) > + (for-each (lambda (file) > + (install-file (string-append file) lib)) > + '("libqtcsv.so" "libqtcsv.so.1" > + "libqtcsv.so.1.6" "libqtcsv.so.1.6.0"))))) > + (replace 'check > + (lambda* (#:key tests? test-options parallel-tests? > + #:allow-other-keys) > + (when tests? > + (chdir "tests") > + (invoke "qmake"))))))) If qmake has a switch like make to change directory, e.g. -C, that'd be preferable, else "with-directory-excursion" to avoid keeping state in other phases. Otherwise, this patch LGTM. -- Thanks, Maxim