From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cJFhJDA/6mOaYQAAbAwnHQ (envelope-from ) for ; Mon, 13 Feb 2023 14:46:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mImDIzA/6mPcXAEAG6o9tA (envelope-from ) for ; Mon, 13 Feb 2023 14:46:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE2D03E7 for ; Mon, 13 Feb 2023 14:46:23 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=CnLGGrDV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676295984; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=nl8jwgJm2+G1R9pJcSFfGE4wKDvmNqdPeqPLVjVZsIs=; b=TicxExrelR7nW9glB06TbS5rRCXxUQ27TL2qhRuQi6Pcn2YZ7mvGirEi6CFYopT4oo8iED xL3X6S+txJ+PtHn/OTlvBdGsMXXs9gLEX774uhWR5Pbm1DwkClqRtrICCqJ2ivqFNmR29C DTiQd5zfzWYiD0hhdmuF63+QsMKw2tCfJaRxshuY4qr0aBzflR5zhv+esfnjZljzA0S81X /n/dz3cwhKPWAGpY2CtD+qViSoRGKlLc8N4RnGe2WV2MY9150C+B1zsBYdxAwqG17UzXd5 M/CNIoXA4o4LIdZXzFS9reEvk689JGXBNIvgSF/B339kaz8MIOftUC1ylUR3+Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=CnLGGrDV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676295984; a=rsa-sha256; cv=none; b=qERp9Hx/Jeo0Os0sAS8QE3aRvdx3/KgNZU189mPtn1mnc4pl2lk58ykHqpyp49aPS7cAXr Fffs/pjF87GKEctR2ikscLihWTN4UiBO9PQMayWXmOhQ6HMxqxuqs9a52NzG8Y4PxcGuHu 6i7NQQKWX2NW0i0DZSSZ0JpmIEgnuC3bhf51mJ6xjzS+WAvMpOZ7BzZKwx7z/Ok9ccqWUN fwKd75JQmZ1B2Lbmz66D7NyS+bn5YemIMbzj3+SeXl4lzinEfhk0Kz2fnT06qGAI7EaGwg 2tmFCE2KRbI6fADQZD1SjDzDr2dqTKW8vmrd+a88T3gq8JUc6RQ6U7Oj3QNUeA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRZ9h-0007Kq-NF; Mon, 13 Feb 2023 08:46:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRZ9f-0007Kc-5o for guix-patches@gnu.org; Mon, 13 Feb 2023 08:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRZ9e-00036Z-IG for guix-patches@gnu.org; Mon, 13 Feb 2023 08:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRZ9e-0001sV-3r for guix-patches@gnu.org; Mon, 13 Feb 2023 08:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60386] [PATCH] gnu: Add guile-proba. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Feb 2023 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60386 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Luis Felipe , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 60386@debbugs.gnu.org Received: via spool by 60386-submit@debbugs.gnu.org id=B60386.16762959077149 (code B ref 60386); Mon, 13 Feb 2023 13:46:02 +0000 Received: (at 60386) by debbugs.gnu.org; 13 Feb 2023 13:45:07 +0000 Received: from localhost ([127.0.0.1]:47995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRZ8k-0001rE-Si for submit@debbugs.gnu.org; Mon, 13 Feb 2023 08:45:07 -0500 Received: from mail1.fsfe.org ([217.69.89.151]:59214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRZ8f-0001qQ-Qn for 60386@debbugs.gnu.org; Mon, 13 Feb 2023 08:45:05 -0500 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1676295899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nl8jwgJm2+G1R9pJcSFfGE4wKDvmNqdPeqPLVjVZsIs=; b=CnLGGrDVsa/VMokOXEg/SBqghdOMtyFuNvOXW9BtJU36oz0I2aq51bkgQ+BwXZ9FtQ+Z7i fLnGCmRdKh2+ktWzYwrCzseUpypP8pa1jGvuupGNnoup2E/1dBDFWH3+y912sORCieJbpC mtc/Jw9Kealb7ENAv3xl0SZymYvyOTU= In-Reply-To: References: <87358ioeb6.fsf@gnu.org> <87edrti82j.fsf@gnu.org> <0R2fGew0iuJD4YBAaHVjCshZMF52BTBE0WeK7DfiPAO5ebcSRE6PWiix30uJUY35OigiDykEQF_ZpjNc18IoQatNgRXsz4_cx6oMriFDo8M=@protonmail.com> <87wn5cyjkw.fsf@gnu.org> <_jbPEie6ho5J8_1hgP63VBuPhumFn1hAzjkWOv0rD7BwHVYo7ZgAa7UAxkuXNRxGvPBwbz6xNBQ2S2TZMwbDnme8JVwnDqtwElWisSfBr8E=@protonmail.com> <87sffxr63g.fsf_-_@gnu.org> Date: Mon, 13 Feb 2023 14:44:58 +0100 Message-ID: <87pmadr86d.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: X-Migadu-Queue-Id: DE2D03E7 X-Spam-Score: 5.38 X-Migadu-Spam-Score: 5.38 X-Migadu-Scanner: scn0.migadu.com List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: jMne7is4gmcs Hi Luis, Luis Felipe via Guix-patches via writes: > Hello again, > > This is a new patch with guile-proba version 0.3.0, which solves the missing module import problem. Thank you for working on this, both upstream and the package itself. > [snip] > + > +(define-public guile-proba > + (package > + (name "guile-proba") > + (version "0.3.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://codeberg.org/luis-felipe/guile-proba") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1mjnrbb6gv5f95i1ihn75yh7ya445pcnj13cy34x2v58h9n2r80s")))) > + (build-system guile-build-system) > + (inputs (list bash-minimal)) > + (native-inputs (list guile-3.0 texinfo)) I think guile should be a normal input. Other packages like this (e.g. guilescript, ccwl) seem to do it that way. > + (propagated-inputs (list guile-config guile-lib)) > + (arguments > + (list > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'build 'check > + (lambda _ > + (invoke "guile" "proba.scm" "run" "tests"))) > + (add-after 'install 'install-wrapped-script > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (version (target-guile-effective-version)) > + (scm (string-append "/share/guile/site/" version)) > + (go (string-append "/lib/guile/" version "/site-ccache")) > + (bin-dir (string-append out "/bin")) > + (script (string-append bin-dir "/proba"))) > + (mkdir-p bin-dir) > + (copy-file "proba.scm" script) > + (chmod script #o555) > + (wrap-program script > + `("GUILE_LOAD_PATH" prefix > + (,(string-append out scm))) > + `("GUILE_LOAD_COMPILED_PATH" prefix > + (,(string-append out go))))))) This seems almost correct, as it extends the GUILE_LOAD_{,COMPILED}_PATH at runtime; the user would for still need to have the guile-config and guile in their profile. Although guile-config is also listed as a propagated input, when the guile search paths specifications are not active, the following would not work: `guix shell --pure guile-proba -- proba run tests' You could have a look at the 'wrap phase of the ccwl package; they use the value of (getenv "GUILE_LOAD_{,COMPILED}_PATH") retrieved while building the package to wrap their script. > + (add-after 'install 'install-manual > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (info-dir (string-append out "/share/info"))) > + (mkdir-p info-dir) > + (invoke "makeinfo" "manual/main.texi") > + (install-file "guile-proba" info-dir))))) Nitpick, so feel free to ignore: You could split up building and installing the manual. > + #:not-compiled-file-regexp > + "((bogus|bogus-tests|packages|tests)\\/.*.scm|(proba|manifest).scm)$")) All of the files listed in this regex are still installed in /share/guile/site/3.0. Do you think it would be possible to ensure these files are not installed? > + (home-page "https://luis-felipe.gitlab.io/guile-proba/") > + (synopsis "Testing tools for GNU Guile projects with SRFI 64 test suites") > + (description > + "This software is a set of testing tools for GNU Guile projects > +with SRFI 64-based test suites. It comes with a command-line interface > +to run test collections, and a library that includes a test runner and > +helpers for writing tests.") > + (license license:public-domain))) > > base-commit: fc5dc3e04789a15d80a7b35987adaefc1a94b97c > -- > 2.38.1