From: Jelle Licht <jlicht@fsfe.org>
To: "Luis Felipe" <luis.felipe.la@protonmail.com>,
"Ludovic Courtès" <ludo@gnu.org>
Cc: 60386@debbugs.gnu.org
Subject: [bug#60386] [PATCH] gnu: Add guile-proba.
Date: Mon, 13 Feb 2023 14:44:58 +0100 [thread overview]
Message-ID: <87pmadr86d.fsf@fsfe.org> (raw)
In-Reply-To: <REtOheZAbpl8H2a73GxbVc3Iegd9VNhDv1PO6AAPng_t2opK95fuNXoXbHewNb3YvYv62CcJP4jQEPTKxpH9VXEjAjxS7cy-jcsd4glk56Q=@protonmail.com>
Hi Luis,
Luis Felipe via Guix-patches via <guix-patches@gnu.org> writes:
> Hello again,
>
> This is a new patch with guile-proba version 0.3.0, which solves the missing module import problem.
Thank you for working on this, both upstream and the package itself.
> [snip]
> +
> +(define-public guile-proba
> + (package
> + (name "guile-proba")
> + (version "0.3.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://codeberg.org/luis-felipe/guile-proba")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1mjnrbb6gv5f95i1ihn75yh7ya445pcnj13cy34x2v58h9n2r80s"))))
> + (build-system guile-build-system)
> + (inputs (list bash-minimal))
> + (native-inputs (list guile-3.0 texinfo))
I think guile should be a normal input. Other packages like this
(e.g. guilescript, ccwl) seem to do it that way.
> + (propagated-inputs (list guile-config guile-lib))
> + (arguments
> + (list
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'build 'check
> + (lambda _
> + (invoke "guile" "proba.scm" "run" "tests")))
> + (add-after 'install 'install-wrapped-script
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (version (target-guile-effective-version))
> + (scm (string-append "/share/guile/site/" version))
> + (go (string-append "/lib/guile/" version "/site-ccache"))
> + (bin-dir (string-append out "/bin"))
> + (script (string-append bin-dir "/proba")))
> + (mkdir-p bin-dir)
> + (copy-file "proba.scm" script)
> + (chmod script #o555)
> + (wrap-program script
> + `("GUILE_LOAD_PATH" prefix
> + (,(string-append out scm)))
> + `("GUILE_LOAD_COMPILED_PATH" prefix
> + (,(string-append out go)))))))
This seems almost correct, as it extends the GUILE_LOAD_{,COMPILED}_PATH
at runtime; the user would for still need to have the guile-config and
guile in their profile. Although guile-config is also listed as a
propagated input, when the guile search paths specifications are not
active, the following would not work:
`guix shell --pure guile-proba -- proba run tests'
You could have a look at the 'wrap phase of the ccwl package; they use
the value of (getenv "GUILE_LOAD_{,COMPILED}_PATH") retrieved while
building the package to wrap their script.
> + (add-after 'install 'install-manual
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (info-dir (string-append out "/share/info")))
> + (mkdir-p info-dir)
> + (invoke "makeinfo" "manual/main.texi")
> + (install-file "guile-proba" info-dir)))))
Nitpick, so feel free to ignore:
You could split up building and installing the manual.
> + #:not-compiled-file-regexp
> + "((bogus|bogus-tests|packages|tests)\\/.*.scm|(proba|manifest).scm)$"))
All of the files listed in this regex are still installed in
<out>/share/guile/site/3.0. Do you think it would be possible to ensure
these files are not installed?
> + (home-page "https://luis-felipe.gitlab.io/guile-proba/")
> + (synopsis "Testing tools for GNU Guile projects with SRFI 64 test suites")
> + (description
> + "This software is a set of testing tools for GNU Guile projects
> +with SRFI 64-based test suites. It comes with a command-line interface
> +to run test collections, and a library that includes a test runner and
> +helpers for writing tests.")
> + (license license:public-domain)))
>
> base-commit: fc5dc3e04789a15d80a7b35987adaefc1a94b97c
> --
> 2.38.1
next prev parent reply other threads:[~2023-02-13 13:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 18:07 [bug#60386] [PATCH] gnu: Add guile-proba Luis Felipe via Guix-patches via
2023-01-10 10:48 ` Ludovic Courtès
2023-01-13 15:41 ` Luis Felipe via Guix-patches via
2023-01-17 13:50 ` Ludovic Courtès
2023-01-18 18:20 ` Luis Felipe via Guix-patches via
2023-01-23 22:25 ` Ludovic Courtès
2023-01-25 1:11 ` Luis Felipe via Guix-patches via
2023-01-26 9:35 ` Ludovic Courtès
2023-01-26 14:29 ` Luis Felipe via Guix-patches via
2023-02-06 15:40 ` Luis Felipe via Guix-patches via
2023-02-13 13:44 ` Jelle Licht [this message]
2023-02-15 21:56 ` Luis Felipe via Guix-patches via
2023-02-21 17:54 ` bug#60386: " Jelle Licht
2023-02-15 21:59 ` [bug#60386] [PATCH v4] " sirgazil--- via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmadr86d.fsf@fsfe.org \
--to=jlicht@fsfe.org \
--cc=60386@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=luis.felipe.la@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.