From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SF+bOj10/2Nc1wAAbAwnHQ (envelope-from ) for ; Wed, 01 Mar 2023 16:50:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MO5vOj10/2NrEQAAauVa8A (envelope-from ) for ; Wed, 01 Mar 2023 16:50:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 78FD0BD23 for ; Wed, 1 Mar 2023 16:50:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXOiT-0001HX-Ls; Wed, 01 Mar 2023 10:50:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXOiR-0001GG-Mg for bug-guix@gnu.org; Wed, 01 Mar 2023 10:50:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXOiR-0006z1-33 for bug-guix@gnu.org; Wed, 01 Mar 2023 10:50:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXOiQ-0000N9-Vf for bug-guix@gnu.org; Wed, 01 Mar 2023 10:50:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61684: can't compose 'with-patch' with 'with-source' Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 01 Mar 2023 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61684 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon Tournier Cc: 61684@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 61684-submit@debbugs.gnu.org id=B61684.16776857831343 (code B ref 61684); Wed, 01 Mar 2023 15:50:02 +0000 Received: (at 61684) by debbugs.gnu.org; 1 Mar 2023 15:49:43 +0000 Received: from localhost ([127.0.0.1]:54657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXOi7-0000Lb-3Z for submit@debbugs.gnu.org; Wed, 01 Mar 2023 10:49:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXOi5-0000LO-98 for 61684@debbugs.gnu.org; Wed, 01 Mar 2023 10:49:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXOhz-0006ri-U6; Wed, 01 Mar 2023 10:49:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=gy4Zib3CQWq/Yc7RYgBI8RN7QCcqriAeY303tdWeR7g=; b=Nz51uhQkofJ8hq/Oxjrq D4XwpXzw5CjN+J9drNegd/Nbwps6T8TBzVjjwM08MnPjktkLJ1ZNfdgX9qUeUFRC+n4bp/Ey2TLxO 1Cy90V2AG7bGh4xYA++5DoeUVDXbmBlniPD7K4dSgJ58gsK0plrGx2vwWDoc3p+qQ7OoYbTBnu51O hxpAGp/4oFdJ87RestgxHaKkKVANIhJcAVQAehFt6WMRO699ff6tWvGvnY/iPCinGqZMMDeO8vLtD myXzg1nQC8zCiuHPopOj29WsbJns8BG8cuQiheJZLcM/WEY1rMK4ivLmpqhz7GPEG5ZD4JgkNXIBX 9xNM8YwJK6L+dQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXOhz-00035L-HY; Wed, 01 Mar 2023 10:49:35 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <878rgjkxnw.fsf@gnu.org> <87y1oijejb.fsf@gmail.com> Date: Wed, 01 Mar 2023 16:49:33 +0100 In-Reply-To: <87y1oijejb.fsf@gmail.com> (Simon Tournier's message of "Tue, 28 Feb 2023 11:00:08 +0100") Message-ID: <87pm9sbhf6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677685821; a=rsa-sha256; cv=none; b=lke1QS1+Z0l7mfq+AU0LSKpJvHM5oagEfHNpaecuKkXbhfLKJDjO6Oup8m+jbN4T4okSmo ranx/p1gYKPYUuWaoBQrpPS5GWc6H1q1dQelc1IF0mY0by99yC13A7z0x9I82kQirRnoRP fP2vLGiiDSi2s3382zc/JPkmhj7mQu37aB8kJj3+wuPKWAf5eugj6IdpBjBLYCh55UF3+z 350EijkBbar4fAk7FzGDJWKTrtyBU5HuB6Qpx3/yJDcstdCeTBKjsjwyP0XGYC7qi7HCVG BQe/OMpyAQqwIa7WnNFzyFtcvDrx7NbwPZVk32fAEvqXEFvLwAP13edGPFJRdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Nz51uhQk; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677685821; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gy4Zib3CQWq/Yc7RYgBI8RN7QCcqriAeY303tdWeR7g=; b=b7Nk/gM0RvHeBWMeJb8YNiOBWCbLu5vABHYvThZas2kblk+e2FUUTe/AJkZzndSkpDlvw1 ByqeGvVs6Y5d5CKx0sGHNdTOq25FhAd9+qJQ3fodX0FarBNeia60INFD+RuW47hBNek0Tf NDNttdbZev07BLRSHOkx+XyvppbSR1Ypi63uov/mTAZyP3fSRfPjU9VqSGW/RIjtBcsUWW +BUMx5O4Xgq79XYq7T4JGgecSANQS7sUySJ2xcZYJ1a+GP/DOZkULerVAG6T9uNtyPt0Un a7WV9R5c3fWhclUwRKOTWSJaLe2ikAUuweGvkWr0W0e9/YbjTuMrEKmlJoZ2qg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.59 X-Spam-Score: -2.59 X-Migadu-Queue-Id: 78FD0BD23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Nz51uhQk; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: QgyP/VDlgmzj Hi, Simon Tournier skribis: > 1. From my point of view, the transformations are functions that you > compose. The composition rule is not commutative maybe neither > associative. Writing down how each function (transformation) > composes with the others allows to specify the composition rules. > > 2. All the code in (guix transformations) acts at the package level, so > I am still missing why it would not be possible to detect some > issues there. Please check out =E2=80=98package-input-rewriting=E2=80=99 and its behavior with #:deep? #t. Design discussion: . > 1. it would not be possible to check if the transforms compose well; > somehow verify the assumption. Try it. :-) I tried to explain it multiple times, I really did, but I guess there=E2=80=99s no substitute to first-hand experience. > For instance, =E2=80=99package-with-upstream-version=E2=80=99 raises many= warnings > depending on various cases, and I miss why, > > 2. it would not be possible to have similar warnings for other > transformations. =E2=80=98package-with-upstream-version=E2=80=99 raises warnings that depend= exclusively on local knowledge. Here we=E2=80=99re talking about warnings related to the composition to two different options which, like you wrote, are independent functions. It=E2=80=99s not similar. HTH! Ludo=E2=80=99.