bug#62335: Exception when showing version-control packages

bug#62335: Exception when showing version-control packages

[Greg Hogan]

I have not installed the guix package so I believe that I am running
an unmodified Guix. Testing on my manifest, only packages from
version-control.scm (cvs, diffstat, git, subversion, ...) are
generating the exception.

--8<---------------cut here---------------start------------->8---
$ guix describe
Generation 38 Mar 21 2023 13:38:52 (current)
  guix 38b64d4
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 38b64d47ed3dfaeb63b859e7a8834e477ffed3a1
--8<---------------cut here---------------end--------------->8---

--8<---------------cut here---------------start------------->8---
$ guix show hello
name: hello
version: 2.12.1
outputs:
+ out: everything
systems: x86_64-linux i686-linux
dependencies:
location: gnu/packages/base.scm:87:2
homepage: https://www.gnu.org/software/hello/
license: GPL 3+
synopsis: Hello, GNU world: An example GNU package
description: GNU Hello prints the message "Hello, world!" and then
exits.  It serves as an example of standard GNU coding practices.  As
such, it supports command-line arguments, multiple
+ languages, and so on.
--8<---------------cut here---------------end--------------->8---

--8<---------------cut here---------------start------------->8---
$ guix show git
Backtrace:
In ice-9/boot-9.scm:
  3424:24 19 (_)
   222:29 18 (map1 _)
   222:29 17 (map1 _)
   222:29 16 (map1 _)
   222:29 15 (map1 _)
   222:29 14 (map1 _)
   222:29 13 (map1 _)
   222:29 12 (map1 _)
   222:29 11 (map1 _)
   222:17 10 (map1 (((gnu packages python-xyz)) ((gnu packages #)) …))
  3327:17  9 (resolve-interface (gnu packages python-xyz) #:select _ …)
In ice-9/threads.scm:
    390:8  8 (_ _)
In ice-9/boot-9.scm:
  3253:13  7 (_)
In ice-9/threads.scm:
    390:8  6 (_ _)
In ice-9/boot-9.scm:
  3544:20  5 (_)
   2836:4  4 (save-module-excursion _)
  3564:26  3 (_)
In unknown file:
           2 (primitive-load-path "gnu/packages/python-xyz" #<proced…>)
In gnu/packages/python-xyz.scm:
 24360:42  1 (_)
In ice-9/boot-9.scm:
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
error: pre-commit: unbound variable
--8<---------------cut here---------------end--------------->8---

bug#62335: Exception when showing version-control packages

[Josselin Poiret via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

Hi Greg,

Greg Hogan <code@greghogan.com> writes:

> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> error: pre-commit: unbound variable

This is caused by yet another import cycle: pre-commit is defined in
version-control.scm, which uses python-xyz, which defines
python-jupytext and which has pre-commit among its native-inputs, which
is thus not yet defined (if you tried loading version-control.scm
first).

I think the fix would be to move pre-commit to python-xyz?  These import
cycles are getting a bit out of hand, especially since we never catch
them during development...  Can we also turn unbound variable warnings
into errors, so that `guix pull` could catch them earlier?

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

bug#62335: Exception when showing version-control packages

[Josselin Poiret via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Hi Greg,

Greg Hogan <code@greghogan.com> writes:
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> error: pre-commit: unbound variable

This should be fixed now by Maxim with
5174820753be045ba4fc7cc93da33f4e0b730bc3.

Closing, feel free to re-open if it is not the case.

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]