* [bug#62156] [PATCH 0/1] gnu: Add atftp.
@ 2023-03-13 4:41 Felix Lechner via Guix-patches via
2023-03-13 4:42 ` [bug#62156] [PATCH 1/1] " Felix Lechner via Guix-patches via
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Felix Lechner via Guix-patches via @ 2023-03-13 4:41 UTC (permalink / raw)
To: 62156; +Cc: Felix Lechner
Hi,
I am not sure whether the mirror:// URL is right. It works, but there are two
lint warnings:
gnu/packages/networking.scm:2946:15: atftp@0.8.0: URI https://www.gnu.org/software/atftp/ not reachable: 404 ("Not Found")
gnu/packages/networking.scm:2921:12: atftp@0.8.0: source not archived on Software Heritage and missing from the Disarchive database
Kind regards,
Felix Lechner
* * *
Felix Lechner (1):
gnu: Add atftp.
gnu/packages/networking.scm | 41 +++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
base-commit: 9584b1daa687d1212550841d1c5f62e7ffa44ffc
--
2.39.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#62156] [PATCH 1/1] gnu: Add atftp.
2023-03-13 4:41 [bug#62156] [PATCH 0/1] gnu: Add atftp Felix Lechner via Guix-patches via
@ 2023-03-13 4:42 ` Felix Lechner via Guix-patches via
2023-03-19 23:03 ` [bug#62156] [PATCH v2] " Felix Lechner via Guix-patches via
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Felix Lechner via Guix-patches via @ 2023-03-13 4:42 UTC (permalink / raw)
To: 62156; +Cc: Felix Lechner
* gnu/packages/networking.scm (atftp): New variable.
---
gnu/packages/networking.scm | 41 +++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index b6cbd8e80a..bae7848632 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2914,6 +2914,47 @@ (define-public speedtest-cli
speedtest.net.")
(license license:asl2.0)))
+(define-public atftp
+ (package
+ (name "atftp")
+ (version "0.8.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/" name "/"
+ name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "05pk6x70wsad1fjnx4l2a7f859dn5ifqwng582mrw3v7qy4s0anz"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'autoreconf
+ (lambda _
+ (invoke "autoreconf" "-vif"))))))
+ (native-inputs
+ (list autoconf
+ automake
+ perl
+ pkg-config))
+ (inputs (list
+ pcre2
+ procps
+ readline
+ tcp-wrappers))
+ (home-page "https://www.gnu.org/software/atftp/")
+ (synopsis "Advanced TFTP server and client")
+ (description
+ "Multi-threaded TFTP server that implements all options, including all
+extensions, as specified in RFC 1350, RFC 2090, RFC 2347, RFC 2348, RFC 2349
+and RFC7440. Atftpd also supports a multicast protocol known as mtftp, which
+was defined in the PXE specification.
+
+The server is socket activated by default but supports being started from
+inetd(8) as well as in daemon mode.")
+ (license license:gpl2)))
+
(define-public tftp-hpa
(package
(name "tftp-hpa")
--
2.39.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#62156] [PATCH v2] gnu: Add atftp.
2023-03-13 4:41 [bug#62156] [PATCH 0/1] gnu: Add atftp Felix Lechner via Guix-patches via
2023-03-13 4:42 ` [bug#62156] [PATCH 1/1] " Felix Lechner via Guix-patches via
@ 2023-03-19 23:03 ` Felix Lechner via Guix-patches via
2023-03-20 7:34 ` Sergey Trofimov
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Felix Lechner via Guix-patches via @ 2023-03-19 23:03 UTC (permalink / raw)
To: 62156; +Cc: Felix Lechner
* gnu/packages/networking.scm (atftp): New variable.
The new URL still produces a lint warning. A user on IRC surmised that
sf.net may filter by user agent:
atftp@0.8.0: URI https://git.code.sf.net/p/atftp/code not reachable:
404 ("Not Found")
The same user states that Git makes this request:
GET /p/atftp/code/info/refs?service=git-upload-pack HTTP/1.1
Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
reviews of this item!
---
gnu/packages/networking.scm | 43 +++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 3fac05c411..7f843214fb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2916,6 +2916,49 @@ (define-public speedtest-cli
speedtest.net.")
(license license:asl2.0)))
+(define-public atftp
+ (package
+ (name "atftp")
+ (version "0.8.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.code.sf.net/p/atftp/code")
+ (commit (string-append "v" version))))
+ (sha256
+ (base32 "019qrh2wpvr577ksvs3s82q6kiqm5i6869aj7qba326b59lhkxrc"))
+ (file-name (git-file-name name version))))
+ (build-system gnu-build-system)
+ (arguments
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'autoreconf
+ (lambda _
+ (invoke "autoreconf" "-vif"))))))
+ (native-inputs
+ (list autoconf
+ automake
+ perl
+ pkg-config))
+ (inputs
+ (list pcre2
+ procps
+ readline
+ tcp-wrappers))
+ (home-page "https://sourceforge.net/projects/atftp/")
+ (synopsis "Advanced TFTP server and client")
+ (description
+ "Multi-threaded TFTP server that implements all options, including all
+extensions, as specified in RFC 1350, RFC 2090, RFC 2347, RFC 2348, RFC 2349
+and RFC7440. Atftpd also supports a multicast protocol known as mtftp, which
+was defined in the PXE specification.
+
+The server is socket activated by default but supports being started from
+inetd(8) as well as in daemon mode.")
+ (license license:gpl2+)))
+
(define-public tftp-hpa
(package
(name "tftp-hpa")
base-commit: f9702aa9fdfded5c62da43197f8cea5eeba30803
--
2.39.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#62156] [PATCH v2] gnu: Add atftp.
2023-03-13 4:41 [bug#62156] [PATCH 0/1] gnu: Add atftp Felix Lechner via Guix-patches via
2023-03-13 4:42 ` [bug#62156] [PATCH 1/1] " Felix Lechner via Guix-patches via
2023-03-19 23:03 ` [bug#62156] [PATCH v2] " Felix Lechner via Guix-patches via
@ 2023-03-20 7:34 ` Sergey Trofimov
2023-03-20 16:57 ` [bug#62156] [PATCH v3 1/2] " Felix Lechner via Guix-patches via
2023-03-21 4:25 ` [bug#62156] [PATCH v4 1/2] gnu: Add atftp Felix Lechner via Guix-patches via
4 siblings, 0 replies; 9+ messages in thread
From: Sergey Trofimov @ 2023-03-20 7:34 UTC (permalink / raw)
To: 62156; +Cc: felix.lechner
Hi, I've checked that the package builds fine on my machine.
Also you might want to fix the linter, so that it appends
`info/refs` to the git-reference url.
See here:
https://git.savannah.gnu.org/cgit/guix.git/tree/guix/lint.scm?h=1f36534c7e8f2325bff4df5d37ecc811dc63fc38#n1227
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#62156] [PATCH v3 1/2] gnu: Add atftp.
2023-03-13 4:41 [bug#62156] [PATCH 0/1] gnu: Add atftp Felix Lechner via Guix-patches via
` (2 preceding siblings ...)
2023-03-20 7:34 ` Sergey Trofimov
@ 2023-03-20 16:57 ` Felix Lechner via Guix-patches via
2023-03-20 16:57 ` [bug#62156] [PATCH v3 2/2] lint: Append "/info/refs" to git-reference-url Felix Lechner via Guix-patches via
2023-03-21 4:25 ` [bug#62156] [PATCH v4 1/2] gnu: Add atftp Felix Lechner via Guix-patches via
4 siblings, 1 reply; 9+ messages in thread
From: Felix Lechner via Guix-patches via @ 2023-03-20 16:57 UTC (permalink / raw)
To: 62156; +Cc: Sergey Trofimov, Felix Lechner
* gnu/packages/networking.scm (atftp): New variable.
Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
reviews of this item!
---
gnu/packages/networking.scm | 43 +++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 3fac05c411..7f843214fb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2916,6 +2916,49 @@ (define-public speedtest-cli
speedtest.net.")
(license license:asl2.0)))
+(define-public atftp
+ (package
+ (name "atftp")
+ (version "0.8.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.code.sf.net/p/atftp/code")
+ (commit (string-append "v" version))))
+ (sha256
+ (base32 "019qrh2wpvr577ksvs3s82q6kiqm5i6869aj7qba326b59lhkxrc"))
+ (file-name (git-file-name name version))))
+ (build-system gnu-build-system)
+ (arguments
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'autoreconf
+ (lambda _
+ (invoke "autoreconf" "-vif"))))))
+ (native-inputs
+ (list autoconf
+ automake
+ perl
+ pkg-config))
+ (inputs
+ (list pcre2
+ procps
+ readline
+ tcp-wrappers))
+ (home-page "https://sourceforge.net/projects/atftp/")
+ (synopsis "Advanced TFTP server and client")
+ (description
+ "Multi-threaded TFTP server that implements all options, including all
+extensions, as specified in RFC 1350, RFC 2090, RFC 2347, RFC 2348, RFC 2349
+and RFC7440. Atftpd also supports a multicast protocol known as mtftp, which
+was defined in the PXE specification.
+
+The server is socket activated by default but supports being started from
+inetd(8) as well as in daemon mode.")
+ (license license:gpl2+)))
+
(define-public tftp-hpa
(package
(name "tftp-hpa")
base-commit: f9702aa9fdfded5c62da43197f8cea5eeba30803
--
2.39.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#62156] [PATCH v3 2/2] lint: Append "/info/refs" to git-reference-url.
2023-03-20 16:57 ` [bug#62156] [PATCH v3 1/2] " Felix Lechner via Guix-patches via
@ 2023-03-20 16:57 ` Felix Lechner via Guix-patches via
0 siblings, 0 replies; 9+ messages in thread
From: Felix Lechner via Guix-patches via @ 2023-03-20 16:57 UTC (permalink / raw)
To: 62156; +Cc: Sergey Trofimov, Felix Lechner
For the atftp package added in the preceeding commit, lint produced this
warning:
gnu/packages/networking.scm:2924:5: atftp@0.8.0:
URI https://git.code.sf.net/p/atftp/code not reachable:
404 ("Not Found")
Thanks to Sergey Trofimov for suggesting a fix! [1]
[1] https://issues.guix.gnu.org/62156#3
It was implemented here, and the warning disappeared.
* guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.
Co-authored-by: Sergey Trofimov <sarg@sarg.org.ru>
---
guix/lint.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/guix/lint.scm b/guix/lint.scm
index a1a27873d9..394d68c472 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1224,7 +1224,9 @@ (define (warnings-for-uris uris)
'())))
((git-reference? (origin-uri origin))
(warnings-for-uris
- (list (string->uri (git-reference-url (origin-uri origin))))))
+ (list (string->uri (string-append
+ (git-reference-url (origin-uri origin))
+ "/info/refs")))))
((or (svn-reference? (origin-uri origin))
(svn-multi-reference? (origin-uri origin)))
(let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))
--
2.39.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#62156] [PATCH v4 1/2] gnu: Add atftp.
2023-03-13 4:41 [bug#62156] [PATCH 0/1] gnu: Add atftp Felix Lechner via Guix-patches via
` (3 preceding siblings ...)
2023-03-20 16:57 ` [bug#62156] [PATCH v3 1/2] " Felix Lechner via Guix-patches via
@ 2023-03-21 4:25 ` Felix Lechner via Guix-patches via
2023-03-21 4:25 ` [bug#62156] [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url Felix Lechner via Guix-patches via
2023-03-27 16:49 ` bug#62156: [PATCH 0/1] gnu: Add atftp Ludovic Courtès
4 siblings, 2 replies; 9+ messages in thread
From: Felix Lechner via Guix-patches via @ 2023-03-21 4:25 UTC (permalink / raw)
To: 62156; +Cc: Sergey Trofimov, Felix Lechner
* gnu/packages/networking.scm (atftp): New variable.
Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
reviews of this item!
---
gnu/packages/networking.scm | 43 +++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 3fac05c411..7f843214fb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2916,6 +2916,49 @@ (define-public speedtest-cli
speedtest.net.")
(license license:asl2.0)))
+(define-public atftp
+ (package
+ (name "atftp")
+ (version "0.8.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.code.sf.net/p/atftp/code")
+ (commit (string-append "v" version))))
+ (sha256
+ (base32 "019qrh2wpvr577ksvs3s82q6kiqm5i6869aj7qba326b59lhkxrc"))
+ (file-name (git-file-name name version))))
+ (build-system gnu-build-system)
+ (arguments
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'autoreconf
+ (lambda _
+ (invoke "autoreconf" "-vif"))))))
+ (native-inputs
+ (list autoconf
+ automake
+ perl
+ pkg-config))
+ (inputs
+ (list pcre2
+ procps
+ readline
+ tcp-wrappers))
+ (home-page "https://sourceforge.net/projects/atftp/")
+ (synopsis "Advanced TFTP server and client")
+ (description
+ "Multi-threaded TFTP server that implements all options, including all
+extensions, as specified in RFC 1350, RFC 2090, RFC 2347, RFC 2348, RFC 2349
+and RFC7440. Atftpd also supports a multicast protocol known as mtftp, which
+was defined in the PXE specification.
+
+The server is socket activated by default but supports being started from
+inetd(8) as well as in daemon mode.")
+ (license license:gpl2+)))
+
(define-public tftp-hpa
(package
(name "tftp-hpa")
base-commit: f9702aa9fdfded5c62da43197f8cea5eeba30803
--
2.39.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#62156] [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url.
2023-03-21 4:25 ` [bug#62156] [PATCH v4 1/2] gnu: Add atftp Felix Lechner via Guix-patches via
@ 2023-03-21 4:25 ` Felix Lechner via Guix-patches via
2023-03-27 16:49 ` bug#62156: [PATCH 0/1] gnu: Add atftp Ludovic Courtès
1 sibling, 0 replies; 9+ messages in thread
From: Felix Lechner via Guix-patches via @ 2023-03-21 4:25 UTC (permalink / raw)
To: 62156; +Cc: Sergey Trofimov, Felix Lechner
For the atftp package added in the preceeding commit, lint produced this
warning:
gnu/packages/networking.scm:2924:5: atftp@0.8.0:
URI https://git.code.sf.net/p/atftp/code not reachable:
404 ("Not Found")
Thanks to Sergey Trofimov for suggesting a fix! [1]
[1] https://issues.guix.gnu.org/62156#3
It was implemented here, and the warning disappeared.
* guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.
Co-authored-by: Sergey Trofimov <sarg@sarg.org.ru>
---
guix/lint.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/guix/lint.scm b/guix/lint.scm
index a1a27873d9..8d0887739d 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1224,7 +1224,14 @@ (define (warnings-for-uris uris)
'())))
((git-reference? (origin-uri origin))
(warnings-for-uris
- (list (string->uri (git-reference-url (origin-uri origin))))))
+ ;; for atftp, lint produced a warning:
+ ;; gnu/packages/networking.scm:2924:5: atftp@0.8.0:
+ ;; URI https://git.code.sf.net/p/atftp/code not reachable:
+ ;; 404 ("Not Found")
+ ;; fix from here: https://issues.guix.gnu.org/62156#3
+ (list (string->uri (string-append
+ (git-reference-url (origin-uri origin))
+ "/info/refs")))))
((or (svn-reference? (origin-uri origin))
(svn-multi-reference? (origin-uri origin)))
(let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))
--
2.39.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#62156: [PATCH 0/1] gnu: Add atftp.
2023-03-21 4:25 ` [bug#62156] [PATCH v4 1/2] gnu: Add atftp Felix Lechner via Guix-patches via
2023-03-21 4:25 ` [bug#62156] [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url Felix Lechner via Guix-patches via
@ 2023-03-27 16:49 ` Ludovic Courtès
1 sibling, 0 replies; 9+ messages in thread
From: Ludovic Courtès @ 2023-03-27 16:49 UTC (permalink / raw)
To: Felix Lechner; +Cc: Sergey Trofimov, 62156-done
Hi,
Felix Lechner <felix.lechner@lease-up.com> skribis:
> * gnu/packages/networking.scm (atftp): New variable.
>
> Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
> reviews of this item!
I tweaked the description (to start with a full sentence) and passed it
through ‘guix style’.
> For the atftp package added in the preceeding commit, lint produced this
> warning:
>
> gnu/packages/networking.scm:2924:5: atftp@0.8.0:
> URI https://git.code.sf.net/p/atftp/code not reachable:
> 404 ("Not Found")
>
> Thanks to Sergey Trofimov for suggesting a fix! [1]
>
> [1] https://issues.guix.gnu.org/62156#3
>
> It was implemented here, and the warning disappeared.
>
> * guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.
>
> Co-authored-by: Sergey Trofimov <sarg@sarg.org.ru>
Nice. I adjusted ‘tests/lint.scm’ accordingly.
Applied both; thank you, and thanks to the reviewers!
Ludo’.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-03-27 16:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-13 4:41 [bug#62156] [PATCH 0/1] gnu: Add atftp Felix Lechner via Guix-patches via
2023-03-13 4:42 ` [bug#62156] [PATCH 1/1] " Felix Lechner via Guix-patches via
2023-03-19 23:03 ` [bug#62156] [PATCH v2] " Felix Lechner via Guix-patches via
2023-03-20 7:34 ` Sergey Trofimov
2023-03-20 16:57 ` [bug#62156] [PATCH v3 1/2] " Felix Lechner via Guix-patches via
2023-03-20 16:57 ` [bug#62156] [PATCH v3 2/2] lint: Append "/info/refs" to git-reference-url Felix Lechner via Guix-patches via
2023-03-21 4:25 ` [bug#62156] [PATCH v4 1/2] gnu: Add atftp Felix Lechner via Guix-patches via
2023-03-21 4:25 ` [bug#62156] [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url Felix Lechner via Guix-patches via
2023-03-27 16:49 ` bug#62156: [PATCH 0/1] gnu: Add atftp Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.