From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6KX7JRjsZmR4FgEASxT56A (envelope-from ) for ; Fri, 19 May 2023 05:25:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eB7kJRjsZmRiaAEA9RJhRA (envelope-from ) for ; Fri, 19 May 2023 05:25:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 27E323FC39 for ; Fri, 19 May 2023 05:25:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzqjF-00045v-Je; Thu, 18 May 2023 23:24:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzqjE-00045e-Gf for guix-devel@gnu.org; Thu, 18 May 2023 23:24:28 -0400 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzqjC-0006ZK-Ux for guix-devel@gnu.org; Thu, 18 May 2023 23:24:28 -0400 Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-6238417112aso11969356d6.2 for ; Thu, 18 May 2023 20:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684466665; x=1687058665; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=SPm+t9SZ4ESa6nkZcvQga2BsFBeeof0tIo3/jkd/6WY=; b=mrELD/G8FQiJwVMuRGczu+IADrSt8lYRoZSuFbAWcDvDPzn8aGX/52XqVtfP2b2qVB qUT9DiOscqPOKwMi0dw1XvHeVJu8XeJItrXqb5qnWUEBcWK8l97tWVmK2kneJUSb37iz mKv6sQf2i9RpnjbMAKfPRouNI3TbjhJsxBvf5I867swihz/EiT8HYiR8qvk2fLYZHG21 KUlB7AqAnA/UCcYarK4cHOSCQ8tgfzmLVHVGKYLIkyxfTDFjSZJgafWp/GVaUgdYjLE0 xe71OnFOhHbzz+oRyA+rfklsnMcbABdB+4Tyy4kQU6IZRFWvlJAY51pRWnqe+Z7BrRoA xTKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684466665; x=1687058665; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SPm+t9SZ4ESa6nkZcvQga2BsFBeeof0tIo3/jkd/6WY=; b=IOzpdzpDcGAIbRRY42QV+7sffvzSBnPi8Dj/JufOl6513UuPzbKJ29pMrpad1qTy74 4yo89ApmDxJMwgMm4Qx1Qm2Zgzd8JKYy1tp7LdtgC1hT+2jpiMWpwogZ47YDrJ/Jfiz0 5612g8A3cdcjEqto3rdMqaiTkgUdEeMCX8jY1dNnCHsgKXrPNQQ0yABlrIl3MDQ4UJFi IiyorMheVJyqRgR+77CgnGlgZc13th3/Ey/A6Urv6to4/ZBaF718yGHOv0y4end4p55a qm6uUuWLsT8+YDHU+cHTUKHKO6yUbPjxN4MDeEF+UYiDH2XdiHMa15ZBxRAJomKT7Zkn SE7A== X-Gm-Message-State: AC+VfDwffEXAsZvaQdU6Tj//7qJcwG+I/l/XC35cBoOSwEWH7W9cSb+E fJlGmcIZzWq/orqgGITDqy/04OtzhK9mBw== X-Google-Smtp-Source: ACHHUZ47/BdC8Zn+LBQWMt7tTeZAOMb8mZ946tvZ8GCpV9aLkAC5LEvuFDyXvVeBQlw5yQD9QCHDoA== X-Received: by 2002:ad4:5ced:0:b0:5ef:5138:1e5d with SMTP id iv13-20020ad45ced000000b005ef51381e5dmr2204044qvb.49.1684466665585; Thu, 18 May 2023 20:24:25 -0700 (PDT) Received: from hurd (dsl-150-33.b2b2c.ca. [66.158.150.33]) by smtp.gmail.com with ESMTPSA id er10-20020a056214190a00b0061b6d792ec2sm992975qvb.113.2023.05.18.20.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 20:24:25 -0700 (PDT) From: Maxim Cournoyer To: Leo Famulari Cc: guix-devel@gnu.org Subject: Re: Should commit signing always be required for local work? [was Re: bug#63261: Recent changes to git config cause errors for non-committers] References: <874jospdr2.fsf@psyduck.jhoto.kublai.com> <87y1m024rx.fsf@gmail.com> <875y8tww86.fsf@gmail.com> Date: Thu, 18 May 2023 23:24:23 -0400 In-Reply-To: (Leo Famulari's message of "Thu, 18 May 2023 12:59:22 -0400") Message-ID: <87pm6xknq0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f2e; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684466712; a=rsa-sha256; cv=none; b=QbRqvnJWl9R5b5ec2sMRO50tvSaumxiL1s85Gaqr9tIor8+MInfCfZwdBrL90u/TA6VMWH H6qa37lvcImPS/fZNism61e7ImLD49kAW2j/r3eegHjgmYneJ6h8RckiLIcjlvjlEwasiT oEgaVirH8pF8+RBGRgB1NqLUNhztaCB7YACBNwKIcTiQUSncFcGN4RQKt1MYc/Z+KR20tS QjKOFj6v0QS4xMw3KXxIaixt5cMhD9ibWvDAkDqDn5KTjNM6NnMJMjVOXzCSHzFMLUuH21 YS/HRbWSn0RKvTsvQSLM9N3fwfKN56HF4ic5UBRzTlYzQmdiCW5fNYsyt5PqpQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="mrELD/G8"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684466712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SPm+t9SZ4ESa6nkZcvQga2BsFBeeof0tIo3/jkd/6WY=; b=M4oqGuorywazARwj+4qW1ATfDfEwPBCQ6dhKmi5PutqLmS4vxk0p6qz1lbd65zAxcKMLm3 GJBIJnupch1lketw3D+Kjaz/cFtuIxZLVyP/aMGCDZNkP1fDDsjPGit09qQKKgaenz3PiF u5i9wenmDOvNWUMM34RzYE+Cs+kzRez2VEosaUywqK757m8DDIe4qRR6HOKGopbhmOvBXM YZVe3vjeIpyhEWPC5rWVrB+8fy+JVFU357WJaL6eZtV4H+VBACL263PMOtEJqfqTRv/IfE k1UecmZxY0a21GGbVxQSQPzfrZiqkEC5eRjo4KEZ0s5y1NAJg/z8rMYAr9uUKg== X-Migadu-Spam-Score: -3.28 X-Spam-Score: -3.28 X-Migadu-Queue-Id: 27E323FC39 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="mrELD/G8"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-TUID: YUz0ESuFa2NE Hi Leo, Leo Famulari writes: > On Mon, May 15, 2023 at 09:38:33AM -0400, Maxim Cournoyer wrote: >> Hi Leo, >> >> Leo Famulari writes: >> >> > Can someone help me by pointing to the original discussion of this >> > change? >> >> It was the team.scm issue in https://issues.guix.gnu.org/58813 that led >> to this change. > > Thanks for pointing it out. > > In my opinion, this change should be discussed more publicly so that a > consensus can be reached about it. > > This change affects the workflow of everyone that hacks on Guix, > including people who are trying it for the very first time. > > It's a big change. > > It's not okay to only discuss such a big change in a ticket with the > title "can't substitute etc/teams.scm command as doc suggests". > > I am asking for this to be reverted until a consensus is reached. Thanks for voicing your thoughts on this. I originally thought the included fragments (via the 'include.path' git config option) could we overridden by a user but it seems they can't, making the change more intrusive than it should have been. I've reverted just the offending bits: --8<---------------cut here---------------start------------->8--- diff --git a/etc/git/gitconfig b/etc/git/gitconfig index 831fbce6e7..907ad01804 100644 --- a/etc/git/gitconfig +++ b/etc/git/gitconfig @@ -1,6 +1,3 @@ -[commit] - gpgsign = true - [diff "scheme"] xfuncname = "^(\\(define.*)$" --8<---------------cut here---------------end--------------->8--- Let me know if something is amiss. -- Thanks, Maxim