From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8K0rJ8QsimR6UQAASxT56A (envelope-from ) for ; Wed, 14 Jun 2023 23:10:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WK8nJsQsimT/xwAAG6o9tA (envelope-from ) for ; Wed, 14 Jun 2023 23:10:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 66155AEC7 for ; Wed, 14 Jun 2023 23:10:28 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9Xkj-0000GD-SD; Wed, 14 Jun 2023 17:10:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Xkh-0000FB-HW for guix-patches@gnu.org; Wed, 14 Jun 2023 17:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9Xkh-00054m-8X for guix-patches@gnu.org; Wed, 14 Jun 2023 17:10:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9Xkh-0004rp-3Z for guix-patches@gnu.org; Wed, 14 Jun 2023 17:10:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63631] [PATCH] import: go: Handle subpackage versioning correctly. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Jun 2023 21:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63631 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timo Wilken Cc: 63647@debbugs.gnu.org, 63631@debbugs.gnu.org, Simon Tournier , 54097@debbugs.gnu.org, wolf@wolfsden.cz Received: via spool by 63631-submit@debbugs.gnu.org id=B63631.168677698718674 (code B ref 63631); Wed, 14 Jun 2023 21:10:03 +0000 Received: (at 63631) by debbugs.gnu.org; 14 Jun 2023 21:09:47 +0000 Received: from localhost ([127.0.0.1]:45550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9XkR-0004r1-6D for submit@debbugs.gnu.org; Wed, 14 Jun 2023 17:09:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9XkO-0004qY-TB; Wed, 14 Jun 2023 17:09:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9XkH-0004vN-UY; Wed, 14 Jun 2023 17:09:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=dSdA3DtXQsPoFBK1nu9YIiRoX1fKSVyF3CAiTtvJ3Ag=; b=CSYzUy1OF3nQO6NYSypv HM4AwqDmPv33nptVZL1fr7W5XOseD1w1xaNRsa2+4oU7CPI9nCPyU0pAw2znjTXABMLXtxUh7KB8g 3YvHHDk9o9kCOfw67oScqWX4OvzO6KbdbdBwgXuy2Y+n3MaIvUxg7t/cA5BPmD4GoA+JIiDKzpsZu FPXcPxB7WqzRONx0siODTV+zZXwuGnqo7sZudo+QUKX9PggRa2sbxDUfXm7w+bzXUNO61YVCZHVAw 5WmT8xUC+nNmZf0jDcT4lKabL2lgwg68LEi3RSZL64iwnfgPI4Y4TE4pOZUU2RqYhmklchuOcvk/K j36GpFdqYdnThA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9XkH-0001Z1-FY; Wed, 14 Jun 2023 17:09:37 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <6dd1de3dd4d968876fa55f5126056834c77b0244.1684703258.git.guix@twilken.net> Date: Wed, 14 Jun 2023 23:09:35 +0200 In-Reply-To: <6dd1de3dd4d968876fa55f5126056834c77b0244.1684703258.git.guix@twilken.net> (Timo Wilken's message of "Sun, 21 May 2023 23:18:08 +0200") Message-ID: <87pm5xrbsg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686777028; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dSdA3DtXQsPoFBK1nu9YIiRoX1fKSVyF3CAiTtvJ3Ag=; b=dK2FN7Ndi6DQzF4JxaBM/YIZpjuU3Y2/ZaxE5+WV9tjVgAexlvSxfQSgObSN/nyzRIPtLY jJwCaT170Yl9Yq1FN8PtanVdMgOjRikSuu1K+X5n4zC/tFICnqFFPkuGIOQ4lQFoGgWBtG WIicOXs594acaTk9yIhPXVr7PeM/b0PPNbYbxUCEZNEuNi2CUMet/67QjRiXWo6TQEvU4x JGWsoIfkYTgtKPK2wimxDLiojcJEF76sZXNxpKMcnTnPTqDvr11Vgl3aLsDwjSXaVvkaOV 7d5efjgjN9RxIBFClEv2OK/6kDD396f2oxf6mVNV256egQyZV45qE3yGJWLG6Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=CSYzUy1O; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686777028; a=rsa-sha256; cv=none; b=qytq9OLtTZqM9fap1HOuhD7R28FzoKpx/Slq3TejO5AZS4qOQzRLEjb8/7MA6AZDrlSuKa jRF550bUet3izjvL0lrTjLEf/Sr3OHQWmoSnrZy4J5Irfpe6/c/w/qx7SlcFZwdK9iVONh bP/yZBNdhI+tXMY7muqEy1/50srP/4ttEkxUSd6Bris3X1pzs8fE9C30z8c1j2GvxLwioN 46sBIZrpe1XAGYwJaJJOy56jH5UwKLge4xAs9XeVBHPj73TUxqIoLVgMxXzwhwpKV8Gua3 uKrY/i5eEOEJQrhx5bs3H0ijugUbZkYRvy9hH7mexD/9JnqVNkPbfTV1paTTew== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.63 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=CSYzUy1O; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 66155AEC7 X-Spam-Score: -2.63 X-TUID: 1RMGZ4U0esYp Hi Timo, Timo Wilken skribis: > Some Go source repositories (notably the Google Cloud SDK) contain multip= le > submodules and use a `refs/tags//' tagging scheme. > > Fixes . > > * guix/import/go.scm (vcs->origin): Accept a module-path-suffix. > (go-module->guix-package): Use the new parameter. > --- > Here's a patch that fixes the reported issue (bug#54097) for me. I've only > tested this on the github.com/googleapis/google-cloud-go/compute package = so > far, though it seems to work there. Perhaps others have more testcases? > > I don't know enough about Go tooling to use it, so I've just patched the = Guile > logic of the importer. (I don't write Go, I just want to package stuff wr= itten > in it.) In terms of performance, at least the repo contents are apparently > cached by the first `git-checkout-hash' call, even if it fails, so the se= cond > call doesn't have to redownload them. What you propose looks similar to part of the work Simon Tournier submitted at . What would you suggest? Simon? Thanks for the patch, Timo! Ludo=E2=80=99.