From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CH8XL3tmjGQ6aAAASxT56A (envelope-from ) for ; Fri, 16 Jun 2023 15:41:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WPjQLntmjGTKygAAauVa8A (envelope-from ) for ; Fri, 16 Jun 2023 15:41:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64BB822F8 for ; Fri, 16 Jun 2023 15:41:15 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qA9hM-0002s6-56; Fri, 16 Jun 2023 09:41:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qA9hG-0002rd-OJ for guix-patches@gnu.org; Fri, 16 Jun 2023 09:41:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qA9hG-0000N0-G7 for guix-patches@gnu.org; Fri, 16 Jun 2023 09:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qA9hG-0000wZ-1U for guix-patches@gnu.org; Fri, 16 Jun 2023 09:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63909] [PATCH] home: Add inputrc service. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Jun 2023 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: paren@disroot.org, 63909@debbugs.gnu.org, Andrew Tropin Received: via spool by 63909-submit@debbugs.gnu.org id=B63909.16869228203572 (code B ref 63909); Fri, 16 Jun 2023 13:41:02 +0000 Received: (at 63909) by debbugs.gnu.org; 16 Jun 2023 13:40:20 +0000 Received: from localhost ([127.0.0.1]:48798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA9ga-0000vX-B4 for submit@debbugs.gnu.org; Fri, 16 Jun 2023 09:40:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA9gY-0000vI-N9 for 63909@debbugs.gnu.org; Fri, 16 Jun 2023 09:40:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qA9gS-00007i-9Q; Fri, 16 Jun 2023 09:40:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=dIFzSKlYYgl1I6px9YA2U/xY+VZ8shfbocpFAyElgA4=; b=AZ6muGJ+hgY32ZoySv/s fD+YqydWE5Dzp1Uzypp9ejwpqCe/2D4FiNbzFs8Ye4nHtUhNhM0RMDJV8vBNOFv3KWa7PZNZkq1hT 1b4SjEN+80cl+1AxWzOi+HoIwWLb7e9Jf82iUUrCk6LS1Ehq3clDeySrZ9omduB1nfL+waor8y3z1 QVo0VMyKxyr5bXeSxp1culNjAA/FH2vbUoGfloqQdb4cG+5b9oaLhUFFUhYgb2zO6VLxHdYXmFMaB jXZ7JXM7FZ8JNzXpRx0tYz2kS3scuPBh0S2lQvBO2jFxMP6WV+bMVPpHAs7ph827aMdQN0qa1ViK/ 3FTooeHdogPctg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qA9gR-0004K9-RM; Fri, 16 Jun 2023 09:40:12 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <29f421343373bc3655abb9961f254880a295f6f7.1685967547.git.efraim@flashner.co.il> Date: Fri, 16 Jun 2023 15:40:09 +0200 In-Reply-To: <29f421343373bc3655abb9961f254880a295f6f7.1685967547.git.efraim@flashner.co.il> (Efraim Flashner's message of "Mon, 5 Jun 2023 15:19:24 +0300") Message-ID: <87pm5vseyu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686922875; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RR962M6q8gEdi5MyrNqGSOFQgmcukwpD0OaywoEEsS8=; b=TczOSyfHbcY0cx/4eAxOd9QeDfJAjGmiDUBuCQMihxu9u2Juul/xv87a/V+YJnILfA05EB Sbn12hSso4BDw7FSf8myt1H3056/1OJKTijLiJ15S5ztGayQ9ms9zHO20bWU70V94gpGii 1E+IeScG8jpuzlz9sxiVMjcYF75Xp9pJnhI6tLdPnnL8Ijnd+lL5UuLbf9SeJ/RsVBSqzs cayckRMlajLK4hwI/hHHQ/zL+8lwPzFkxxvmy/Zwl3hf1BHDxc9eczJIc9oVhutqwxmCno gM7FDbIO8YjL+2D6PHa7ZPXUcIRYMvktpxXWEH/QIgkCW1gJZCfzyZ7bhj9IXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=AZ6muGJ+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686922875; a=rsa-sha256; cv=none; b=Z/rQvvGh4cXNWm3DIHvn4kNo2W4B2bZcky7ec/SgDr0A1mlZLc4KosyqCyuz8Kwo+c7Eyj DDJziBxUWutXhRag4kTWdhR+UUmFRNdAXhnqq88wjt0IegVzuQ5JpqGzkFHvqT24rHWY5f /4/Z3ynp3Weeg6fI8UdEJfkD7NbZtagN1k9UVxUf1TdeFARwOfE7OZA3Y+lmLL8m9Hl9cU Pq1c+xTBg9aytg2Z9ht0jBUecESo2rSJ7OE1++I9Llfg2/rm9HYgUBaTcKhqrCGZn9yBi6 e4PTKtyXNEQVbzzfShUytfFFNW+d1Esl9yUdQkzXJubt3nGUc6dgMaWffMu8KQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.63 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=AZ6muGJ+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 64BB822F8 X-Spam-Score: -2.63 X-TUID: Giywa34PFZWb Hi! Efraim Flashner skribis: > * gnu/home/services/shells.scm (home-inputrc-service-type, > home-inputrc-configuration): New variables. > (serialize-inputrc-key-bindings, serialize-inputrc-variables, > serialize-inputrc-conditional-constructs, > serialize-inputrc-extra-content, generate-home-inputrc-documentation): > New procedures. Nice! I=E2=80=99d like Andrew and ( to chime in more often :-) but here=E2=80=99s= my take. > + > +;;; > +;;; Documentation. > +;;; >=20=20 > (define (generate-home-shell-profile-documentation) > (generate-documentation > @@ -662,3 +798,10 @@ (define (generate-home-fish-documentation) > `((home-fish-extension > ,home-fish-extension-fields)) > 'home-fish-extension))) > + > +(define (generate-home-inputrc-documentation) > + (string-append > + (generate-documentation > + `((home-inputrc-configuration > + ,home-inputrc-configuration-fields)) > + 'home-inputrc-configuration))) I don=E2=80=99t think we need to keep these procedures in the file. Overall it LGTM, except for one thing: could you add it to =E2=80=98doc/guix.texi=E2=80=99? (The usual template is: an intro giving c= ontext and a cross-reference to the upstream manual, one or two configuration examples with an explanation, and then the reference.) Thanks! Ludo=E2=80=99.