[bug#63909] [PATCH] home: Add inputrc service.

["Ludovic Courtès" <ludo@gnu.org>]

Hi!

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/home/services/shells.scm (home-inputrc-service-type,
> home-inputrc-configuration): New variables.
> (serialize-inputrc-key-bindings, serialize-inputrc-variables,
> serialize-inputrc-conditional-constructs,
> serialize-inputrc-extra-content, generate-home-inputrc-documentation):
> New procedures.

Nice!

I’d like Andrew and ( to chime in more often :-) but here’s my take.

> +\f
> +;;;
> +;;; Documentation.
> +;;;
>  
>  (define (generate-home-shell-profile-documentation)
>    (generate-documentation
> @@ -662,3 +798,10 @@ (define (generate-home-fish-documentation)
>      `((home-fish-extension
>         ,home-fish-extension-fields))
>      'home-fish-extension)))
> +
> +(define (generate-home-inputrc-documentation)
> +  (string-append
> +   (generate-documentation
> +    `((home-inputrc-configuration
> +       ,home-inputrc-configuration-fields))
> +    'home-inputrc-configuration)))

I don’t think we need to keep these procedures in the file.

Overall it LGTM, except for one thing: could you add it to
‘doc/guix.texi’?  (The usual template is: an intro giving context and a
cross-reference to the upstream manual, one or two configuration
examples with an explanation, and then the reference.)

Thanks!

Ludo’.