From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4KQzEP/ztmTsugAASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 22:20:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yG/+D//ztmQrSAEAauVa8A (envelope-from ) for ; Tue, 18 Jul 2023 22:20:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DDD9848D79 for ; Tue, 18 Jul 2023 22:20:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QPQhtKKe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689711615; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OZpXWXEmXspISrkrJ6O6M0sywcNEDIm1fFMMcEMiNxA=; b=kM1rlOKxzRXa9bQXgMnYzW6tV4QMtQqKwwNynDj1HxlviU2onqz58+J8rhHBvOoRWSbc9q N4kfi+jNFLpKMiPohV6pPOzLBPXkBWu5vp50X0K+srSdwUogWgkqd7e0/E4Iwl50Cguh+h di73uDWuYhTg/vU776r5JaCwQ3AixSCJOS9gIQpP6M1JnnNzg1BpbEzlRyipCqSp7/irbL Cf2or7F23e0CWClQRgY+Noh0eYn/U1lASOdhD7ADr+pC4K/RrKlCF8Z8Hk+vITqNLG3Cu/ QFYSUPtUGkOOycAkenH0x79Re/zTW6MegpfM6PfBnDEnsglkwW5dOp/EszNinw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QPQhtKKe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689711615; a=rsa-sha256; cv=none; b=k1rpRDDuYk8HYpylCeSKI40GcrQxMTCoNGzMyUbK1ykcr4WfolEhwJC6jBOj8OKULDz1ms s1E5euMPetqDvrzyzRl+DaHdEP6x9esNfmE1/LfTxAgScIaZ9YCXkQiIMXlj4q+d3XkRI7 J74M0U5TqRotegurq9Sc5WhxXClr03xe4thpixmqnOUsRIlANVk3YwCaNU0JBm8pmuZCIK 3SEpp7YDsF0Kdqn92n/2GnR/EKZBEQ6GuOB9adZvGLM13Wr72xSnxLZb/wSLadzpKOuDDf VQcuohqtZcDPDiP6otZCKlBDt+NlduADd4+7GEyHSZDqstQwDfMAFsrm73j8hQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLrAx-00016n-4a; Tue, 18 Jul 2023 16:20:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLrAw-00016W-3e for guix-patches@gnu.org; Tue, 18 Jul 2023 16:20:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLrAv-0004Tg-Qr for guix-patches@gnu.org; Tue, 18 Jul 2023 16:20:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLrAv-00047B-Mo for guix-patches@gnu.org; Tue, 18 Jul 2023 16:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 20:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: Josselin Poiret , 64711@debbugs.gnu.org Received: via spool by 64711-submit@debbugs.gnu.org id=B64711.168971154815744 (code B ref 64711); Tue, 18 Jul 2023 20:20:01 +0000 Received: (at 64711) by debbugs.gnu.org; 18 Jul 2023 20:19:08 +0000 Received: from localhost ([127.0.0.1]:54396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLrA4-00045r-HM for submit@debbugs.gnu.org; Tue, 18 Jul 2023 16:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLrA1-00045M-14 for 64711@debbugs.gnu.org; Tue, 18 Jul 2023 16:19:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr9v-0003VZ-Il; Tue, 18 Jul 2023 16:18:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=OZpXWXEmXspISrkrJ6O6M0sywcNEDIm1fFMMcEMiNxA=; b=QPQhtKKer7KLB0FBl/91 VOfgKzSkn3iq0DEWo6w8BZka7CMwL/an7rGBfn6YiuTP6rA4UA/UE8XnlsmJWUkQx/cZE6kXJyz5F hnlS9b4WEe5a0TnVw5ueIU1NGMZ90TzVROIk7mOooEHTpRnnBQ9LMdmnAdUBjHbHn8KWD9v7EePel ApWDOWHUXNsGGDomXfyDngkSEAWg2sJqnRpf1LjErxx0y/cU7pyvSUQT014wb38xihQKPfcJuAGpY 8Mvq2NEalnb3dUXt6U/s65x4G54NsZTP6xVCsLDZVNJF6i4PfMgEyFVzK0wPKdTCAd/0OfeE/PD2t wQEJbTv/HZC6Tw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr9v-0007wt-68; Tue, 18 Jul 2023 16:18:59 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <86a9ff0068ac21d4fa340f450f0835fa840111b2.1689690897.git.janneke@gnu.org> Date: Tue, 18 Jul 2023 22:18:56 +0200 In-Reply-To: <86a9ff0068ac21d4fa340f450f0835fa840111b2.1689690897.git.janneke@gnu.org> (Janneke Nieuwenhuizen's message of "Tue, 18 Jul 2023 16:39:55 +0200") Message-ID: <87pm4pgehb.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -5.35 X-Migadu-Queue-Id: DDD9848D79 X-Migadu-Spam-Score: -5.35 X-Migadu-Scanner: mx0.migadu.com X-TUID: Y9GNifEqPmd9 Hi, (+Cc: Josselin.) Janneke Nieuwenhuizen skribis: > * gnu/packages/guile.scm (guile-3.0)[arguments]: When building on the Hur= d, > add stage 'disable-popen.test-open-pipe' to avoid running the > open-input-pipe test (hangs) and open-output-pipe test (fails. [...] > + #~((add-after 'unpack 'disable-popen.test-no-duplicate > + ;; This test hangs on the Hurd. > + (lambda _ > + (substitute* "test-suite/tests/popen.test" > + (("\\(pass-if \"no duplicate\".*" all) > + (string-append all " (when (string-ci= =3D \"GNU\" (vector-ref (uname) 0)) (throw 'unresolved)) > +")))))) Maybe write: (string-append all (object->string '(when =E2=80=A6))) Out of curiosity, is there a bug report for this one? IIRC, the test suite of Guile 3.0.9 + =E2=80=98guile-hurd-posix-spawn.patch=E2=80=99 used = to pass on glibc 2.35. As discussed on IRC, skipping this test is not great in that it=E2=80=99ll likely come to haunt us. However, like you write, we can do that for now in the interest of making progress :-) and remove it with a proper fix once we have it. So=E2=80=A6 LGTM! Ludo=E2=80=99.