From: "André A. Gomes" <andremegafone@gmail.com>
To: Christopher Baines <mail@cbaines.net>
Cc: 66143@debbugs.gnu.org
Subject: [bug#66143] [PATCH]: Update emacs-slime and sbcl-slime-swank to 2.28-0.1e4b741
Date: Tue, 26 Sep 2023 12:16:05 +0300 [thread overview]
Message-ID: <87pm25l2ga.fsf@gmail.com> (raw)
In-Reply-To: <87il7y7efi.fsf@cbaines.net> (Christopher Baines's message of "Mon, 25 Sep 2023 11:01:13 +0100")
Christopher Baines <mail@cbaines.net> writes:
> It seems like you've attached two patches? It's useful to just send one
> patch per email, as lots of tooling expects that.
I'm more used to sending patches as email attachments, instead of using
git-send-email. If Guix requires the latter then I'll adjust, but I've
been sending plenty of patches following the former approach.
> Looking at the first patch though, packaging anything but the latest
> release shouldn't be the norm [1].
>
> 1: https://guix.gnu.org/manual/en/guix.html#index-version-number_002c-for-VCS-snapshots
>
> You need to put the reasoning for updating these packages to these
> specific commits in to some comments. Depending on that justification as
> well, we need to decide whether to ship these versions in addition to
> the latest releases, or as you're doing currently to replace the latest
> releases with these snapshots.
>
> What approach to take depends on the justification, e.g. if the latest
> release is unusable or using it could be problematic, then replacing it
> with a snapshot seems better, otherwise, we should create package
> variants (e.g. emacs-slime-next) for these snapshots.
It makes no sense to have emacs-slime-next and cl-slime-swank-next.
I've bumped it because significant changes have been introduced since
the last tagged released.
In the meantime, I've kindly request a tagged release upstream. Whether
I'll get a reply soon remains to be seen.
https://github.com/slime/slime/issues/792
With all respect to your work, Christopher Baines, I'd kindly suggest a
review by the Common Lisp team - Guillaume Le Vaillant, who has been
reviewing most of my patches lately.
Thanks!
--
André A. Gomes
"You cannot even find the ruins..."
next prev parent reply other threads:[~2023-09-26 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 20:51 [bug#66143] [PATCH]: Update emacs-slime and sbcl-slime-swank to 2.28-0.1e4b741 André A. Gomes
2023-09-25 10:01 ` Christopher Baines
2023-09-26 9:16 ` André A. Gomes [this message]
2023-09-28 10:19 ` André A. Gomes
2023-10-20 19:46 ` André A. Gomes
2023-10-22 11:51 ` Guillaume Le Vaillant
2023-10-24 7:31 ` André A. Gomes
2023-10-24 12:40 ` bug#66143: " Guillaume Le Vaillant
2023-10-24 13:08 ` [bug#66143] " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm25l2ga.fsf@gmail.com \
--to=andremegafone@gmail.com \
--cc=66143@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.