From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id AFk6IT+M9WWNDwEA62LTzQ:P1 (envelope-from ) for ; Sat, 16 Mar 2024 13:10:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id AFk6IT+M9WWNDwEA62LTzQ (envelope-from ) for ; Sat, 16 Mar 2024 13:10:39 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710591038; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=NATzXEJmKGcPTetFd7UqFf5T+xXA2AFxNe9ESKSzwE4=; b=kb6HOi1XhyXS8JyDMEt20oFpFH9xnAyff2a5A3H/+H8zzpUdO3liS1bY/vFo4cXHv7AgPM yG9tjNB8Fw3QDnJ82pOi5xmVau0WrMHwKFm/vqw1N7TWm11zo4syZOhtRXBZzKCbYCqeqh HB2YbZPUre1YEqouit+YnVZRiGB7JgyKIkMVEYMBlRFGLj3VdzfIA30+Sa5kJ1lIMjovue /N4wVQY3LA8jf0cD9nnwACffr56pRSquftlZ3OulIRYorj2/BTr03GC7BVqQFSu6bkylm9 84GxGJTcb73y204RlAZ6Ru4WX52b1NUkhfmzwD9G0RghTF56MwrY79qfZN998Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710591038; a=rsa-sha256; cv=none; b=MHx1V0fD5TBQvprf2XaTGUcH1gF+TTNH/ZuaJSNyJtUgrNKjDuIqWMGWmVPPnQDR0icOOk LxRUZeSiAJ/ZCQbZpfF4jvk6DP5cVwN9UotwDceaJgT+qxZbL2QTaWnRPzPkXhE68T1W1M 2uo6vMjZ7KVMr9q3uo/236yUUBz97MB2xk+pd8L2qTmB9lAFRGoYjrAD3/TxffKsg9NQvC s79tRNojmzIUZyPbgUlCpaMOf7Y5UneILSR636Cus7W9RT/RjmO0OOhUcioeERY6cq4rbb XMj/HaUPsBuV9U3RBGjSZRNRb9TiBWkf7TUtPKW5el9u6UYdClqEy5F6DErmuA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4C1D013DD7 for ; Sat, 16 Mar 2024 13:10:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlSrs-0001Sw-Mt; Sat, 16 Mar 2024 08:10:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlSrp-0001Se-Pj for guix-patches@gnu.org; Sat, 16 Mar 2024 08:10:26 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlSrp-00022k-H1 for guix-patches@gnu.org; Sat, 16 Mar 2024 08:10:25 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rlSsQ-0006HX-Bl for guix-patches@gnu.org; Sat, 16 Mar 2024 08:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69579] [PATCH] gnu: python-joblib: Update to 1.3.2. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Mar 2024 12:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69579 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: vagrant@debian.org, 69579@debbugs.gnu.org X-Debbugs-Original-Cc: Vagrant Cascadian , guix-patches@gnu.org, 69579@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171059105424129 (code B ref -1); Sat, 16 Mar 2024 12:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Mar 2024 12:10:54 +0000 Received: from localhost ([127.0.0.1]:55101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlSsI-0006H6-3g for submit@debbugs.gnu.org; Sat, 16 Mar 2024 08:10:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:38814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlSsG-0006Gw-B3 for submit@debbugs.gnu.org; Sat, 16 Mar 2024 08:10:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlSre-0001Rn-U1 for guix-patches@gnu.org; Sat, 16 Mar 2024 08:10:15 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlSrc-00022D-LG for guix-patches@gnu.org; Sat, 16 Mar 2024 08:10:14 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 1408E27BBEA; Sat, 16 Mar 2024 12:10:10 +0000 (GMT) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 4ccb2052; Sat, 16 Mar 2024 12:10:09 +0000 (UTC) References: <20240306093803.4725-1-ngraves@ngraves.fr> <87ttlgbh6y.fsf@wireframe> <87ttlaljc9.fsf@ngraves.fr> <87plvyuwxj.fsf@cbaines.net> <87wmq6p907.fsf@ngraves.fr> <87bk7f2to3.fsf@ngraves.fr> User-agent: mu4e 1.10.8; emacs 29.1 From: Christopher Baines Date: Sat, 16 Mar 2024 12:08:53 +0000 In-reply-to: <87bk7f2to3.fsf@ngraves.fr> Message-ID: <87plvuqsww.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -7.10 X-Spam-Score: -7.10 X-Migadu-Queue-Id: 4C1D013DD7 X-TUID: LmR8DcgGSoxm --=-=-= Content-Type: text/plain Nicolas Graves writes: > On 2024-03-13 14:16, Nicolas Graves wrote: > >> On 2024-03-13 12:39, Christopher Baines wrote: >> >>> Nicolas Graves via Guix-patches via writes: >>> >>>> On 2024-03-08 12:29, Vagrant Cascadian wrote: >>>> >>>>> On 2024-03-06, Nicolas Graves wrote: >>>>>> * gnu/packages/python-xyz.scm (python-joblib): Update to 1.3.2. >>>>>> [build-system]: Update to pyproject-build-system. >>>>>> [arguments] >>>>>> <#:phases>: Remove check phase. >>>>>> <#:test-flags>: Keep former test flag. >>>>>> [propagated-inputs]: Add python-psutil. >>>>>> >>>>>> Change-Id: Ide110a19431b1d26e1d7dd8d1adc3b3f0f417749 >>>>>> --- >>>>>> gnu/packages/python-xyz.scm | 22 ++++++++-------------- >>>>>> 1 file changed, 8 insertions(+), 14 deletions(-) >>>>>> >>>>>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm >>>>>> index 46232d3c98..122dca6e4e 100644 >>>>>> --- a/gnu/packages/python-xyz.scm >>>>>> +++ b/gnu/packages/python-xyz.scm >>>>>> @@ -6169,26 +6169,20 @@ (define-public python-pystitcher >>>>>> (define-public python-joblib >>>>>> (package >>>>>> (name "python-joblib") >>>>>> - (version "1.1.1") >>>>>> + (version "1.3.2") >>>>>> (source (origin >>>>>> (method url-fetch) >>>>>> (uri (pypi-uri "joblib" version)) >>>>>> (sha256 >>>>>> (base32 >>>>>> - "0019p280s2k941mihl67l7y6amwx86639xp3zvpsg1lmyish67rh")))) >>>>>> - (build-system python-build-system) >>>>>> + "1cbjjzsh9hzaqr2cqja95673p7j88b8bd02hjpkq8xz147k6by4j")))) >>>>>> + (build-system pyproject-build-system) >>>>>> (arguments >>>>>> - `(#:phases >>>>>> - (modify-phases %standard-phases >>>>>> - (replace 'check >>>>>> - (lambda* (#:key tests? #:allow-other-keys) >>>>>> - (when tests? >>>>>> - (setenv "JOBLIB_MULTIPROCESSING" "0") >>> >>> We should look at why this was added, and whether it should be kept. >> >> This is only present in the check phase, not in the final package. I >> guess when we switched to the pyproject-build-system or simply updated, >> this simply wasn't necessary anymore. >> >> Since tests were consistantly (--check) passing, I do not see the need >> to investigate that. > > Christopher, is that good enough of an explanation to get this one > merged or would you rather have mpe really investigating it? I think it's good to check the commit message at least: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=a41f93c39d03143ce9007ad278a04fa30498bc0b Given that there's no reasoning there for this change, I think it's fine to remove. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmX1jB9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcIWw/+PpTEK35yKOP6RCgjhs2pP0UlgnuV4xk9 deL9SqElU0hVaDWSttC+YcbB+i5hTmvzROJr1D/DgRwg8CL5TnhSGOLo4cvNIO5p +8GzIEU5VIqe8b+xTeku2rKZN97S4xpl9Hns1EcwrYTOnl8Y9hspedMgBthIal6M UVIPCe9ZT2lrOPEkF5QFkbspGLwvjd6U8uVhtvl4xJk+qkHD0EwRZRhMwzElVLSW ede/JLKX4xEMLe9Hk6pb3NYgI6cc50h9IeEiwj38QdAuFRH2PkgT5eMvI6jey7hT QMThISFQ1s04ShKJDwmWy7OafGvSo7vli4iqMKw2yZPOZ0pwiCRKRfoftUfLm2fc QswvKmsVyR7g2MiUsEJRgSJveCw/dS9RaVXeiYekRUQy6T49F11nRiC8IMIItGh+ XS2VrKnLQ8+8My8cKonYIEcEdvtqn4OPZ4qmxEh77SsjZh/KF9BtDxwE/vtchY4n kzGrnmoKMY3Nzc058Wf8xjnlaq32Iiq+uaxM21bzDqO+iEv2IDD/O/g5VgvJNY0H ulghMvf+kTGuWSTmwZdgAP9CLSCx3gRyZVMumPNi4QZ8h5Nw9I51OWmQJDetbJMu h7kHDxDDj7iRPWTkZSinGYgxQYAUsoWqskC34KNLqdnUHpL47bR6jFGrAKU50guf KDtxZCD4uSk= =HeHu -----END PGP SIGNATURE----- --=-=-=--